docs: fix placeholder links and docs workflow deprecations#515
Conversation
okalachev
left a comment
okalachev
left a comment
There was a problem hiding this comment.
Hi!
Thanks for the documentation fixes! But can you please explain your changes in the workflows?
.github/workflows/build-image.yaml
Outdated
| - 'clover_blocks/**' | ||
| - 'clover_description/**' | ||
| - 'clover_simulation/**' | ||
| - 'roswww_static/**' |
There was a problem hiding this comment.
It's a paths filter on the pull_request trigger — the workflow only runs when a PR touches one of the listed ROS package directories. Intent was to skip the image build for docs-only PRs like this one. It's a separate commit (4678375) and doesn't really belong in a docs: PR. I'll revert it here and, if it's still useful, open a separate PR for discussion.
.github/workflows/build.yml
Outdated
| - 'clover_blocks/**' | ||
| - 'clover_description/**' | ||
| - 'clover_simulation/**' | ||
| - 'roswww_static/**' |
There was a problem hiding this comment.
Same commit, same intent — skip catkin build on docs-only PRs. Reverting together with the other one.
| rm _book/clover_en.pdf && mv _book/clover_en_compressed.pdf _book/clover_en.pdf | ||
| ls -lah _book/clover*.pdf | ||
| echo '::set-output name=GITBOOK_PDF_OK::1' | ||
| echo 'GITBOOK_PDF_OK=1' >> "$GITHUB_OUTPUT" |
There was a problem hiding this comment.
::set-output was deprecated by GitHub Actions on 2022-10-11 and now prints a deprecation warning in the runner log; the replacement is appending name=value to the $GITHUB_OUTPUT file. Behavior is identical — the downstream steps.generate-pdf.outputs.GITBOOK_PDF_OK check still works the same way.
😀 Reference: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
fly-pigTH
force-pushed
the
review/high-confidence-pr-fixes
branch
from
4678375 to
7c5fd6e
Compare
|
👍 |
2 participants
Summary
Validation