Open
Conversation
no Filter::signatures; no feature 'signatures'; no Text::CleanFragment required (replacement into HTTP::Upload::FlowJs::Utils MIME::Detect is optional
Also:
* remove unneeded maxPendingUploads
* chunkSize in jsConfig()
* move optional modules to recommends * fix travis.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
Here is your module with less deps. It doesn't require addition modules (Text::CleanFragment and MIME::Detect are optional). Also it doesn't require last-perl-features. So it could be used on Perl 5.16+ without addition modules.
Also fix some issues (not proper checking chunk length).
Need to test behaviour on some circumstances (not sure it is problem in my project, in this module or flow.js): when in app you got all chunks, but app crashes on combining, then it doesn't allow to upload/combine chunks again.