Skip to content

Feature/nrmi 295 urn upload error handling #1264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reemi1510 wants to merge 3 commits into
base: develop
Choose a base branch
from
+13 −3
Open

Feature/nrmi 295 urn upload error handling #1264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
46dbe3c
added error handling to urn upload and spec
reemi1510 Mar 31, 2026
0cc61c0
rubocop
reemi1510 Mar 31, 2026
28b5fb3
Merge branch 'develop' into feature/nrmi-295-urn-upload-error-handling
reemi1510 Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions app/controllers/admin/urn_lists_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ def create
if @urn_list.save
UrnListImporterJob.perform_later(@urn_list)

return redirect_to admin_urn_lists_path
redirect_to admin_urn_lists_path
end

render action: :new
rescue ActionController::ParameterMissing
redirect_to new_admin_urn_list_path, alert: 'Please choose a file to upload'
end

def download
Expand Down
10 changes: 10 additions & 0 deletions spec/features/admin_can_upload_urn_list_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,14 @@

expect(UrnListImporterJob).to have_been_enqueued
end

context 'without attaching a file' do
scenario 'displays an error' do
visit new_admin_urn_list_path

click_button 'Upload'

expect(page).to have_text 'Please choose a file to upload'
end
end
end
Loading