Skip to content

fix(registry): remove duplicate BLAKE2b-HMAC variant (#752) #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mehrn0ush wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −5
Open

fix(registry): remove duplicate BLAKE2b-HMAC variant (#752) #753

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions schema/cryptography-defs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,16 @@
"pattern": "AES[-(128|192|256)][-(GCM|CCM)][-{tagLength}][-{ivLength}]",
"primitive": "ae"
},
{
"standard": [
{
"name": "RFC 8452",
"url": "https://doi.org/10.17487/RFC8452"
}
],
"pattern": "AES[-(128|192|256)]-GCM-SIV[-{tagLength}][-{ivLength}]",
"primitive": "ae"
},
{
"standard": [
{
Expand Down Expand Up @@ -935,11 +945,11 @@
"primitive": "hash"
},
{
"pattern": "BLAKE2b-(160|256|384|512)-HMAC",
Copy link
Contributor

@bhess bhess Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intention was to describe BLAKE2s with HMAC (instead of BLAKE2b), so this appears to be a typo that caused the duplicate. Could you please update the pattern to BLAKE2s-(160|256|384|512)-HMAC rather than removing the entry?

Copy link
Author

@Mehrn0ush Mehrn0ush Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review, @bhess — agreed this was a typo.

I updated the entry to preserve both HMAC variants by correcting the duplicate to:

  • BLAKE2s-(160|256)-HMAC

Note: BLAKE2s only defines 160/256-bit digests (whereas BLAKE2b supports up to 512), so I kept the size set aligned with the existing BLAKE2s-(160|256) variant.

PR updated (amended) accordingly.

Copy link
Contributor

@bhess bhess Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, thanks!

"pattern": "BLAKE2s-(160|256)-HMAC",
"primitive": "mac"
}
]
},
},
{
"family": "BLAKE3",
"standard": [
Expand Down Expand Up @@ -1018,11 +1028,11 @@
],
"variant": [
{
"pattern": "TUAC[-MAC]",
"pattern": "TUAK[-MAC]",
"primitive": "mac"
},
{
"pattern": "TUAC[-KDF]",
"pattern": "TUAK[-KDF]",
"primitive": "kdf"
}
]
Expand Down Expand Up @@ -1407,7 +1417,7 @@
],
"variant": [
{
"pattern": "bcrypt[-{cost)]",
"pattern": "bcrypt[-{cost}]",
"primitive": "hash"
}
]
Expand Down