Titles can be localized from config. Lock screen DMPasscode method.#15
Open
StDogbert wants to merge 2 commits intoD-32:masterfrom
Open
Titles can be localized from config. Lock screen DMPasscode method.#15StDogbert wants to merge 2 commits intoD-32:masterfrom
StDogbert wants to merge 2 commits intoD-32:masterfrom
Conversation
…asn't working from cocoapods. Also this is more intuitive when u can configure those things from code and not thinking where exactly u should add those localized strings for 3rd party bundle. Added localization files for english and russian in demo app. New method lock screen. U can call it when app goes to background and it will handle everything itself. It will check if there is pass code set, and if input is already displayed. Also lock screen doesn't have close button. Probably button for lock screen should be added in config, in case somebody whants to provide help or different action in case user is stack on lock screen. I will add it later. Also, if input is already shown while displaying lock screen it will be dismissed and replaced by lock screen. Did it to avoid situation when user entered input mode from app and screen has close button, and then u lock ur app and go back. This way u could theoretically close input and gather some info whithout entering pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit messages are self explanatory. I described all changes there.