feat(core): add generic StateMachine base class for typed state transitions#811
Closed
ryuwd wants to merge 1 commit intoDIRACGrid:mainfrom
Closed
feat(core): add generic StateMachine base class for typed state transitions#811ryuwd wants to merge 1 commit intoDIRACGrid:mainfrom
ryuwd wants to merge 1 commit intoDIRACGrid:mainfrom
Conversation
Reusable declarative state machine utility for diracx. Each system subclasses StateMachine with StrEnum states and a transitions dict. Validation runs at class creation via __init_subclass__.
Contributor
|
Is there any github issue linked to your PR? |
Contributor
|
Given that:
I'm closing this PR for now. Please feel free to reopen it once a proper GitHub issue describing the use case has been created and the topic has been discussed in a ddev meeting. Thank you for your understanding. |
Contributor
Author
|
I understand the reasons for closing, particularly since more discussion and design is needed, but it's clear that a more modern solution and cleanup will eventually be needed for DiracX as from my experience moving the job routes (including job status transitions) we shoot ourselves in the foot by continuing to rely on the legacy impl and behaviours. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reusable declarative state machine utility for diracx. Each system subclasses StateMachine with StrEnum states and a transitions dict. Validation runs at class creation via init_subclass.