Skip to content

Fix improve UX for back button on workflow bitstream downloads (#4146)#5080

Open
guillermo-escire wants to merge 1 commit intoDSpace:mainfrom
guillermo-escire:feature/4146
Open

Fix improve UX for back button on workflow bitstream downloads (#4146)#5080
guillermo-escire wants to merge 1 commit intoDSpace:mainfrom
guillermo-escire:feature/4146

Conversation

@guillermo-escire
Copy link
Contributor

References

Description

This PR improves navigation reliability during workflow bitstream downloads by removing the Back button from the bitstream download page.
The button could lead to a Whitelabel error in certain workflow navigation scenarios due to missing or invalid navigation history.

Instructions for Reviewers

This PR removes the Back button from the bitstream download page, as suggested in issue #4146, to ensure consistent and predictable behavior across the UI.

List of changes in this PR:

  • Removed the Back button from bitstream-download-page.component.html.
  • Removed the unused back() method and related Location dependency from BitstreamDownloadPageComponent.

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

  1. Go to a workflow item page (e.g. /workflowitems/{id}/view).

  2. Download a bitstream.

  3. Verify that:

    • The download still works as expected.
    • No Back button is displayed on the bitstream download page.
    • Navigation relies on the browser back button, avoiding Whitelabel errors.
  4. Confirm that bitstream downloads from the Full Item Page and Admin UI remain unaffected.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added improvement component: workflow 1 APPROVAL pull request only requires a single approval to merge labels Feb 3, 2026
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge component: workflow improvement

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

Improve UX for back button on workflow bitstream downloads

2 participants