Skip to content

[Port dspace-9_x] Fix #5454: Group edits are immediately reflected in the user interface#5615

Merged
tdonohue merged 2 commits into
DSpace:dspace-9_xfrom
guillermo-escire:backport/5454-dspace-9x
May 4, 2026
Merged

[Port dspace-9_x] Fix #5454: Group edits are immediately reflected in the user interface#5615
tdonohue merged 2 commits into
DSpace:dspace-9_xfrom
guillermo-escire:backport/5454-dspace-9x

Conversation

@guillermo-escire
Copy link
Copy Markdown
Contributor

References

Description

Manual backport of PR #5461 to dspace-9_x. The automatic backport PR #5482 had compilation issues, so this is a manual cherry-pick of the fix.

Instructions for Reviewers

List of changes in this PR:

  • Added patchValue call after a successful group edit so the form fields reflect the updated values immediately without requiring a page refresh.
  • Added unit test using fakeAsync/tick to verify the form is updated after onSubmit().

To test:

  1. Log in as System Administrator
  2. Go to Admin Menu → Access Control → Groups
  3. Edit an existing group and change the name
  4. Click Save
  5. Verify the "Group name" field immediately shows the updated name without refreshing the page

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

Fix DSpace#5454: Group edits are immediately reflected in the user interface
@lgeggleston lgeggleston added bug authorization related to authorization, permissions or groups ux User Experience related works testathon Reported by a tester during Community Testathon labels May 4, 2026
@lgeggleston lgeggleston moved this to 👍 Reviewer Approved in DSpace Maintenance (9.x, 8.x, 7.6.x) May 4, 2026
@lgeggleston lgeggleston added this to the 9.3 milestone May 4, 2026
Copy link
Copy Markdown
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @guillermo-escire ! This looks good to me

@tdonohue tdonohue merged commit 2e3a300 into DSpace:dspace-9_x May 4, 2026
16 checks passed
@github-project-automation github-project-automation Bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace Maintenance (9.x, 8.x, 7.6.x) May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

authorization related to authorization, permissions or groups bug testathon Reported by a tester during Community Testathon ux User Experience related works

Projects

Development

Successfully merging this pull request may close these issues.

3 participants