Fix OpenSearch service and search URL construction#5862
Open
kshepherd wants to merge 1 commit into
Open
Conversation
- requires equivalent backend PR (same name) to set websvc.opensearch.svcconext to just 'opensearch'
7 tasks
tdonohue
approved these changes
Jun 24, 2026
tdonohue
left a comment
Member
There was a problem hiding this comment.
👍 Thanks @kshepherd ! I tested this alongside the backend PR (DSpace/DSpace#12700) and verified that they fix the OpenSearch issues and that RSS feeds still work properly.
This PR however needs to wait to be merged until the backend is ready to merge. See my comments on the backend PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
OpenSearch service URLs in DSpace 7.0 - 10.0 are broken, because they are prefixed with the full
opensearch/searchpath instead of justopensearch/. This PR along with the related PR ensure that correct service and search URLs are constructed.Instructions for Reviewers
Note to reviewers re: failing unit tests - these failures are due to the fact that the main branch currently has
/opensearch/searchset as the svccontext value, so search URLs end up as/opensearch/search/searchin current tests. Once DSpace/DSpace#12700 is merged, these tests will pass.Changes:
rss.component.tsso that thewebsvc.opensearch.svccontextis treated as a true base path (matching the controller mapping)updateRssLinks()method so that it appends/searchto the search URLs and/serviceto the service URL as appropriateTo Test:
Test instructions are the same as the backend PR: DSpace/DSpace#12700
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)