👷 Add 'dependencies' label to bump-chrome-version PRs#4710
Open
thomas-lebeau wants to merge 1 commit into
Open
👷 Add 'dependencies' label to bump-chrome-version PRs#4710thomas-lebeau wants to merge 1 commit into
thomas-lebeau wants to merge 1 commit into
Conversation
Bundles Sizes Evolution
|
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 4ff8e4e | Docs | Datadog PR Page | Give us feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
bump-chrome-versionscript creates PRs to update the Chrome version used in tests. These PRs should be labeled asdependenciesso they can be handled by the same interrupt handler skill as other dependency update PRs.Changes
createPullRequest()inscripts/lib/gitUtils.tsto accept an optionallabelsparameter and pass them as--labelflags togh pr createbump-chrome-version.tsto pass the'dependencies'label when creating its PRTest instructions
The change is in the CI script that bumps Chrome version. To verify:
createPullRequestnow accepts an optionallabelsargumentbump-chrome-version.tspasses['dependencies']tocreatePullRequestChecklist