🐛 Send partial snapshots after debugger capture timeout#4734
Draft
watson wants to merge 1 commit into
Draft
Conversation
Do not drop debugger snapshots when snapshot capture exceeds the timeout budget. Instead, keep the active entry and queue the partial snapshot so timeout markers can be delivered to intake. Update timeout tests to cover entry, return, throw, and shared-deadline probes.
Bundles Sizes Evolution
|
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: a9b221d | Docs | Datadog PR Page | Give us feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
Debugger snapshots were dropped when snapshot capture exceeded the timeout budget. This meant customers could miss useful partial snapshot data, including timeout markers that explain why capture is incomplete.
Changes
Stop skipping snapshot delivery when capture times out in
onEntry,onReturn, andonThrow.Update unit tests to expect partial snapshots to be sent for entry, return, throw, and shared-deadline timeout cases.
Test instructions
Run
yarn test:unit --spec packages/browser-debugger/src/domain/api.spec.ts --spec packages/browser-debugger/src/domain/capture.spec.tsChecklist