Skip to content

🐛 Send partial snapshots after debugger capture timeout#4734

Draft
watson wants to merge 1 commit into
mainfrom
watson/send-partial-snapshot
Draft

🐛 Send partial snapshots after debugger capture timeout#4734
watson wants to merge 1 commit into
mainfrom
watson/send-partial-snapshot

Conversation

@watson
Copy link
Copy Markdown
Collaborator

@watson watson commented Jun 5, 2026

Motivation

Debugger snapshots were dropped when snapshot capture exceeded the timeout budget. This meant customers could miss useful partial snapshot data, including timeout markers that explain why capture is incomplete.

Changes

Stop skipping snapshot delivery when capture times out in onEntry, onReturn, and onThrow.

Update unit tests to expect partial snapshots to be sent for entry, return, throw, and shared-deadline timeout cases.

Test instructions

Run yarn test:unit --spec packages/browser-debugger/src/domain/api.spec.ts --spec packages/browser-debugger/src/domain/capture.spec.ts

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.
  • Updated documentation and/or relevant AGENTS.md file

Do not drop debugger snapshots when snapshot capture exceeds the timeout budget.
Instead, keep the active entry and queue the partial snapshot so timeout markers can
be delivered to intake.

Update timeout tests to cover entry, return, throw, and shared-deadline probes.
Copy link
Copy Markdown
Collaborator Author

watson commented Jun 5, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cit-pr-commenter-54b7da
Copy link
Copy Markdown

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 171.86 KiB 171.86 KiB 0 B 0.00%
Rum Profiler 7.88 KiB 7.88 KiB 0 B 0.00%
Rum Recorder 21.21 KiB 21.21 KiB 0 B 0.00%
Logs 54.31 KiB 54.31 KiB 0 B 0.00%
Rum Slim 129.69 KiB 129.69 KiB 0 B 0.00%
Worker 22.96 KiB 22.96 KiB 0 B 0.00%

@datadog-datadog-prod-us1-2
Copy link
Copy Markdown

datadog-datadog-prod-us1-2 Bot commented Jun 5, 2026

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 76.74% (+0.02%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a9b221d | Docs | Datadog PR Page | Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant