-
Notifications
You must be signed in to change notification settings - Fork 47
Eventbridge Cloudtrail Cloudformation Template #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
dwikle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what all this is but LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@klivan Can you change this file name to cloudtrail-eventbridge-single-region.yaml so we can have another generic eventbridge one later if we want. Same thing for the master template eventbridge.yaml
jvanbrie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Note: Please remember to review the contribution guidelines
if you have not yet done so.
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Testing Guidelines
How did you test this pull request?
Additional Notes
Anything else we should know when reviewing?