Skip to content

Conversation

@klivan
Copy link
Contributor

@klivan klivan commented Jun 3, 2022

Note: Please remember to review the contribution guidelines
if you have not yet done so.

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Testing Guidelines

How did you test this pull request?

Additional Notes

Anything else we should know when reviewing?

@klivan klivan marked this pull request as ready for review June 24, 2022 17:15
Copy link

@dwikle dwikle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what all this is but LGTM

Copy link
Contributor

@warrierr warrierr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@klivan Can you change this file name to cloudtrail-eventbridge-single-region.yaml so we can have another generic eventbridge one later if we want. Same thing for the master template eventbridge.yaml

Copy link
Contributor

@jvanbrie jvanbrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants