Skip to content

chore(ci): add final_status property on junit XML [APMSP-2610]#287

Merged
cbeauchesne merged 6 commits intomainfrom
cbeauchesne/final_status
Mar 13, 2026
Merged

chore(ci): add final_status property on junit XML [APMSP-2610]#287
cbeauchesne merged 6 commits intomainfrom
cbeauchesne/final_status

Conversation

@cbeauchesne
Copy link
Contributor

@cbeauchesne cbeauchesne commented Mar 9, 2026

What does this PR do?

Add a <property name="dd_tags[test.final_status]" value="pass" /> on every test case reported through junit

Motivation

Some repositories intentionally use mechanisms that ignore test failures (there are valid reasons to still execute those tests behind the scenes).

In these cases, the reported test status cannot be relied upon by Test Optimization to monitor repository health or trigger team notifications.

To ensure a consistent and unified approach, we will instead use final_status — the property specifically designed and used by the Test Optimization integration for this purpose.

Important note

I'm using the not-that-ideal XSLT here as this change, because it must be done over 17+ repos, and it's a workaround until this gets integrated into a better place, such as datadog-ci or the backend.

We're trying to work with the team on this, please have a look on this RFC for more context.

How to test it ?

Now more N/A on the last commit on this query

Jira ticket: APMSP-2610

@pr-commenter
Copy link

pr-commenter bot commented Mar 9, 2026

Benchmarks

Benchmark execution time: 2026-03-13 14:34:30

Comparing candidate commit 73838ec in PR branch cbeauchesne/final_status with baseline commit f8c3913 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@datadog-official

This comment has been minimized.

@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.70%. Comparing base (f8c3913) to head (73838ec).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #287      +/-   ##
==========================================
- Coverage   87.76%   87.70%   -0.07%     
==========================================
  Files          84       84              
  Lines        5658     5668      +10     
==========================================
+ Hits         4966     4971       +5     
- Misses        692      697       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cbeauchesne cbeauchesne merged commit 2bbc991 into main Mar 13, 2026
39 checks passed
@cbeauchesne cbeauchesne deleted the cbeauchesne/final_status branch March 13, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants