-
Notifications
You must be signed in to change notification settings - Fork 322
Add a limit to the number of elements we process in a mongo document #10277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vandonr
wants to merge
1
commit into
master
Choose a base branch
from
vandonr/fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+100
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.58.0-SNAPSHOT~6c2def347b, baseline=1.58.0-SNAPSHOT~33864ab8fb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.084 s) : 0, 1084442
Total [baseline] (8.77 s) : 0, 8770170
Agent [candidate] (1.085 s) : 0, 1085437
Total [candidate] (8.731 s) : 0, 8731310
section iast
Agent [baseline] (1.225 s) : 0, 1224591
Total [baseline] (9.331 s) : 0, 9330770
Agent [candidate] (1.234 s) : 0, 1233608
Total [candidate] (9.329 s) : 0, 9328786
gantt
title insecure-bank - break down per module: candidate=1.58.0-SNAPSHOT~6c2def347b, baseline=1.58.0-SNAPSHOT~33864ab8fb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (651.762 ms) : 0, 651762
BytebuddyAgent [candidate] (653.365 ms) : 0, 653365
GlobalTracer [baseline] (281.855 ms) : 0, 281855
GlobalTracer [candidate] (282.246 ms) : 0, 282246
AppSec [baseline] (32.598 ms) : 0, 32598
AppSec [candidate] (32.671 ms) : 0, 32671
Debugger [baseline] (67.952 ms) : 0, 67952
Debugger [candidate] (66.904 ms) : 0, 66904
Remote Config [baseline] (639.216 µs) : 0, 639
Remote Config [candidate] (632.287 µs) : 0, 632
Telemetry [baseline] (9.035 ms) : 0, 9035
Telemetry [candidate] (9.068 ms) : 0, 9068
Flare Poller [baseline] (3.72 ms) : 0, 3720
Flare Poller [candidate] (3.751 ms) : 0, 3751
section iast
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.196 ms) : 0, 1196
BytebuddyAgent [baseline] (793.322 ms) : 0, 793322
BytebuddyAgent [candidate] (799.952 ms) : 0, 799952
GlobalTracer [baseline] (254.988 ms) : 0, 254988
GlobalTracer [candidate] (257.108 ms) : 0, 257108
IAST [baseline] (26.985 ms) : 0, 26985
IAST [candidate] (27.405 ms) : 0, 27405
AppSec [baseline] (33.754 ms) : 0, 33754
AppSec [candidate] (33.581 ms) : 0, 33581
Debugger [baseline] (66.173 ms) : 0, 66173
Debugger [candidate] (66.079 ms) : 0, 66079
Remote Config [baseline] (591.199 µs) : 0, 591
Remote Config [candidate] (609.724 µs) : 0, 610
Telemetry [baseline] (8.538 ms) : 0, 8538
Telemetry [candidate] (8.467 ms) : 0, 8467
Flare Poller [baseline] (3.548 ms) : 0, 3548
Flare Poller [candidate] (3.551 ms) : 0, 3551
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.58.0-SNAPSHOT~6c2def347b, baseline=1.58.0-SNAPSHOT~33864ab8fb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.085 s) : 0, 1084692
Total [baseline] (10.758 s) : 0, 10758002
Agent [candidate] (1.092 s) : 0, 1092176
Total [candidate] (10.857 s) : 0, 10856896
section appsec
Agent [baseline] (1.266 s) : 0, 1265599
Total [baseline] (10.882 s) : 0, 10881692
Agent [candidate] (1.266 s) : 0, 1266356
Total [candidate] (10.904 s) : 0, 10904070
section iast
Agent [baseline] (1.233 s) : 0, 1232931
Total [baseline] (11.175 s) : 0, 11175194
Agent [candidate] (1.222 s) : 0, 1221827
Total [candidate] (11.158 s) : 0, 11158373
section profiling
Agent [baseline] (1.208 s) : 0, 1208263
Total [baseline] (10.981 s) : 0, 10980594
Agent [candidate] (1.216 s) : 0, 1216375
Total [candidate] (11.039 s) : 0, 11039247
gantt
title petclinic - break down per module: candidate=1.58.0-SNAPSHOT~6c2def347b, baseline=1.58.0-SNAPSHOT~33864ab8fb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (651.14 ms) : 0, 651140
BytebuddyAgent [candidate] (656.445 ms) : 0, 656445
GlobalTracer [baseline] (282.478 ms) : 0, 282478
GlobalTracer [candidate] (284.078 ms) : 0, 284078
AppSec [baseline] (32.522 ms) : 0, 32522
AppSec [candidate] (32.882 ms) : 0, 32882
Debugger [baseline] (68.449 ms) : 0, 68449
Debugger [candidate] (68.333 ms) : 0, 68333
Remote Config [baseline] (618.052 µs) : 0, 618
Remote Config [candidate] (619.26 µs) : 0, 619
Telemetry [baseline] (8.986 ms) : 0, 8986
Telemetry [candidate] (9.072 ms) : 0, 9072
Flare Poller [baseline] (3.747 ms) : 0, 3747
Flare Poller [candidate] (3.76 ms) : 0, 3760
section appsec
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.18 ms) : 0, 1180
BytebuddyAgent [baseline] (692.124 ms) : 0, 692124
BytebuddyAgent [candidate] (691.882 ms) : 0, 691882
GlobalTracer [baseline] (257.91 ms) : 0, 257910
GlobalTracer [candidate] (258.032 ms) : 0, 258032
IAST [baseline] (24.568 ms) : 0, 24568
IAST [candidate] (24.758 ms) : 0, 24758
AppSec [baseline] (174.553 ms) : 0, 174553
AppSec [candidate] (174.385 ms) : 0, 174385
Debugger [baseline] (66.093 ms) : 0, 66093
Debugger [candidate] (66.8 ms) : 0, 66800
Remote Config [baseline] (764.545 µs) : 0, 765
Remote Config [candidate] (771.423 µs) : 0, 771
Telemetry [baseline] (9.355 ms) : 0, 9355
Telemetry [candidate] (9.467 ms) : 0, 9467
Flare Poller [baseline] (3.587 ms) : 0, 3587
Flare Poller [candidate] (3.714 ms) : 0, 3714
section iast
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (796.694 ms) : 0, 796694
BytebuddyAgent [candidate] (790.713 ms) : 0, 790713
GlobalTracer [baseline] (257.617 ms) : 0, 257617
GlobalTracer [candidate] (255.198 ms) : 0, 255198
IAST [baseline] (27.378 ms) : 0, 27378
IAST [candidate] (26.9 ms) : 0, 26900
AppSec [baseline] (33.921 ms) : 0, 33921
AppSec [candidate] (35.375 ms) : 0, 35375
Debugger [baseline] (67.544 ms) : 0, 67544
Debugger [candidate] (64.477 ms) : 0, 64477
Remote Config [baseline] (612.0 µs) : 0, 612
Remote Config [candidate] (563.976 µs) : 0, 564
Telemetry [baseline] (8.691 ms) : 0, 8691
Telemetry [candidate] (8.436 ms) : 0, 8436
Flare Poller [baseline] (3.627 ms) : 0, 3627
Flare Poller [candidate] (3.53 ms) : 0, 3530
section profiling
crashtracking [baseline] (1.213 ms) : 0, 1213
crashtracking [candidate] (1.245 ms) : 0, 1245
BytebuddyAgent [baseline] (704.96 ms) : 0, 704960
BytebuddyAgent [candidate] (710.25 ms) : 0, 710250
GlobalTracer [baseline] (220.928 ms) : 0, 220928
GlobalTracer [candidate] (221.734 ms) : 0, 221734
AppSec [baseline] (32.232 ms) : 0, 32232
AppSec [candidate] (32.515 ms) : 0, 32515
Debugger [baseline] (68.009 ms) : 0, 68009
Debugger [candidate] (68.548 ms) : 0, 68548
Remote Config [baseline] (665.284 µs) : 0, 665
Remote Config [candidate] (638.039 µs) : 0, 638
Telemetry [baseline] (8.769 ms) : 0, 8769
Telemetry [candidate] (8.918 ms) : 0, 8918
Flare Poller [baseline] (3.754 ms) : 0, 3754
Flare Poller [candidate] (3.824 ms) : 0, 3824
ProfilingAgent [baseline] (97.809 ms) : 0, 97809
ProfilingAgent [candidate] (98.29 ms) : 0, 98290
Profiling [baseline] (98.386 ms) : 0, 98386
Profiling [candidate] (98.9 ms) : 0, 98900
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~6c2def347b, baseline=1.58.0-SNAPSHOT~33864ab8fb
dateFormat X
axisFormat %s
section baseline
no_agent (19.307 ms) : 19110, 19504
. : milestone, 19307,
appsec (18.605 ms) : 18412, 18797
. : milestone, 18605,
code_origins (18.025 ms) : 17844, 18207
. : milestone, 18025,
iast (17.738 ms) : 17565, 17911
. : milestone, 17738,
profiling (18.726 ms) : 18540, 18912
. : milestone, 18726,
tracing (17.764 ms) : 17586, 17942
. : milestone, 17764,
section candidate
no_agent (18.058 ms) : 17877, 18238
. : milestone, 18058,
appsec (18.643 ms) : 18455, 18830
. : milestone, 18643,
code_origins (17.904 ms) : 17723, 18084
. : milestone, 17904,
iast (18.137 ms) : 17956, 18317
. : milestone, 18137,
profiling (18.727 ms) : 18538, 18915
. : milestone, 18727,
tracing (18.62 ms) : 18434, 18807
. : milestone, 18620,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~6c2def347b, baseline=1.58.0-SNAPSHOT~33864ab8fb
dateFormat X
axisFormat %s
section baseline
no_agent (1.184 ms) : 1172, 1196
. : milestone, 1184,
iast (3.095 ms) : 3055, 3134
. : milestone, 3095,
iast_FULL (5.665 ms) : 5608, 5721
. : milestone, 5665,
iast_GLOBAL (3.624 ms) : 3570, 3678
. : milestone, 3624,
profiling (1.922 ms) : 1906, 1938
. : milestone, 1922,
tracing (1.759 ms) : 1744, 1773
. : milestone, 1759,
section candidate
no_agent (1.183 ms) : 1171, 1196
. : milestone, 1183,
iast (3.206 ms) : 3164, 3247
. : milestone, 3206,
iast_FULL (5.829 ms) : 5770, 5888
. : milestone, 5829,
iast_GLOBAL (3.422 ms) : 3373, 3471
. : milestone, 3422,
profiling (1.894 ms) : 1879, 1909
. : milestone, 1894,
tracing (1.751 ms) : 1737, 1765
. : milestone, 1751,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~6c2def347b, baseline=1.58.0-SNAPSHOT~33864ab8fb
dateFormat X
axisFormat %s
section baseline
no_agent (1.483 ms) : 1472, 1495
. : milestone, 1483,
appsec (3.735 ms) : 3516, 3954
. : milestone, 3735,
iast (2.211 ms) : 2147, 2275
. : milestone, 2211,
iast_GLOBAL (2.263 ms) : 2198, 2328
. : milestone, 2263,
profiling (2.056 ms) : 2004, 2108
. : milestone, 2056,
tracing (2.049 ms) : 1997, 2100
. : milestone, 2049,
section candidate
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (3.699 ms) : 3481, 3917
. : milestone, 3699,
iast (2.213 ms) : 2148, 2278
. : milestone, 2213,
iast_GLOBAL (2.263 ms) : 2198, 2328
. : milestone, 2263,
profiling (2.491 ms) : 2331, 2651
. : milestone, 2491,
tracing (2.044 ms) : 1993, 2095
. : milestone, 2044,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~6c2def347b, baseline=1.58.0-SNAPSHOT~33864ab8fb
dateFormat X
axisFormat %s
section baseline
no_agent (15.272 s) : 15272000, 15272000
. : milestone, 15272000,
appsec (14.58 s) : 14580000, 14580000
. : milestone, 14580000,
iast (18.414 s) : 18414000, 18414000
. : milestone, 18414000,
iast_GLOBAL (17.924 s) : 17924000, 17924000
. : milestone, 17924000,
profiling (14.702 s) : 14702000, 14702000
. : milestone, 14702000,
tracing (14.688 s) : 14688000, 14688000
. : milestone, 14688000,
section candidate
no_agent (14.965 s) : 14965000, 14965000
. : milestone, 14965000,
appsec (14.972 s) : 14972000, 14972000
. : milestone, 14972000,
iast (18.299 s) : 18299000, 18299000
. : milestone, 18299000,
iast_GLOBAL (17.851 s) : 17851000, 17851000
. : milestone, 17851000,
profiling (14.61 s) : 14610000, 14610000
. : milestone, 14610000,
tracing (14.698 s) : 14698000, 14698000
. : milestone, 14698000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
stop adding elements to the internal string we build for Bson documents once we have reached a certain number.
This has been shown to create memory issues for customers (see linked escalation tickets in the task)
Motivation
customer escalation
Additional Notes
This is potentially a breaking change, because the resource name would change in some cases, but I think in the cases where this would happen, the resource name would be super long and unusable by humans, so it's very unlikely customers would rely on its value.
(tbh, it's still be super long and unusable after that change, since the limit is pretty high, at 256, but at least it wouldn't cause memory issues - hopefully)
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: AIDM-267