-
Notifications
You must be signed in to change notification settings - Fork 322
Split play-2.4 module #10279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Split play-2.4 module #10279
+157
−219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dules - play-2.4: Base module with Play 2.4 core instrumentation only - play-2.5: Intermediate module for Play 2.5 (depends on play-2.4) - play-2.5-appsec: AppSec instrumentation for Play 2.5+ (depends on play-2.5) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
There's no need for a separate source set now that play 2.5 is in extracted. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
amarziali
reviewed
Dec 31, 2025
dd-java-agent/instrumentation/play/play-2.5-appsec/build.gradle
Outdated
Show resolved
Hide resolved
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.58.0-SNAPSHOT~7022fc2bf1, baseline=1.58.0-SNAPSHOT~2a419dbac3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.088 s) : 0, 1088404
Total [baseline] (8.763 s) : 0, 8762526
Agent [candidate] (1.096 s) : 0, 1095690
Total [candidate] (8.772 s) : 0, 8772104
section iast
Agent [baseline] (1.222 s) : 0, 1222033
Total [baseline] (9.295 s) : 0, 9295440
Agent [candidate] (1.238 s) : 0, 1237842
Total [candidate] (9.353 s) : 0, 9353231
gantt
title insecure-bank - break down per module: candidate=1.58.0-SNAPSHOT~7022fc2bf1, baseline=1.58.0-SNAPSHOT~2a419dbac3
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.202 ms) : 0, 1202
crashtracking [candidate] (1.201 ms) : 0, 1201
BytebuddyAgent [baseline] (654.97 ms) : 0, 654970
BytebuddyAgent [candidate] (657.528 ms) : 0, 657528
GlobalTracer [baseline] (283.018 ms) : 0, 283018
GlobalTracer [candidate] (285.83 ms) : 0, 285830
AppSec [baseline] (32.643 ms) : 0, 32643
AppSec [candidate] (33.237 ms) : 0, 33237
Debugger [baseline] (67.31 ms) : 0, 67310
Debugger [candidate] (68.525 ms) : 0, 68525
Remote Config [baseline] (652.707 µs) : 0, 653
Remote Config [candidate] (654.757 µs) : 0, 655
Telemetry [baseline] (9.039 ms) : 0, 9039
Telemetry [candidate] (9.138 ms) : 0, 9138
Flare Poller [baseline] (3.79 ms) : 0, 3790
Flare Poller [candidate] (3.826 ms) : 0, 3826
section iast
crashtracking [baseline] (1.203 ms) : 0, 1203
crashtracking [candidate] (1.208 ms) : 0, 1208
BytebuddyAgent [baseline] (791.605 ms) : 0, 791605
BytebuddyAgent [candidate] (804.304 ms) : 0, 804304
GlobalTracer [baseline] (254.925 ms) : 0, 254925
GlobalTracer [candidate] (257.387 ms) : 0, 257387
AppSec [baseline] (34.312 ms) : 0, 34312
AppSec [candidate] (34.993 ms) : 0, 34993
Debugger [baseline] (64.838 ms) : 0, 64838
Debugger [candidate] (64.132 ms) : 0, 64132
Remote Config [baseline] (617.631 µs) : 0, 618
Remote Config [candidate] (592.374 µs) : 0, 592
Telemetry [baseline] (8.458 ms) : 0, 8458
Telemetry [candidate] (8.58 ms) : 0, 8580
Flare Poller [baseline] (3.529 ms) : 0, 3529
Flare Poller [candidate] (3.544 ms) : 0, 3544
IAST [baseline] (27.037 ms) : 0, 27037
IAST [candidate] (27.359 ms) : 0, 27359
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.58.0-SNAPSHOT~7022fc2bf1, baseline=1.58.0-SNAPSHOT~2a419dbac3
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.085 s) : 0, 1084870
Total [baseline] (10.773 s) : 0, 10773226
Agent [candidate] (1.091 s) : 0, 1091061
Total [candidate] (10.912 s) : 0, 10912431
section appsec
Agent [baseline] (1.267 s) : 0, 1266783
Total [baseline] (10.954 s) : 0, 10953778
Agent [candidate] (1.267 s) : 0, 1267207
Total [candidate] (10.919 s) : 0, 10919442
section iast
Agent [baseline] (1.231 s) : 0, 1230637
Total [baseline] (11.233 s) : 0, 11232686
Agent [candidate] (1.222 s) : 0, 1222446
Total [candidate] (11.152 s) : 0, 11152470
section profiling
Agent [baseline] (1.208 s) : 0, 1207940
Total [baseline] (10.971 s) : 0, 10971291
Agent [candidate] (1.213 s) : 0, 1213194
Total [candidate] (11.028 s) : 0, 11027978
gantt
title petclinic - break down per module: candidate=1.58.0-SNAPSHOT~7022fc2bf1, baseline=1.58.0-SNAPSHOT~2a419dbac3
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.217 ms) : 0, 1217
BytebuddyAgent [baseline] (650.767 ms) : 0, 650767
BytebuddyAgent [candidate] (655.021 ms) : 0, 655021
GlobalTracer [baseline] (282.856 ms) : 0, 282856
GlobalTracer [candidate] (283.68 ms) : 0, 283680
AppSec [baseline] (32.632 ms) : 0, 32632
AppSec [candidate] (32.874 ms) : 0, 32874
Debugger [baseline] (68.421 ms) : 0, 68421
Debugger [candidate] (68.862 ms) : 0, 68862
Remote Config [baseline] (608.67 µs) : 0, 609
Remote Config [candidate] (625.73 µs) : 0, 626
Telemetry [baseline] (9.045 ms) : 0, 9045
Telemetry [candidate] (9.187 ms) : 0, 9187
Flare Poller [baseline] (3.785 ms) : 0, 3785
Flare Poller [candidate] (3.859 ms) : 0, 3859
section appsec
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (692.103 ms) : 0, 692103
BytebuddyAgent [candidate] (693.063 ms) : 0, 693063
GlobalTracer [baseline] (258.18 ms) : 0, 258180
GlobalTracer [candidate] (258.505 ms) : 0, 258505
IAST [baseline] (24.869 ms) : 0, 24869
IAST [candidate] (24.769 ms) : 0, 24769
AppSec [baseline] (174.039 ms) : 0, 174039
AppSec [candidate] (174.558 ms) : 0, 174558
Debugger [baseline] (67.093 ms) : 0, 67093
Debugger [candidate] (65.904 ms) : 0, 65904
Remote Config [baseline] (764.289 µs) : 0, 764
Remote Config [candidate] (735.853 µs) : 0, 736
Telemetry [baseline] (9.449 ms) : 0, 9449
Telemetry [candidate] (9.424 ms) : 0, 9424
Flare Poller [baseline] (3.645 ms) : 0, 3645
Flare Poller [candidate] (3.623 ms) : 0, 3623
section iast
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.178 ms) : 0, 1178
BytebuddyAgent [baseline] (795.47 ms) : 0, 795470
BytebuddyAgent [candidate] (790.727 ms) : 0, 790727
GlobalTracer [baseline] (257.07 ms) : 0, 257070
GlobalTracer [candidate] (255.335 ms) : 0, 255335
IAST [baseline] (27.474 ms) : 0, 27474
IAST [candidate] (27.12 ms) : 0, 27120
AppSec [baseline] (35.685 ms) : 0, 35685
AppSec [candidate] (32.656 ms) : 0, 32656
Debugger [baseline] (65.548 ms) : 0, 65548
Debugger [candidate] (67.482 ms) : 0, 67482
Remote Config [baseline] (582.293 µs) : 0, 582
Remote Config [candidate] (568.856 µs) : 0, 569
Telemetry [baseline] (8.599 ms) : 0, 8599
Telemetry [candidate] (8.408 ms) : 0, 8408
Flare Poller [baseline] (3.586 ms) : 0, 3586
Flare Poller [candidate] (3.551 ms) : 0, 3551
section profiling
crashtracking [baseline] (1.212 ms) : 0, 1212
crashtracking [candidate] (1.23 ms) : 0, 1230
BytebuddyAgent [baseline] (705.106 ms) : 0, 705106
BytebuddyAgent [candidate] (708.152 ms) : 0, 708152
GlobalTracer [baseline] (220.986 ms) : 0, 220986
GlobalTracer [candidate] (221.88 ms) : 0, 221880
AppSec [baseline] (32.19 ms) : 0, 32190
AppSec [candidate] (32.336 ms) : 0, 32336
Debugger [baseline] (67.927 ms) : 0, 67927
Debugger [candidate] (68.467 ms) : 0, 68467
Remote Config [baseline] (649.0 µs) : 0, 649
Remote Config [candidate] (632.113 µs) : 0, 632
Telemetry [baseline] (8.834 ms) : 0, 8834
Telemetry [candidate] (8.731 ms) : 0, 8731
Flare Poller [baseline] (3.718 ms) : 0, 3718
Flare Poller [candidate] (3.732 ms) : 0, 3732
ProfilingAgent [baseline] (97.363 ms) : 0, 97363
ProfilingAgent [candidate] (97.756 ms) : 0, 97756
Profiling [baseline] (97.943 ms) : 0, 97943
Profiling [candidate] (98.346 ms) : 0, 98346
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 4 performance regressions! Performance is the same for 13 metrics, 18 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~7022fc2bf1, baseline=1.58.0-SNAPSHOT~2a419dbac3
dateFormat X
axisFormat %s
section baseline
no_agent (1.188 ms) : 1176, 1200
. : milestone, 1188,
iast (3.24 ms) : 3193, 3286
. : milestone, 3240,
iast_FULL (5.585 ms) : 5529, 5640
. : milestone, 5585,
iast_GLOBAL (3.669 ms) : 3613, 3726
. : milestone, 3669,
profiling (1.873 ms) : 1858, 1888
. : milestone, 1873,
tracing (1.831 ms) : 1814, 1848
. : milestone, 1831,
section candidate
no_agent (1.184 ms) : 1173, 1196
. : milestone, 1184,
iast (3.181 ms) : 3137, 3225
. : milestone, 3181,
iast_FULL (5.829 ms) : 5771, 5887
. : milestone, 5829,
iast_GLOBAL (3.725 ms) : 3667, 3784
. : milestone, 3725,
profiling (2.079 ms) : 2059, 2099
. : milestone, 2079,
tracing (1.762 ms) : 1748, 1777
. : milestone, 1762,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~7022fc2bf1, baseline=1.58.0-SNAPSHOT~2a419dbac3
dateFormat X
axisFormat %s
section baseline
no_agent (18.61 ms) : 18416, 18803
. : milestone, 18610,
appsec (19.611 ms) : 19408, 19813
. : milestone, 19611,
code_origins (17.491 ms) : 17318, 17664
. : milestone, 17491,
iast (17.794 ms) : 17615, 17973
. : milestone, 17794,
profiling (19.307 ms) : 19113, 19502
. : milestone, 19307,
tracing (17.616 ms) : 17440, 17792
. : milestone, 17616,
section candidate
no_agent (19.438 ms) : 19237, 19640
. : milestone, 19438,
appsec (18.64 ms) : 18450, 18831
. : milestone, 18640,
code_origins (18.607 ms) : 18420, 18794
. : milestone, 18607,
iast (17.84 ms) : 17662, 18018
. : milestone, 17840,
profiling (19.62 ms) : 19420, 19819
. : milestone, 19620,
tracing (17.531 ms) : 17356, 17707
. : milestone, 17531,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~7022fc2bf1, baseline=1.58.0-SNAPSHOT~2a419dbac3
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1465, 1488
. : milestone, 1477,
appsec (3.737 ms) : 3518, 3956
. : milestone, 3737,
iast (2.21 ms) : 2145, 2274
. : milestone, 2210,
iast_GLOBAL (2.258 ms) : 2192, 2324
. : milestone, 2258,
profiling (2.062 ms) : 2010, 2115
. : milestone, 2062,
tracing (2.04 ms) : 1989, 2091
. : milestone, 2040,
section candidate
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (3.726 ms) : 3507, 3946
. : milestone, 3726,
iast (2.206 ms) : 2142, 2271
. : milestone, 2206,
iast_GLOBAL (2.247 ms) : 2182, 2312
. : milestone, 2247,
profiling (2.058 ms) : 2005, 2111
. : milestone, 2058,
tracing (2.048 ms) : 1997, 2099
. : milestone, 2048,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~7022fc2bf1, baseline=1.58.0-SNAPSHOT~2a419dbac3
dateFormat X
axisFormat %s
section baseline
no_agent (15.564 s) : 15564000, 15564000
. : milestone, 15564000,
appsec (14.664 s) : 14664000, 14664000
. : milestone, 14664000,
iast (18.131 s) : 18131000, 18131000
. : milestone, 18131000,
iast_GLOBAL (17.866 s) : 17866000, 17866000
. : milestone, 17866000,
profiling (15.33 s) : 15330000, 15330000
. : milestone, 15330000,
tracing (14.721 s) : 14721000, 14721000
. : milestone, 14721000,
section candidate
no_agent (15.338 s) : 15338000, 15338000
. : milestone, 15338000,
appsec (14.725 s) : 14725000, 14725000
. : milestone, 14725000,
iast (18.468 s) : 18468000, 18468000
. : milestone, 18468000,
iast_GLOBAL (18.026 s) : 18026000, 18026000
. : milestone, 18026000,
profiling (14.966 s) : 14966000, 14966000
. : milestone, 14966000,
tracing (14.806 s) : 14806000, 14806000
. : milestone, 14806000,
|
amarziali
approved these changes
Dec 31, 2025
bc3dea7 to
7022fc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
inst: play framework
Play Framework instrumentation
tag: ai generated
Largely based on code generated by an AI or LLM
type: enhancement
Enhancements and improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Split play 2.4 module in multiple modules.
Motivation
Play-2.4 module has multiple source sets and a non-straightforward project configuration. This was introduced in:
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]