Skip to content

Reorganise internal instrumentation to comply with the renaming policy #10280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
amarziali merged 4 commits into from
Dec 31, 2025
Merged

Reorganise internal instrumentation to comply with the renaming policy #10280

amarziali merged 4 commits into from
Dec 31, 2025

Conversation

@amarziali
Copy link
Contributor

@amarziali amarziali commented Dec 31, 2025

What Does This Do

Finish the refactoring of instrumentation modules by putting internal modules under datadog top folder.
This folder is not checked by the instrumentationNamingPlugin

The instrumentation under this folder are classified by product:

  • tracing
  • asm
  • dynamic-instrumentation
  • profiling

The codeowner has been updated

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali amarziali added inst: others All other instrumentations tag: no release notes Changes to exclude from release notes type: refactoring labels Dec 31, 2025
@amarziali amarziali requested review from a team as code owners December 31, 2025 15:04
@amarziali amarziali requested review from PerfectSlayer, claponcet and manuel-alvarez-alvarez and removed request for a team December 31, 2025 15:04
@amarziali amarziali requested a review from bric3 December 31, 2025 15:06
bric3
bric3 approved these changes Dec 31, 2025
View reviewed changes
buildSrc/src/main/kotlin/datadog/gradle/plugin/naming/InstrumentationNamingPlugin.kt
return@childLoop
}
// skip the special datadog top level instrumentation directory
if (parentName == null && moduleName == "datadog") {
Copy link
Contributor

@bric3 bric3 Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Maybe declare the excluded module name in the plugin extension. This can be done in a follow-up PR.

Copy link
Contributor Author

@amarziali amarziali Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the exclusion list works for a single module but not for all its childs. It can be expanded to support this. For this reason I kept it simple and hardcoded in this way. That said this should be the only exception of this kind

@amarziali amarziali enabled auto-merge (squash) December 31, 2025 15:28
@pr-commenter
Copy link

pr-commenter bot commented Dec 31, 2025

Kafka / producer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/finalize-renaming
git_commit_date 1767111297 1767193324
git_commit_sha 2a419db efb1049
See matching parameters
Baseline Candidate
ci_job_date 1767194488 1767194488
ci_job_id 1323109167 1323109167
ci_pipeline_id 88657828 88657828
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.25 11.0.25
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.25+9-post-Ubuntu-1ubuntu122.04 11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaProduceBenchmark.benchProduce same

@pr-commenter
Copy link

pr-commenter bot commented Dec 31, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/finalize-renaming
git_commit_date 1767111297 1767193324
git_commit_sha 2a419db efb1049
release_version 1.58.0-SNAPSHOT~2a419dbac3 1.58.0-SNAPSHOT~efb10497fc
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1767195268 1767195268
ci_job_id 1323109162 1323109162
ci_pipeline_id 88657828 88657828
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-o2g9h4ru 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-o2g9h4ru 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 12 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.58.0-SNAPSHOT~efb10497fc, baseline=1.58.0-SNAPSHOT~2a419dbac3

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.087 s) : 0, 1087008
Total [baseline] (8.732 s) : 0, 8731930
Agent [candidate] (1.092 s) : 0, 1091757
Total [candidate] (8.772 s) : 0, 8772152
section iast
Agent [baseline] (1.227 s) : 0, 1226738
Total [baseline] (9.339 s) : 0, 9339383
Agent [candidate] (1.225 s) : 0, 1224671
Total [candidate] (9.308 s) : 0, 9308245
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.087 s -
Agent iast 1.227 s 139.729 ms (12.9%)
Total tracing 8.732 s -
Total iast 9.339 s 607.453 ms (7.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.092 s -
Agent iast 1.225 s 132.914 ms (12.2%)
Total tracing 8.772 s -
Total iast 9.308 s 536.093 ms (6.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.58.0-SNAPSHOT~efb10497fc, baseline=1.58.0-SNAPSHOT~2a419dbac3

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.203 ms) : 0, 1203
crashtracking [candidate] (1.215 ms) : 0, 1215
BytebuddyAgent [baseline] (653.23 ms) : 0, 653230
BytebuddyAgent [candidate] (656.076 ms) : 0, 656076
GlobalTracer [baseline] (283.37 ms) : 0, 283370
GlobalTracer [candidate] (284.222 ms) : 0, 284222
AppSec [baseline] (32.555 ms) : 0, 32555
AppSec [candidate] (32.886 ms) : 0, 32886
Debugger [baseline] (67.651 ms) : 0, 67651
Debugger [candidate] (67.967 ms) : 0, 67967
Remote Config [baseline] (633.242 µs) : 0, 633
Remote Config [candidate] (627.39 µs) : 0, 627
Telemetry [baseline] (9.017 ms) : 0, 9017
Telemetry [candidate] (9.089 ms) : 0, 9089
Flare Poller [baseline] (3.731 ms) : 0, 3731
Flare Poller [candidate] (3.803 ms) : 0, 3803
section iast
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (794.302 ms) : 0, 794302
BytebuddyAgent [candidate] (792.714 ms) : 0, 792714
GlobalTracer [baseline] (255.623 ms) : 0, 255623
GlobalTracer [candidate] (255.819 ms) : 0, 255819
IAST [baseline] (27.182 ms) : 0, 27182
IAST [candidate] (27.039 ms) : 0, 27039
AppSec [baseline] (32.655 ms) : 0, 32655
AppSec [candidate] (33.614 ms) : 0, 33614
Debugger [baseline] (67.483 ms) : 0, 67483
Debugger [candidate] (66.171 ms) : 0, 66171
Remote Config [baseline] (575.971 µs) : 0, 576
Remote Config [candidate] (571.907 µs) : 0, 572
Telemetry [baseline] (8.609 ms) : 0, 8609
Telemetry [candidate] (8.53 ms) : 0, 8530
Flare Poller [baseline] (3.543 ms) : 0, 3543
Flare Poller [candidate] (3.493 ms) : 0, 3493
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.58.0-SNAPSHOT~efb10497fc, baseline=1.58.0-SNAPSHOT~2a419dbac3

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.093 s) : 0, 1092808
Total [baseline] (10.836 s) : 0, 10835887
Agent [candidate] (1.091 s) : 0, 1091210
Total [candidate] (10.789 s) : 0, 10789107
section appsec
Agent [baseline] (1.272 s) : 0, 1271520
Total [baseline] (10.982 s) : 0, 10981633
Agent [candidate] (1.276 s) : 0, 1275589
Total [candidate] (10.901 s) : 0, 10901405
section iast
Agent [baseline] (1.224 s) : 0, 1224205
Total [baseline] (11.11 s) : 0, 11109948
Agent [candidate] (1.226 s) : 0, 1226265
Total [candidate] (11.182 s) : 0, 11181522
section profiling
Agent [baseline] (1.206 s) : 0, 1206242
Total [baseline] (10.917 s) : 0, 10917015
Agent [candidate] (1.203 s) : 0, 1202853
Total [candidate] (10.872 s) : 0, 10872447
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.093 s -
Agent appsec 1.272 s 178.712 ms (16.4%)
Agent iast 1.224 s 131.397 ms (12.0%)
Agent profiling 1.206 s 113.434 ms (10.4%)
Total tracing 10.836 s -
Total appsec 10.982 s 145.746 ms (1.3%)
Total iast 11.11 s 274.061 ms (2.5%)
Total profiling 10.917 s 81.128 ms (0.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.091 s -
Agent appsec 1.276 s 184.379 ms (16.9%)
Agent iast 1.226 s 135.054 ms (12.4%)
Agent profiling 1.203 s 111.643 ms (10.2%)
Total tracing 10.789 s -
Total appsec 10.901 s 112.298 ms (1.0%)
Total iast 11.182 s 392.415 ms (3.6%)
Total profiling 10.872 s 83.34 ms (0.8%) 
gantt
    title petclinic - break down per module: candidate=1.58.0-SNAPSHOT~efb10497fc, baseline=1.58.0-SNAPSHOT~2a419dbac3

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (656.178 ms) : 0, 656178
BytebuddyAgent [candidate] (654.539 ms) : 0, 654539
GlobalTracer [baseline] (284.597 ms) : 0, 284597
GlobalTracer [candidate] (284.159 ms) : 0, 284159
AppSec [baseline] (32.893 ms) : 0, 32893
AppSec [candidate] (32.927 ms) : 0, 32927
Debugger [baseline] (68.076 ms) : 0, 68076
Debugger [candidate] (69.187 ms) : 0, 69187
Remote Config [baseline] (634.025 µs) : 0, 634
Remote Config [candidate] (639.269 µs) : 0, 639
Telemetry [baseline] (9.695 ms) : 0, 9695
Telemetry [candidate] (9.022 ms) : 0, 9022
Flare Poller [baseline] (3.767 ms) : 0, 3767
Flare Poller [candidate] (3.785 ms) : 0, 3785
section appsec
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.224 ms) : 0, 1224
BytebuddyAgent [baseline] (693.477 ms) : 0, 693477
BytebuddyAgent [candidate] (698.196 ms) : 0, 698196
GlobalTracer [baseline] (259.963 ms) : 0, 259963
GlobalTracer [candidate] (260.563 ms) : 0, 260563
IAST [baseline] (24.936 ms) : 0, 24936
IAST [candidate] (24.812 ms) : 0, 24812
AppSec [baseline] (175.76 ms) : 0, 175760
AppSec [candidate] (175.218 ms) : 0, 175218
Debugger [baseline] (66.67 ms) : 0, 66670
Debugger [candidate] (66.391 ms) : 0, 66391
Remote Config [baseline] (795.48 µs) : 0, 795
Remote Config [candidate] (748.647 µs) : 0, 749
Telemetry [baseline] (9.547 ms) : 0, 9547
Telemetry [candidate] (9.236 ms) : 0, 9236
Flare Poller [baseline] (3.735 ms) : 0, 3735
Flare Poller [candidate] (3.599 ms) : 0, 3599
section iast
crashtracking [baseline] (1.18 ms) : 0, 1180
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (791.667 ms) : 0, 791667
BytebuddyAgent [candidate] (792.886 ms) : 0, 792886
GlobalTracer [baseline] (255.5 ms) : 0, 255500
GlobalTracer [candidate] (255.919 ms) : 0, 255919
IAST [baseline] (27.2 ms) : 0, 27200
IAST [candidate] (26.839 ms) : 0, 26839
AppSec [baseline] (32.998 ms) : 0, 32998
AppSec [candidate] (33.977 ms) : 0, 33977
Debugger [baseline] (67.489 ms) : 0, 67489
Debugger [candidate] (67.177 ms) : 0, 67177
Remote Config [baseline] (577.574 µs) : 0, 578
Remote Config [candidate] (580.336 µs) : 0, 580
Telemetry [baseline] (8.549 ms) : 0, 8549
Telemetry [candidate] (8.584 ms) : 0, 8584
Flare Poller [baseline] (3.504 ms) : 0, 3504
Flare Poller [candidate] (3.52 ms) : 0, 3520
section profiling
crashtracking [baseline] (1.225 ms) : 0, 1225
crashtracking [candidate] (1.216 ms) : 0, 1216
BytebuddyAgent [baseline] (704.577 ms) : 0, 704577
BytebuddyAgent [candidate] (702.139 ms) : 0, 702139
GlobalTracer [baseline] (220.679 ms) : 0, 220679
GlobalTracer [candidate] (219.846 ms) : 0, 219846
AppSec [baseline] (32.138 ms) : 0, 32138
AppSec [candidate] (32.002 ms) : 0, 32002
Debugger [baseline] (67.887 ms) : 0, 67887
Debugger [candidate] (67.786 ms) : 0, 67786
Remote Config [baseline] (662.146 µs) : 0, 662
Remote Config [candidate] (622.948 µs) : 0, 623
Telemetry [baseline] (8.666 ms) : 0, 8666
Telemetry [candidate] (8.827 ms) : 0, 8827
Flare Poller [baseline] (3.666 ms) : 0, 3666
Flare Poller [candidate] (3.666 ms) : 0, 3666
ProfilingAgent [baseline] (96.871 ms) : 0, 96871
ProfilingAgent [candidate] (96.978 ms) : 0, 96978
Profiling [baseline] (97.45 ms) : 0, 97450
Profiling [candidate] (97.546 ms) : 0, 97546
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/finalize-renaming
git_commit_date 1767111297 1767193324
git_commit_sha 2a419db efb1049
release_version 1.58.0-SNAPSHOT~2a419dbac3 1.58.0-SNAPSHOT~efb10497fc
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1767195768 1767195768
ci_job_id 1323109163 1323109163
ci_pipeline_id 88657828 88657828
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-5b7vv6m1 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-5b7vv6m1 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 20 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~efb10497fc, baseline=1.58.0-SNAPSHOT~2a419dbac3
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.209 ms) : 1196, 1221
.   : milestone, 1209,
iast (3.195 ms) : 3154, 3237
.   : milestone, 3195,
iast_FULL (5.839 ms) : 5781, 5897
.   : milestone, 5839,
iast_GLOBAL (3.552 ms) : 3496, 3609
.   : milestone, 3552,
profiling (1.985 ms) : 1967, 2002
.   : milestone, 1985,
tracing (1.852 ms) : 1836, 1868
.   : milestone, 1852,
section candidate
no_agent (1.187 ms) : 1176, 1199
.   : milestone, 1187,
iast (3.107 ms) : 3072, 3142
.   : milestone, 3107,
iast_FULL (5.614 ms) : 5559, 5669
.   : milestone, 5614,
iast_GLOBAL (3.62 ms) : 3563, 3678
.   : milestone, 3620,
profiling (1.989 ms) : 1971, 2006
.   : milestone, 1989,
tracing (1.818 ms) : 1803, 1833
.   : milestone, 1818,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.209 ms [1.196 ms, 1.221 ms] -
iast 3.195 ms [3.154 ms, 3.237 ms] 1.987 ms (164.4%)
iast_FULL 5.839 ms [5.781 ms, 5.897 ms] 4.63 ms (383.1%)
iast_GLOBAL 3.552 ms [3.496 ms, 3.609 ms] 2.344 ms (193.9%)
profiling 1.985 ms [1.967 ms, 2.002 ms] 776.057 µs (64.2%)
tracing 1.852 ms [1.836 ms, 1.868 ms] 643.438 µs (53.2%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.187 ms [1.176 ms, 1.199 ms] -
iast 3.107 ms [3.072 ms, 3.142 ms] 1.92 ms (161.7%)
iast_FULL 5.614 ms [5.559 ms, 5.669 ms] 4.427 ms (372.8%)
iast_GLOBAL 3.62 ms [3.563 ms, 3.678 ms] 2.433 ms (204.9%)
profiling 1.989 ms [1.971 ms, 2.006 ms] 801.194 µs (67.5%)
tracing 1.818 ms [1.803 ms, 1.833 ms] 630.79 µs (53.1%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~efb10497fc, baseline=1.58.0-SNAPSHOT~2a419dbac3
    dateFormat X
    axisFormat %s
section baseline
no_agent (17.992 ms) : 17808, 18176
.   : milestone, 17992,
appsec (18.708 ms) : 18514, 18902
.   : milestone, 18708,
code_origins (17.974 ms) : 17793, 18154
.   : milestone, 17974,
iast (17.951 ms) : 17769, 18133
.   : milestone, 17951,
profiling (18.873 ms) : 18687, 19060
.   : milestone, 18873,
tracing (17.735 ms) : 17558, 17911
.   : milestone, 17735,
section candidate
no_agent (17.76 ms) : 17582, 17939
.   : milestone, 17760,
appsec (18.486 ms) : 18298, 18673
.   : milestone, 18486,
code_origins (17.768 ms) : 17593, 17944
.   : milestone, 17768,
iast (17.763 ms) : 17585, 17940
.   : milestone, 17763,
profiling (18.903 ms) : 18710, 19095
.   : milestone, 18903,
tracing (17.858 ms) : 17678, 18039
.   : milestone, 17858,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 17.992 ms [17.808 ms, 18.176 ms] -
appsec 18.708 ms [18.514 ms, 18.902 ms] 715.911 µs (4.0%)
code_origins 17.974 ms [17.793 ms, 18.154 ms] -18.406 µs (-0.1%)
iast 17.951 ms [17.769 ms, 18.133 ms] -41.122 µs (-0.2%)
profiling 18.873 ms [18.687 ms, 19.06 ms] 881.325 µs (4.9%)
tracing 17.735 ms [17.558 ms, 17.911 ms] -257.36 µs (-1.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 17.76 ms [17.582 ms, 17.939 ms] -
appsec 18.486 ms [18.298 ms, 18.673 ms] 725.525 µs (4.1%)
code_origins 17.768 ms [17.593 ms, 17.944 ms] 7.935 µs (0.0%)
iast 17.763 ms [17.585 ms, 17.94 ms] 2.379 µs (0.0%)
profiling 18.903 ms [18.71 ms, 19.095 ms] 1.142 ms (6.4%)
tracing 17.858 ms [17.678 ms, 18.039 ms] 97.954 µs (0.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/finalize-renaming
git_commit_date 1767111297 1767193324
git_commit_sha 2a419db efb1049
release_version 1.58.0-SNAPSHOT~2a419dbac3 1.58.0-SNAPSHOT~efb10497fc
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1767195503 1767195503
ci_job_id 1323109164 1323109164
ci_pipeline_id 88657828 88657828
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-vs7c8e55 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-vs7c8e55 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~efb10497fc, baseline=1.58.0-SNAPSHOT~2a419dbac3
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.993 s) : 14993000, 14993000
.   : milestone, 14993000,
appsec (14.756 s) : 14756000, 14756000
.   : milestone, 14756000,
iast (18.73 s) : 18730000, 18730000
.   : milestone, 18730000,
iast_GLOBAL (18.006 s) : 18006000, 18006000
.   : milestone, 18006000,
profiling (15.212 s) : 15212000, 15212000
.   : milestone, 15212000,
tracing (14.46 s) : 14460000, 14460000
.   : milestone, 14460000,
section candidate
no_agent (15.7 s) : 15700000, 15700000
.   : milestone, 15700000,
appsec (14.769 s) : 14769000, 14769000
.   : milestone, 14769000,
iast (18.289 s) : 18289000, 18289000
.   : milestone, 18289000,
iast_GLOBAL (17.793 s) : 17793000, 17793000
.   : milestone, 17793000,
profiling (14.846 s) : 14846000, 14846000
.   : milestone, 14846000,
tracing (14.714 s) : 14714000, 14714000
.   : milestone, 14714000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.993 s [14.993 s, 14.993 s] -
appsec 14.756 s [14.756 s, 14.756 s] -237.0 ms (-1.6%)
iast 18.73 s [18.73 s, 18.73 s] 3.737 s (24.9%)
iast_GLOBAL 18.006 s [18.006 s, 18.006 s] 3.013 s (20.1%)
profiling 15.212 s [15.212 s, 15.212 s] 219.0 ms (1.5%)
tracing 14.46 s [14.46 s, 14.46 s] -533.0 ms (-3.6%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.7 s [15.7 s, 15.7 s] -
appsec 14.769 s [14.769 s, 14.769 s] -931.0 ms (-5.9%)
iast 18.289 s [18.289 s, 18.289 s] 2.589 s (16.5%)
iast_GLOBAL 17.793 s [17.793 s, 17.793 s] 2.093 s (13.3%)
profiling 14.846 s [14.846 s, 14.846 s] -854.0 ms (-5.4%)
tracing 14.714 s [14.714 s, 14.714 s] -986.0 ms (-6.3%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~efb10497fc, baseline=1.58.0-SNAPSHOT~2a419dbac3
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.469 ms) : 1457, 1480
.   : milestone, 1469,
appsec (2.506 ms) : 2451, 2561
.   : milestone, 2506,
iast (2.197 ms) : 2133, 2261
.   : milestone, 2197,
iast_GLOBAL (2.243 ms) : 2179, 2308
.   : milestone, 2243,
profiling (2.045 ms) : 1993, 2098
.   : milestone, 2045,
tracing (2.038 ms) : 1987, 2089
.   : milestone, 2038,
section candidate
no_agent (1.47 ms) : 1458, 1481
.   : milestone, 1470,
appsec (3.714 ms) : 3494, 3933
.   : milestone, 3714,
iast (2.201 ms) : 2137, 2266
.   : milestone, 2201,
iast_GLOBAL (2.238 ms) : 2174, 2302
.   : milestone, 2238,
profiling (2.059 ms) : 2007, 2112
.   : milestone, 2059,
tracing (2.031 ms) : 1981, 2082
.   : milestone, 2031,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.469 ms [1.457 ms, 1.48 ms] -
appsec 2.506 ms [2.451 ms, 2.561 ms] 1.037 ms (70.6%)
iast 2.197 ms [2.133 ms, 2.261 ms] 728.409 µs (49.6%)
iast_GLOBAL 2.243 ms [2.179 ms, 2.308 ms] 774.419 µs (52.7%)
profiling 2.045 ms [1.993 ms, 2.098 ms] 576.496 µs (39.3%)
tracing 2.038 ms [1.987 ms, 2.089 ms] 569.368 µs (38.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.47 ms [1.458 ms, 1.481 ms] -
appsec 3.714 ms [3.494 ms, 3.933 ms] 2.244 ms (152.7%)
iast 2.201 ms [2.137 ms, 2.266 ms] 731.696 µs (49.8%)
iast_GLOBAL 2.238 ms [2.174 ms, 2.302 ms] 768.411 µs (52.3%)
profiling 2.059 ms [2.007 ms, 2.112 ms] 589.663 µs (40.1%)
tracing 2.031 ms [1.981 ms, 2.082 ms] 561.867 µs (38.2%)

@pr-commenter
Copy link

pr-commenter bot commented Dec 31, 2025

Kafka / consumer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/finalize-renaming
git_commit_date 1767111297 1767193324
git_commit_sha 2a419db efb1049
See matching parameters
Baseline Candidate
ci_job_date 1767194519 1767194519
ci_job_id 1323109168 1323109168
ci_pipeline_id 88657828 88657828
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.25 11.0.25
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.25+9-post-Ubuntu-1ubuntu122.04 11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaConsumerBenchmark.benchConsume same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaConsumerBenchmark.benchConsume same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaConsumerBenchmark.benchConsume same

@amarziali amarziali merged commit c713b6f into master Dec 31, 2025
568 checks passed
@amarziali amarziali deleted the andrea.marziali/finalize-renaming branch December 31, 2025 16:19
@github-actions github-actions bot added this to the 1.58.0 milestone Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bric3 bric3 bric3 approved these changes

@manuel-alvarez-alvarez manuel-alvarez-alvarez Awaiting requested review from manuel-alvarez-alvarez manuel-alvarez-alvarez is a code owner automatically assigned from DataDog/asm-java

@claponcet claponcet Awaiting requested review from claponcet claponcet is a code owner automatically assigned from DataDog/asm-java

@PerfectSlayer PerfectSlayer Awaiting requested review from PerfectSlayer PerfectSlayer is a code owner automatically assigned from DataDog/apm-lang-platform-java

Assignees

No one assigned

Labels

inst: others All other instrumentations tag: no release notes Changes to exclude from release notes type: refactoring

Projects

None yet

Milestone

1.58.0

Development

Successfully merging this pull request may close these issues.

3 participants

@amarziali @bric3