-
Notifications
You must be signed in to change notification settings - Fork 323
Implement OpenTelemetry meter instrument builders #10286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.58.0-SNAPSHOT~ccb572a501, baseline=1.58.0-SNAPSHOT~62293097d0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.092 s) : 0, 1091986
Total [baseline] (10.889 s) : 0, 10889341
Agent [candidate] (1.084 s) : 0, 1084496
Total [candidate] (10.792 s) : 0, 10791921
section appsec
Agent [baseline] (1.267 s) : 0, 1267371
Total [baseline] (10.977 s) : 0, 10977463
Agent [candidate] (1.262 s) : 0, 1262106
Total [candidate] (10.978 s) : 0, 10978403
section iast
Agent [baseline] (1.223 s) : 0, 1222516
Total [baseline] (11.229 s) : 0, 11228640
Agent [candidate] (1.22 s) : 0, 1220332
Total [candidate] (11.149 s) : 0, 11148744
section profiling
Agent [baseline] (1.203 s) : 0, 1202501
Total [baseline] (10.918 s) : 0, 10918209
Agent [candidate] (1.203 s) : 0, 1203423
Total [candidate] (10.878 s) : 0, 10878402
gantt
title petclinic - break down per module: candidate=1.58.0-SNAPSHOT~ccb572a501, baseline=1.58.0-SNAPSHOT~62293097d0
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.211 ms) : 0, 1211
crashtracking [candidate] (1.173 ms) : 0, 1173
BytebuddyAgent [baseline] (655.451 ms) : 0, 655451
BytebuddyAgent [candidate] (651.255 ms) : 0, 651255
GlobalTracer [baseline] (284.061 ms) : 0, 284061
GlobalTracer [candidate] (282.354 ms) : 0, 282354
AppSec [baseline] (32.786 ms) : 0, 32786
AppSec [candidate] (32.614 ms) : 0, 32614
Debugger [baseline] (68.496 ms) : 0, 68496
Debugger [candidate] (68.383 ms) : 0, 68383
Remote Config [baseline] (646.436 µs) : 0, 646
Remote Config [candidate] (603.466 µs) : 0, 603
Telemetry [baseline] (9.133 ms) : 0, 9133
Telemetry [candidate] (8.92 ms) : 0, 8920
Flare Poller [baseline] (4.497 ms) : 0, 4497
Flare Poller [candidate] (3.682 ms) : 0, 3682
section appsec
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (692.814 ms) : 0, 692814
BytebuddyAgent [candidate] (689.77 ms) : 0, 689770
GlobalTracer [baseline] (258.089 ms) : 0, 258089
GlobalTracer [candidate] (257.56 ms) : 0, 257560
AppSec [baseline] (172.436 ms) : 0, 172436
AppSec [candidate] (172.686 ms) : 0, 172686
Debugger [baseline] (68.969 ms) : 0, 68969
Debugger [candidate] (67.296 ms) : 0, 67296
Remote Config [baseline] (751.363 µs) : 0, 751
Remote Config [candidate] (765.118 µs) : 0, 765
Telemetry [baseline] (9.373 ms) : 0, 9373
Telemetry [candidate] (9.354 ms) : 0, 9354
Flare Poller [baseline] (3.761 ms) : 0, 3761
Flare Poller [candidate] (3.716 ms) : 0, 3716
IAST [baseline] (24.482 ms) : 0, 24482
IAST [candidate] (24.467 ms) : 0, 24467
section iast
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.177 ms) : 0, 1177
BytebuddyAgent [baseline] (790.435 ms) : 0, 790435
BytebuddyAgent [candidate] (789.487 ms) : 0, 789487
GlobalTracer [baseline] (255.691 ms) : 0, 255691
GlobalTracer [candidate] (255.38 ms) : 0, 255380
AppSec [baseline] (32.929 ms) : 0, 32929
AppSec [candidate] (32.521 ms) : 0, 32521
Debugger [baseline] (67.299 ms) : 0, 67299
Debugger [candidate] (66.947 ms) : 0, 66947
Remote Config [baseline] (565.939 µs) : 0, 566
Remote Config [candidate] (587.385 µs) : 0, 587
Telemetry [baseline] (8.469 ms) : 0, 8469
Telemetry [candidate] (8.436 ms) : 0, 8436
Flare Poller [baseline] (3.615 ms) : 0, 3615
Flare Poller [candidate] (3.565 ms) : 0, 3565
IAST [baseline] (26.999 ms) : 0, 26999
IAST [candidate] (26.882 ms) : 0, 26882
section profiling
crashtracking [baseline] (1.215 ms) : 0, 1215
crashtracking [candidate] (1.208 ms) : 0, 1208
BytebuddyAgent [baseline] (701.636 ms) : 0, 701636
BytebuddyAgent [candidate] (702.303 ms) : 0, 702303
GlobalTracer [baseline] (220.067 ms) : 0, 220067
GlobalTracer [candidate] (220.002 ms) : 0, 220002
AppSec [baseline] (32.223 ms) : 0, 32223
AppSec [candidate] (32.115 ms) : 0, 32115
Debugger [baseline] (68.048 ms) : 0, 68048
Debugger [candidate] (67.969 ms) : 0, 67969
Remote Config [baseline] (643.593 µs) : 0, 644
Remote Config [candidate] (635.742 µs) : 0, 636
Telemetry [baseline] (8.684 ms) : 0, 8684
Telemetry [candidate] (8.651 ms) : 0, 8651
Flare Poller [baseline] (3.674 ms) : 0, 3674
Flare Poller [candidate] (3.677 ms) : 0, 3677
ProfilingAgent [baseline] (96.716 ms) : 0, 96716
ProfilingAgent [candidate] (97.065 ms) : 0, 97065
Profiling [baseline] (97.294 ms) : 0, 97294
Profiling [candidate] (97.651 ms) : 0, 97651
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.58.0-SNAPSHOT~ccb572a501, baseline=1.58.0-SNAPSHOT~62293097d0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1081301
Total [baseline] (8.733 s) : 0, 8733423
Agent [candidate] (1.082 s) : 0, 1082428
Total [candidate] (8.746 s) : 0, 8745856
section iast
Agent [baseline] (1.227 s) : 0, 1226623
Total [baseline] (9.317 s) : 0, 9316941
Agent [candidate] (1.227 s) : 0, 1227323
Total [candidate] (9.326 s) : 0, 9325758
gantt
title insecure-bank - break down per module: candidate=1.58.0-SNAPSHOT~ccb572a501, baseline=1.58.0-SNAPSHOT~62293097d0
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.183 ms) : 0, 1183
BytebuddyAgent [baseline] (649.801 ms) : 0, 649801
BytebuddyAgent [candidate] (650.215 ms) : 0, 650215
GlobalTracer [baseline] (281.846 ms) : 0, 281846
GlobalTracer [candidate] (282.223 ms) : 0, 282223
AppSec [baseline] (32.639 ms) : 0, 32639
AppSec [candidate] (32.651 ms) : 0, 32651
Debugger [baseline] (66.941 ms) : 0, 66941
Debugger [candidate] (67.233 ms) : 0, 67233
Remote Config [baseline] (619.622 µs) : 0, 620
Remote Config [candidate] (610.775 µs) : 0, 611
Telemetry [baseline] (8.963 ms) : 0, 8963
Telemetry [candidate] (9.056 ms) : 0, 9056
Flare Poller [baseline] (3.831 ms) : 0, 3831
Flare Poller [candidate] (3.786 ms) : 0, 3786
section iast
crashtracking [baseline] (1.187 ms) : 0, 1187
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (793.767 ms) : 0, 793767
BytebuddyAgent [candidate] (794.484 ms) : 0, 794484
GlobalTracer [baseline] (256.669 ms) : 0, 256669
GlobalTracer [candidate] (256.726 ms) : 0, 256726
AppSec [baseline] (34.415 ms) : 0, 34415
AppSec [candidate] (34.504 ms) : 0, 34504
Debugger [baseline] (65.367 ms) : 0, 65367
Debugger [candidate] (65.233 ms) : 0, 65233
Remote Config [baseline] (604.358 µs) : 0, 604
Remote Config [candidate] (594.304 µs) : 0, 594
Telemetry [baseline] (8.534 ms) : 0, 8534
Telemetry [candidate] (8.426 ms) : 0, 8426
Flare Poller [baseline] (3.553 ms) : 0, 3553
Flare Poller [candidate] (3.615 ms) : 0, 3615
IAST [baseline] (27.093 ms) : 0, 27093
IAST [candidate] (27.15 ms) : 0, 27150
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~ccb572a501, baseline=1.58.0-SNAPSHOT~62293097d0
dateFormat X
axisFormat %s
section baseline
no_agent (1.201 ms) : 1189, 1213
. : milestone, 1201,
iast (3.09 ms) : 3052, 3129
. : milestone, 3090,
iast_FULL (5.918 ms) : 5858, 5977
. : milestone, 5918,
iast_GLOBAL (3.535 ms) : 3484, 3586
. : milestone, 3535,
profiling (2.036 ms) : 2019, 2054
. : milestone, 2036,
tracing (1.791 ms) : 1777, 1805
. : milestone, 1791,
section candidate
no_agent (1.198 ms) : 1187, 1210
. : milestone, 1198,
iast (3.206 ms) : 3159, 3254
. : milestone, 3206,
iast_FULL (5.663 ms) : 5607, 5719
. : milestone, 5663,
iast_GLOBAL (3.535 ms) : 3486, 3583
. : milestone, 3535,
profiling (1.989 ms) : 1970, 2007
. : milestone, 1989,
tracing (1.76 ms) : 1746, 1774
. : milestone, 1760,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.58.0-SNAPSHOT~ccb572a501, baseline=1.58.0-SNAPSHOT~62293097d0
dateFormat X
axisFormat %s
section baseline
no_agent (19.396 ms) : 19199, 19593
. : milestone, 19396,
appsec (18.357 ms) : 18169, 18544
. : milestone, 18357,
code_origins (18.207 ms) : 18026, 18388
. : milestone, 18207,
iast (17.955 ms) : 17779, 18131
. : milestone, 17955,
profiling (19.516 ms) : 19318, 19714
. : milestone, 19516,
tracing (17.899 ms) : 17722, 18076
. : milestone, 17899,
section candidate
no_agent (18.248 ms) : 18062, 18435
. : milestone, 18248,
appsec (18.554 ms) : 18365, 18742
. : milestone, 18554,
code_origins (17.968 ms) : 17787, 18150
. : milestone, 17968,
iast (17.866 ms) : 17687, 18045
. : milestone, 17866,
profiling (18.897 ms) : 18707, 19087
. : milestone, 18897,
tracing (17.864 ms) : 17688, 18040
. : milestone, 17864,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~ccb572a501, baseline=1.58.0-SNAPSHOT~62293097d0
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1459, 1482
. : milestone, 1471,
appsec (3.71 ms) : 3490, 3930
. : milestone, 3710,
iast (2.21 ms) : 2145, 2275
. : milestone, 2210,
iast_GLOBAL (2.25 ms) : 2185, 2314
. : milestone, 2250,
profiling (2.1 ms) : 2045, 2154
. : milestone, 2100,
tracing (2.041 ms) : 1990, 2092
. : milestone, 2041,
section candidate
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (3.669 ms) : 3455, 3884
. : milestone, 3669,
iast (2.214 ms) : 2149, 2278
. : milestone, 2214,
iast_GLOBAL (2.259 ms) : 2194, 2324
. : milestone, 2259,
profiling (2.074 ms) : 2020, 2128
. : milestone, 2074,
tracing (2.036 ms) : 1985, 2087
. : milestone, 2036,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.58.0-SNAPSHOT~ccb572a501, baseline=1.58.0-SNAPSHOT~62293097d0
dateFormat X
axisFormat %s
section baseline
no_agent (15.308 s) : 15308000, 15308000
. : milestone, 15308000,
appsec (14.335 s) : 14335000, 14335000
. : milestone, 14335000,
iast (17.828 s) : 17828000, 17828000
. : milestone, 17828000,
iast_GLOBAL (17.531 s) : 17531000, 17531000
. : milestone, 17531000,
profiling (14.961 s) : 14961000, 14961000
. : milestone, 14961000,
tracing (14.795 s) : 14795000, 14795000
. : milestone, 14795000,
section candidate
no_agent (14.867 s) : 14867000, 14867000
. : milestone, 14867000,
appsec (14.41 s) : 14410000, 14410000
. : milestone, 14410000,
iast (18.0 s) : 18000000, 18000000
. : milestone, 18000000,
iast_GLOBAL (17.883 s) : 17883000, 17883000
. : milestone, 17883000,
profiling (14.682 s) : 14682000, 14682000
. : milestone, 14682000,
tracing (14.676 s) : 14676000, 14676000
. : milestone, 14676000,
|
amarziali
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: metrics
Metrics
inst: opentelemetry
OpenTelemetry instrumentation
tag: no release notes
Changes to exclude from release notes
type: feature request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Stub out the different OpenTelemetry meter instruments and implement their builders.
Verify instrument names using the same pattern as OpenTelemetry - invalid names should log a warning and return a "no-op" instrument.
Meter storage, aggregation, and export will be implemented in separate PRs.
Similarly callbacks and observer APIs will be implemented later on, for now they default to "no-op" behaviour.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: APMAPI-1671