-
Notifications
You must be signed in to change notification settings - Fork 323
🪞 9979 - Instrumentation test error visibility #10300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This puts the details front and center in the test summary and is much easier than hunting back through log messages. Note: In InstrumentationErrors, errors are only recorded when enableRecordingAndReset has been called. This is only done from the InstrumentationSpecification test specification, so we don't need to worry about the ArrayList growing without bounds in production. I considered adding a limit to the ArrayList, but opted not to for simplicity. I also wanted to avoid silently discarding some errors.
If there is a blocked instrumentation, the test will fail and the failure message will include the same information that is logged from MuzzleCheck.
|
Created this to mainly run CI checks - there are a couple of things to clean up before this can be merged. |
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~e9388b2bab, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.09 s) : 0, 1090211
Total [baseline] (10.981 s) : 0, 10981108
Agent [candidate] (1.084 s) : 0, 1084101
Total [candidate] (10.919 s) : 0, 10918929
section appsec
Agent [baseline] (1.274 s) : 0, 1274420
Total [baseline] (10.949 s) : 0, 10948515
Agent [candidate] (1.267 s) : 0, 1266946
Total [candidate] (11.024 s) : 0, 11023503
section iast
Agent [baseline] (1.236 s) : 0, 1235847
Total [baseline] (11.369 s) : 0, 11369396
Agent [candidate] (1.225 s) : 0, 1225108
Total [candidate] (11.138 s) : 0, 11138364
section profiling
Agent [baseline] (1.205 s) : 0, 1204957
Total [baseline] (10.927 s) : 0, 10926509
Agent [candidate] (1.212 s) : 0, 1211779
Total [candidate] (10.973 s) : 0, 10973250
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~e9388b2bab, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.199 ms) : 0, 1199
crashtracking [candidate] (1.182 ms) : 0, 1182
BytebuddyAgent [baseline] (654.333 ms) : 0, 654333
BytebuddyAgent [candidate] (650.65 ms) : 0, 650650
GlobalTracer [baseline] (283.242 ms) : 0, 283242
GlobalTracer [candidate] (282.296 ms) : 0, 282296
AppSec [baseline] (32.675 ms) : 0, 32675
AppSec [candidate] (32.442 ms) : 0, 32442
Debugger [baseline] (69.693 ms) : 0, 69693
Debugger [candidate] (68.526 ms) : 0, 68526
Remote Config [baseline] (638.615 µs) : 0, 639
Remote Config [candidate] (607.856 µs) : 0, 608
Telemetry [baseline] (8.981 ms) : 0, 8981
Telemetry [candidate] (9.011 ms) : 0, 9011
Flare Poller [baseline] (3.718 ms) : 0, 3718
Flare Poller [candidate] (3.725 ms) : 0, 3725
section appsec
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (696.827 ms) : 0, 696827
BytebuddyAgent [candidate] (690.893 ms) : 0, 690893
GlobalTracer [baseline] (260.159 ms) : 0, 260159
GlobalTracer [candidate] (258.644 ms) : 0, 258644
IAST [baseline] (24.767 ms) : 0, 24767
IAST [candidate] (24.553 ms) : 0, 24553
AppSec [baseline] (174.457 ms) : 0, 174457
AppSec [candidate] (174.764 ms) : 0, 174764
Debugger [baseline] (67.519 ms) : 0, 67519
Debugger [candidate] (67.361 ms) : 0, 67361
Remote Config [baseline] (756.018 µs) : 0, 756
Remote Config [candidate] (745.278 µs) : 0, 745
Telemetry [baseline] (9.387 ms) : 0, 9387
Telemetry [candidate] (9.491 ms) : 0, 9491
Flare Poller [baseline] (3.75 ms) : 0, 3750
Flare Poller [candidate] (3.809 ms) : 0, 3809
section iast
crashtracking [baseline] (1.191 ms) : 0, 1191
crashtracking [candidate] (1.184 ms) : 0, 1184
BytebuddyAgent [baseline] (798.695 ms) : 0, 798695
BytebuddyAgent [candidate] (791.646 ms) : 0, 791646
GlobalTracer [baseline] (259.019 ms) : 0, 259019
GlobalTracer [candidate] (256.294 ms) : 0, 256294
IAST [baseline] (27.316 ms) : 0, 27316
IAST [candidate] (26.969 ms) : 0, 26969
AppSec [baseline] (33.993 ms) : 0, 33993
AppSec [candidate] (32.724 ms) : 0, 32724
Debugger [baseline] (67.098 ms) : 0, 67098
Debugger [candidate] (68.183 ms) : 0, 68183
Remote Config [baseline] (559.864 µs) : 0, 560
Remote Config [candidate] (566.83 µs) : 0, 567
Telemetry [baseline] (8.624 ms) : 0, 8624
Telemetry [candidate] (8.537 ms) : 0, 8537
Flare Poller [baseline] (3.601 ms) : 0, 3601
Flare Poller [candidate] (3.551 ms) : 0, 3551
section profiling
crashtracking [baseline] (1.234 ms) : 0, 1234
crashtracking [candidate] (1.219 ms) : 0, 1219
BytebuddyAgent [baseline] (702.855 ms) : 0, 702855
BytebuddyAgent [candidate] (707.295 ms) : 0, 707295
GlobalTracer [baseline] (220.453 ms) : 0, 220453
GlobalTracer [candidate] (221.448 ms) : 0, 221448
AppSec [baseline] (32.279 ms) : 0, 32279
AppSec [candidate] (32.391 ms) : 0, 32391
Debugger [baseline] (67.965 ms) : 0, 67965
Debugger [candidate] (68.676 ms) : 0, 68676
Remote Config [baseline] (620.288 µs) : 0, 620
Remote Config [candidate] (624.094 µs) : 0, 624
Telemetry [baseline] (8.725 ms) : 0, 8725
Telemetry [candidate] (8.809 ms) : 0, 8809
Flare Poller [baseline] (3.654 ms) : 0, 3654
Flare Poller [candidate] (3.676 ms) : 0, 3676
ProfilingAgent [baseline] (97.287 ms) : 0, 97287
ProfilingAgent [candidate] (97.442 ms) : 0, 97442
Profiling [baseline] (97.86 ms) : 0, 97860
Profiling [candidate] (98.027 ms) : 0, 98027
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~e9388b2bab, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.09 s) : 0, 1090445
Total [baseline] (8.747 s) : 0, 8747300
Agent [candidate] (1.085 s) : 0, 1085237
Total [candidate] (8.797 s) : 0, 8796576
section iast
Agent [baseline] (1.23 s) : 0, 1230263
Total [baseline] (9.363 s) : 0, 9363124
Agent [candidate] (1.223 s) : 0, 1222758
Total [candidate] (9.366 s) : 0, 9365722
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~e9388b2bab, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.202 ms) : 0, 1202
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (657.158 ms) : 0, 657158
BytebuddyAgent [candidate] (651.956 ms) : 0, 651956
GlobalTracer [baseline] (282.718 ms) : 0, 282718
GlobalTracer [candidate] (283.191 ms) : 0, 283191
AppSec [baseline] (32.836 ms) : 0, 32836
AppSec [candidate] (32.742 ms) : 0, 32742
Debugger [baseline] (67.284 ms) : 0, 67284
Debugger [candidate] (67.399 ms) : 0, 67399
Remote Config [baseline] (621.48 µs) : 0, 621
Remote Config [candidate] (621.272 µs) : 0, 621
Telemetry [baseline] (8.969 ms) : 0, 8969
Telemetry [candidate] (8.872 ms) : 0, 8872
Flare Poller [baseline] (3.744 ms) : 0, 3744
Flare Poller [candidate] (3.705 ms) : 0, 3705
section iast
crashtracking [baseline] (1.199 ms) : 0, 1199
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (796.558 ms) : 0, 796558
BytebuddyAgent [candidate] (790.716 ms) : 0, 790716
GlobalTracer [baseline] (257.422 ms) : 0, 257422
GlobalTracer [candidate] (256.002 ms) : 0, 256002
IAST [baseline] (27.331 ms) : 0, 27331
IAST [candidate] (26.993 ms) : 0, 26993
AppSec [baseline] (35.624 ms) : 0, 35624
AppSec [candidate] (33.567 ms) : 0, 33567
Debugger [baseline] (63.871 ms) : 0, 63871
Debugger [candidate] (66.08 ms) : 0, 66080
Remote Config [baseline] (607.965 µs) : 0, 608
Remote Config [candidate] (590.952 µs) : 0, 591
Telemetry [baseline] (8.444 ms) : 0, 8444
Telemetry [candidate] (8.563 ms) : 0, 8563
Flare Poller [baseline] (3.532 ms) : 0, 3532
Flare Poller [candidate] (3.562 ms) : 0, 3562
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 1 performance regressions! Performance is the same for 17 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~e9388b2bab, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section baseline
no_agent (1.192 ms) : 1180, 1204
. : milestone, 1192,
iast (3.307 ms) : 3272, 3343
. : milestone, 3307,
iast_FULL (5.839 ms) : 5780, 5898
. : milestone, 5839,
iast_GLOBAL (3.541 ms) : 3493, 3589
. : milestone, 3541,
profiling (2.058 ms) : 2039, 2076
. : milestone, 2058,
tracing (1.834 ms) : 1818, 1850
. : milestone, 1834,
section candidate
no_agent (1.174 ms) : 1163, 1186
. : milestone, 1174,
iast (3.176 ms) : 3139, 3212
. : milestone, 3176,
iast_FULL (5.529 ms) : 5475, 5584
. : milestone, 5529,
iast_GLOBAL (3.604 ms) : 3550, 3658
. : milestone, 3604,
profiling (1.958 ms) : 1941, 1974
. : milestone, 1958,
tracing (1.798 ms) : 1783, 1813
. : milestone, 1798,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~e9388b2bab, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section baseline
no_agent (18.412 ms) : 18223, 18601
. : milestone, 18412,
appsec (18.767 ms) : 18576, 18958
. : milestone, 18767,
code_origins (17.92 ms) : 17737, 18103
. : milestone, 17920,
iast (17.799 ms) : 17624, 17974
. : milestone, 17799,
profiling (18.629 ms) : 18443, 18816
. : milestone, 18629,
tracing (17.472 ms) : 17302, 17642
. : milestone, 17472,
section candidate
no_agent (18.957 ms) : 18769, 19146
. : milestone, 18957,
appsec (18.639 ms) : 18451, 18826
. : milestone, 18639,
code_origins (18.147 ms) : 17966, 18327
. : milestone, 18147,
iast (18.525 ms) : 18339, 18711
. : milestone, 18525,
profiling (18.317 ms) : 18133, 18501
. : milestone, 18317,
tracing (17.609 ms) : 17433, 17785
. : milestone, 17609,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~e9388b2bab, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section baseline
no_agent (15.038 s) : 15038000, 15038000
. : milestone, 15038000,
appsec (14.469 s) : 14469000, 14469000
. : milestone, 14469000,
iast (18.591 s) : 18591000, 18591000
. : milestone, 18591000,
iast_GLOBAL (17.955 s) : 17955000, 17955000
. : milestone, 17955000,
profiling (15.004 s) : 15004000, 15004000
. : milestone, 15004000,
tracing (14.714 s) : 14714000, 14714000
. : milestone, 14714000,
section candidate
no_agent (14.972 s) : 14972000, 14972000
. : milestone, 14972000,
appsec (14.572 s) : 14572000, 14572000
. : milestone, 14572000,
iast (17.908 s) : 17908000, 17908000
. : milestone, 17908000,
iast_GLOBAL (17.988 s) : 17988000, 17988000
. : milestone, 17988000,
profiling (14.694 s) : 14694000, 14694000
. : milestone, 14694000,
tracing (14.821 s) : 14821000, 14821000
. : milestone, 14821000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~e9388b2bab, baseline=1.59.0-SNAPSHOT~92c84e28db
dateFormat X
axisFormat %s
section baseline
no_agent (1.466 ms) : 1454, 1477
. : milestone, 1466,
appsec (3.719 ms) : 3499, 3939
. : milestone, 3719,
iast (2.211 ms) : 2145, 2276
. : milestone, 2211,
iast_GLOBAL (2.258 ms) : 2192, 2323
. : milestone, 2258,
profiling (2.057 ms) : 2004, 2110
. : milestone, 2057,
tracing (2.034 ms) : 1982, 2085
. : milestone, 2034,
section candidate
no_agent (1.467 ms) : 1455, 1478
. : milestone, 1467,
appsec (3.719 ms) : 3499, 3939
. : milestone, 3719,
iast (2.202 ms) : 2137, 2267
. : milestone, 2202,
iast_GLOBAL (2.244 ms) : 2179, 2309
. : milestone, 2244,
profiling (2.062 ms) : 2009, 2114
. : milestone, 2062,
tracing (2.039 ms) : 1988, 2091
. : milestone, 2039,
|
This PR mirrors the changes from the original community contribution to enable CI testing with maintainer privileges.
Original PR: #9979
Original Author: @deejgregor
Original Branch: deejgregor/dd-trace-java:feature-instrumentation-test-error-visibility
Closes #9979
This is an automated mirror created to run CI checks. See tooling/mirror-community-pull-request.sh for details.