-
Notifications
You must be signed in to change notification settings - Fork 323
Lazy init JNA on service discovery #10304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed looks better than #10302
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 57 metrics, 7 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.59.0-SNAPSHOT~79ad10bd8e, baseline=1.59.0-SNAPSHOT~b166862df4
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.086 s) : 0, 1085815
Total [baseline] (10.865 s) : 0, 10864580
Agent [candidate] (1.094 s) : 0, 1093890
Total [candidate] (10.829 s) : 0, 10829498
section appsec
Agent [baseline] (1.264 s) : 0, 1264414
Total [baseline] (10.842 s) : 0, 10841851
Agent [candidate] (1.28 s) : 0, 1280451
Total [candidate] (10.95 s) : 0, 10949736
section iast
Agent [baseline] (1.225 s) : 0, 1225278
Total [baseline] (11.142 s) : 0, 11142490
Agent [candidate] (1.235 s) : 0, 1235367
Total [candidate] (11.271 s) : 0, 11270793
section profiling
Agent [baseline] (1.205 s) : 0, 1204613
Total [baseline] (11.003 s) : 0, 11002714
Agent [candidate] (1.213 s) : 0, 1212552
Total [candidate] (10.907 s) : 0, 10907487
gantt
title petclinic - break down per module: candidate=1.59.0-SNAPSHOT~79ad10bd8e, baseline=1.59.0-SNAPSHOT~b166862df4
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.179 ms) : 0, 1179
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (651.454 ms) : 0, 651454
BytebuddyAgent [candidate] (656.916 ms) : 0, 656916
GlobalTracer [baseline] (283.009 ms) : 0, 283009
GlobalTracer [candidate] (285.122 ms) : 0, 285122
AppSec [baseline] (32.715 ms) : 0, 32715
AppSec [candidate] (32.922 ms) : 0, 32922
Debugger [baseline] (68.225 ms) : 0, 68225
Debugger [candidate] (68.475 ms) : 0, 68475
Remote Config [baseline] (633.32 µs) : 0, 633
Remote Config [candidate] (634.668 µs) : 0, 635
Telemetry [baseline] (9.21 ms) : 0, 9210
Telemetry [candidate] (9.128 ms) : 0, 9128
Flare Poller [baseline] (3.829 ms) : 0, 3829
Flare Poller [candidate] (3.798 ms) : 0, 3798
section appsec
crashtracking [baseline] (1.177 ms) : 0, 1177
crashtracking [candidate] (1.201 ms) : 0, 1201
BytebuddyAgent [baseline] (691.165 ms) : 0, 691165
BytebuddyAgent [candidate] (700.229 ms) : 0, 700229
GlobalTracer [baseline] (257.976 ms) : 0, 257976
GlobalTracer [candidate] (261.203 ms) : 0, 261203
IAST [baseline] (24.411 ms) : 0, 24411
IAST [candidate] (25.161 ms) : 0, 25161
AppSec [baseline] (172.655 ms) : 0, 172655
AppSec [candidate] (174.706 ms) : 0, 174706
Debugger [baseline] (67.964 ms) : 0, 67964
Debugger [candidate] (68.147 ms) : 0, 68147
Remote Config [baseline] (735.862 µs) : 0, 736
Remote Config [candidate] (734.793 µs) : 0, 735
Telemetry [baseline] (9.347 ms) : 0, 9347
Telemetry [candidate] (9.455 ms) : 0, 9455
Flare Poller [baseline] (3.692 ms) : 0, 3692
Flare Poller [candidate] (3.906 ms) : 0, 3906
section iast
crashtracking [baseline] (1.176 ms) : 0, 1176
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (790.56 ms) : 0, 790560
BytebuddyAgent [candidate] (798.7 ms) : 0, 798700
GlobalTracer [baseline] (257.21 ms) : 0, 257210
GlobalTracer [candidate] (258.261 ms) : 0, 258261
IAST [baseline] (27.25 ms) : 0, 27250
IAST [candidate] (27.336 ms) : 0, 27336
AppSec [baseline] (33.954 ms) : 0, 33954
AppSec [candidate] (33.749 ms) : 0, 33749
Debugger [baseline] (66.94 ms) : 0, 66940
Debugger [candidate] (67.612 ms) : 0, 67612
Remote Config [baseline] (579.038 µs) : 0, 579
Remote Config [candidate] (631.833 µs) : 0, 632
Telemetry [baseline] (8.644 ms) : 0, 8644
Telemetry [candidate] (8.65 ms) : 0, 8650
Flare Poller [baseline] (3.636 ms) : 0, 3636
Flare Poller [candidate] (3.646 ms) : 0, 3646
section profiling
crashtracking [baseline] (1.219 ms) : 0, 1219
crashtracking [candidate] (1.226 ms) : 0, 1226
BytebuddyAgent [baseline] (702.345 ms) : 0, 702345
BytebuddyAgent [candidate] (708.625 ms) : 0, 708625
GlobalTracer [baseline] (220.615 ms) : 0, 220615
GlobalTracer [candidate] (221.897 ms) : 0, 221897
AppSec [baseline] (32.099 ms) : 0, 32099
AppSec [candidate] (32.372 ms) : 0, 32372
Debugger [baseline] (67.852 ms) : 0, 67852
Debugger [candidate] (68.535 ms) : 0, 68535
Remote Config [baseline] (625.809 µs) : 0, 626
Remote Config [candidate] (628.491 µs) : 0, 628
Telemetry [baseline] (8.762 ms) : 0, 8762
Telemetry [candidate] (8.691 ms) : 0, 8691
Flare Poller [baseline] (3.65 ms) : 0, 3650
Flare Poller [candidate] (3.639 ms) : 0, 3639
ProfilingAgent [baseline] (97.635 ms) : 0, 97635
ProfilingAgent [candidate] (96.64 ms) : 0, 96640
Profiling [baseline] (98.224 ms) : 0, 98224
Profiling [candidate] (97.216 ms) : 0, 97216
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.59.0-SNAPSHOT~79ad10bd8e, baseline=1.59.0-SNAPSHOT~b166862df4
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.081 s) : 0, 1081346
Total [baseline] (8.678 s) : 0, 8678200
Agent [candidate] (1.092 s) : 0, 1092402
Total [candidate] (8.802 s) : 0, 8801518
section iast
Agent [baseline] (1.224 s) : 0, 1223663
Total [baseline] (9.374 s) : 0, 9373856
Agent [candidate] (1.22 s) : 0, 1220385
Total [candidate] (9.286 s) : 0, 9285710
gantt
title insecure-bank - break down per module: candidate=1.59.0-SNAPSHOT~79ad10bd8e, baseline=1.59.0-SNAPSHOT~b166862df4
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (649.826 ms) : 0, 649826
BytebuddyAgent [candidate] (655.957 ms) : 0, 655957
GlobalTracer [baseline] (281.724 ms) : 0, 281724
GlobalTracer [candidate] (285.681 ms) : 0, 285681
AppSec [baseline] (32.46 ms) : 0, 32460
AppSec [candidate] (32.848 ms) : 0, 32848
Debugger [baseline] (67.412 ms) : 0, 67412
Debugger [candidate] (67.556 ms) : 0, 67556
Remote Config [baseline] (619.814 µs) : 0, 620
Remote Config [candidate] (620.802 µs) : 0, 621
Telemetry [baseline] (8.956 ms) : 0, 8956
Telemetry [candidate] (9.048 ms) : 0, 9048
Flare Poller [baseline] (3.722 ms) : 0, 3722
Flare Poller [candidate] (3.809 ms) : 0, 3809
section iast
crashtracking [baseline] (1.184 ms) : 0, 1184
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (791.944 ms) : 0, 791944
BytebuddyAgent [candidate] (789.683 ms) : 0, 789683
GlobalTracer [baseline] (255.888 ms) : 0, 255888
GlobalTracer [candidate] (255.49 ms) : 0, 255490
AppSec [baseline] (34.332 ms) : 0, 34332
AppSec [candidate] (35.267 ms) : 0, 35267
Debugger [baseline] (64.978 ms) : 0, 64978
Debugger [candidate] (63.681 ms) : 0, 63681
Remote Config [baseline] (581.431 µs) : 0, 581
Remote Config [candidate] (605.691 µs) : 0, 606
Telemetry [baseline] (8.464 ms) : 0, 8464
Telemetry [candidate] (8.5 ms) : 0, 8500
Flare Poller [baseline] (3.588 ms) : 0, 3588
Flare Poller [candidate] (3.528 ms) : 0, 3528
IAST [baseline] (27.21 ms) : 0, 27210
IAST [candidate] (26.921 ms) : 0, 26921
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 18 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~79ad10bd8e, baseline=1.59.0-SNAPSHOT~b166862df4
dateFormat X
axisFormat %s
section baseline
no_agent (1.207 ms) : 1195, 1219
. : milestone, 1207,
iast (3.184 ms) : 3137, 3231
. : milestone, 3184,
iast_FULL (5.631 ms) : 5576, 5686
. : milestone, 5631,
iast_GLOBAL (3.696 ms) : 3638, 3753
. : milestone, 3696,
profiling (1.882 ms) : 1866, 1897
. : milestone, 1882,
tracing (1.762 ms) : 1748, 1777
. : milestone, 1762,
section candidate
no_agent (1.174 ms) : 1162, 1185
. : milestone, 1174,
iast (3.269 ms) : 3226, 3313
. : milestone, 3269,
iast_FULL (5.691 ms) : 5635, 5747
. : milestone, 5691,
iast_GLOBAL (3.526 ms) : 3474, 3577
. : milestone, 3526,
profiling (2.071 ms) : 2052, 2089
. : milestone, 2071,
tracing (1.787 ms) : 1773, 1802
. : milestone, 1787,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.59.0-SNAPSHOT~79ad10bd8e, baseline=1.59.0-SNAPSHOT~b166862df4
dateFormat X
axisFormat %s
section baseline
no_agent (19.159 ms) : 18963, 19355
. : milestone, 19159,
appsec (18.857 ms) : 18661, 19052
. : milestone, 18857,
code_origins (17.886 ms) : 17708, 18064
. : milestone, 17886,
iast (17.59 ms) : 17418, 17763
. : milestone, 17590,
profiling (19.035 ms) : 18846, 19225
. : milestone, 19035,
tracing (17.658 ms) : 17483, 17833
. : milestone, 17658,
section candidate
no_agent (19.344 ms) : 19144, 19545
. : milestone, 19344,
appsec (19.536 ms) : 19334, 19737
. : milestone, 19536,
code_origins (17.588 ms) : 17416, 17761
. : milestone, 17588,
iast (17.641 ms) : 17467, 17815
. : milestone, 17641,
profiling (18.536 ms) : 18350, 18721
. : milestone, 18536,
tracing (17.57 ms) : 17397, 17744
. : milestone, 17570,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~79ad10bd8e, baseline=1.59.0-SNAPSHOT~b166862df4
dateFormat X
axisFormat %s
section baseline
no_agent (14.981 s) : 14981000, 14981000
. : milestone, 14981000,
appsec (14.847 s) : 14847000, 14847000
. : milestone, 14847000,
iast (18.333 s) : 18333000, 18333000
. : milestone, 18333000,
iast_GLOBAL (17.694 s) : 17694000, 17694000
. : milestone, 17694000,
profiling (15.027 s) : 15027000, 15027000
. : milestone, 15027000,
tracing (14.98 s) : 14980000, 14980000
. : milestone, 14980000,
section candidate
no_agent (14.749 s) : 14749000, 14749000
. : milestone, 14749000,
appsec (14.897 s) : 14897000, 14897000
. : milestone, 14897000,
iast (18.124 s) : 18124000, 18124000
. : milestone, 18124000,
iast_GLOBAL (17.819 s) : 17819000, 17819000
. : milestone, 17819000,
profiling (14.564 s) : 14564000, 14564000
. : milestone, 14564000,
tracing (14.632 s) : 14632000, 14632000
. : milestone, 14632000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.59.0-SNAPSHOT~79ad10bd8e, baseline=1.59.0-SNAPSHOT~b166862df4
dateFormat X
axisFormat %s
section baseline
no_agent (1.488 ms) : 1476, 1499
. : milestone, 1488,
appsec (3.77 ms) : 3544, 3997
. : milestone, 3770,
iast (2.225 ms) : 2160, 2290
. : milestone, 2225,
iast_GLOBAL (2.276 ms) : 2210, 2341
. : milestone, 2276,
profiling (2.072 ms) : 2020, 2125
. : milestone, 2072,
tracing (2.063 ms) : 2012, 2114
. : milestone, 2063,
section candidate
no_agent (1.485 ms) : 1473, 1496
. : milestone, 1485,
appsec (3.739 ms) : 3517, 3962
. : milestone, 3739,
iast (2.228 ms) : 2163, 2292
. : milestone, 2228,
iast_GLOBAL (2.28 ms) : 2214, 2345
. : milestone, 2280,
profiling (2.098 ms) : 2044, 2153
. : milestone, 2098,
tracing (2.063 ms) : 2012, 2114
. : milestone, 2063,
|
dougqh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
What Does This Do
JNA initialisation usually trigger unix command executions that creates process execution spans. This causes the smoke test to count more spans hence it made it failing.
This PR lazy init the JNA subsystem on the first usage (happening at write - compatible with the current place where the tracing is muted)
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]