Update Telemetry Key Normalization to Use Environment Variables#10823
Open
Update Telemetry Key Normalization to Use Environment Variables#10823
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 64 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~b8c6f5627d, baseline=1.61.0-SNAPSHOT~6f142855b8
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1064534
Total [baseline] (11.067 s) : 0, 11067410
Agent [candidate] (1.061 s) : 0, 1061338
Total [candidate] (11.111 s) : 0, 11110751
section appsec
Agent [baseline] (1.249 s) : 0, 1249125
Total [baseline] (11.176 s) : 0, 11175519
Agent [candidate] (1.246 s) : 0, 1245893
Total [candidate] (11.165 s) : 0, 11165253
section iast
Agent [baseline] (1.238 s) : 0, 1237549
Total [baseline] (11.413 s) : 0, 11412965
Agent [candidate] (1.237 s) : 0, 1236551
Total [candidate] (11.37 s) : 0, 11369548
section profiling
Agent [baseline] (1.192 s) : 0, 1192041
Total [baseline] (11.01 s) : 0, 11010048
Agent [candidate] (1.181 s) : 0, 1180900
Total [candidate] (11.101 s) : 0, 11100851
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~b8c6f5627d, baseline=1.61.0-SNAPSHOT~6f142855b8
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.212 ms) : 0, 1212
crashtracking [candidate] (1.202 ms) : 0, 1202
BytebuddyAgent [baseline] (630.909 ms) : 0, 630909
BytebuddyAgent [candidate] (628.655 ms) : 0, 628655
AgentMeter [baseline] (29.272 ms) : 0, 29272
AgentMeter [candidate] (29.11 ms) : 0, 29110
GlobalTracer [baseline] (258.274 ms) : 0, 258274
GlobalTracer [candidate] (257.338 ms) : 0, 257338
AppSec [baseline] (31.584 ms) : 0, 31584
AppSec [candidate] (31.4 ms) : 0, 31400
Debugger [baseline] (59.628 ms) : 0, 59628
Debugger [candidate] (59.467 ms) : 0, 59467
Remote Config [baseline] (612.143 µs) : 0, 612
Remote Config [candidate] (614.502 µs) : 0, 615
Telemetry [baseline] (8.757 ms) : 0, 8757
Telemetry [candidate] (8.721 ms) : 0, 8721
Flare Poller [baseline] (8.114 ms) : 0, 8114
Flare Poller [candidate] (8.777 ms) : 0, 8777
section appsec
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.19 ms) : 0, 1190
BytebuddyAgent [baseline] (659.732 ms) : 0, 659732
BytebuddyAgent [candidate] (657.717 ms) : 0, 657717
AgentMeter [baseline] (12.093 ms) : 0, 12093
AgentMeter [candidate] (12.04 ms) : 0, 12040
GlobalTracer [baseline] (258.943 ms) : 0, 258943
GlobalTracer [candidate] (258.478 ms) : 0, 258478
IAST [baseline] (24.035 ms) : 0, 24035
IAST [candidate] (24.01 ms) : 0, 24010
AppSec [baseline] (177.582 ms) : 0, 177582
AppSec [candidate] (177.352 ms) : 0, 177352
Debugger [baseline] (65.056 ms) : 0, 65056
Debugger [candidate] (65.695 ms) : 0, 65695
Remote Config [baseline] (581.696 µs) : 0, 582
Remote Config [candidate] (564.076 µs) : 0, 564
Telemetry [baseline] (9.859 ms) : 0, 9859
Telemetry [candidate] (9.021 ms) : 0, 9021
Flare Poller [baseline] (3.653 ms) : 0, 3653
Flare Poller [candidate] (3.597 ms) : 0, 3597
section iast
crashtracking [baseline] (1.212 ms) : 0, 1212
crashtracking [candidate] (1.196 ms) : 0, 1196
BytebuddyAgent [baseline] (802.389 ms) : 0, 802389
BytebuddyAgent [candidate] (802.006 ms) : 0, 802006
AgentMeter [baseline] (11.483 ms) : 0, 11483
AgentMeter [candidate] (11.626 ms) : 0, 11626
GlobalTracer [baseline] (248.909 ms) : 0, 248909
GlobalTracer [candidate] (249.125 ms) : 0, 249125
IAST [baseline] (25.368 ms) : 0, 25368
IAST [candidate] (25.35 ms) : 0, 25350
AppSec [baseline] (26.705 ms) : 0, 26705
AppSec [candidate] (26.653 ms) : 0, 26653
Debugger [baseline] (65.847 ms) : 0, 65847
Debugger [candidate] (64.525 ms) : 0, 64525
Remote Config [baseline] (523.545 µs) : 0, 524
Remote Config [candidate] (514.763 µs) : 0, 515
Telemetry [baseline] (14.053 ms) : 0, 14053
Telemetry [candidate] (14.512 ms) : 0, 14512
Flare Poller [baseline] (4.713 ms) : 0, 4713
Flare Poller [candidate] (4.841 ms) : 0, 4841
section profiling
crashtracking [baseline] (1.181 ms) : 0, 1181
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (688.141 ms) : 0, 688141
BytebuddyAgent [candidate] (681.91 ms) : 0, 681910
AgentMeter [baseline] (8.737 ms) : 0, 8737
AgentMeter [candidate] (8.626 ms) : 0, 8626
GlobalTracer [baseline] (217.479 ms) : 0, 217479
GlobalTracer [candidate] (215.415 ms) : 0, 215415
AppSec [baseline] (32.289 ms) : 0, 32289
AppSec [candidate] (31.936 ms) : 0, 31936
Debugger [baseline] (63.741 ms) : 0, 63741
Debugger [candidate] (64.352 ms) : 0, 64352
Remote Config [baseline] (582.793 µs) : 0, 583
Remote Config [candidate] (567.451 µs) : 0, 567
Telemetry [baseline] (10.475 ms) : 0, 10475
Telemetry [candidate] (8.938 ms) : 0, 8938
Flare Poller [baseline] (3.515 ms) : 0, 3515
Flare Poller [candidate] (3.505 ms) : 0, 3505
ProfilingAgent [baseline] (94.469 ms) : 0, 94469
ProfilingAgent [candidate] (93.648 ms) : 0, 93648
Profiling [baseline] (95.041 ms) : 0, 95041
Profiling [candidate] (94.197 ms) : 0, 94197
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~b8c6f5627d, baseline=1.61.0-SNAPSHOT~6f142855b8
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1060386
Total [baseline] (8.855 s) : 0, 8855360
Agent [candidate] (1.064 s) : 0, 1063788
Total [candidate] (8.855 s) : 0, 8854968
section iast
Agent [baseline] (1.228 s) : 0, 1228460
Total [baseline] (9.543 s) : 0, 9542928
Agent [candidate] (1.225 s) : 0, 1225006
Total [candidate] (9.596 s) : 0, 9596263
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~b8c6f5627d, baseline=1.61.0-SNAPSHOT~6f142855b8
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.212 ms) : 0, 1212
crashtracking [candidate] (1.202 ms) : 0, 1202
BytebuddyAgent [baseline] (628.906 ms) : 0, 628906
BytebuddyAgent [candidate] (629.231 ms) : 0, 629231
AgentMeter [baseline] (29.101 ms) : 0, 29101
AgentMeter [candidate] (29.273 ms) : 0, 29273
GlobalTracer [baseline] (257.383 ms) : 0, 257383
GlobalTracer [candidate] (258.836 ms) : 0, 258836
AppSec [baseline] (31.431 ms) : 0, 31431
AppSec [candidate] (31.682 ms) : 0, 31682
Debugger [baseline] (58.775 ms) : 0, 58775
Debugger [candidate] (59.147 ms) : 0, 59147
Remote Config [baseline] (612.047 µs) : 0, 612
Remote Config [candidate] (606.377 µs) : 0, 606
Telemetry [baseline] (8.682 ms) : 0, 8682
Telemetry [candidate] (8.761 ms) : 0, 8761
Flare Poller [baseline] (8.11 ms) : 0, 8110
Flare Poller [candidate] (8.901 ms) : 0, 8901
section iast
crashtracking [baseline] (1.228 ms) : 0, 1228
crashtracking [candidate] (1.22 ms) : 0, 1220
BytebuddyAgent [baseline] (797.273 ms) : 0, 797273
BytebuddyAgent [candidate] (794.851 ms) : 0, 794851
AgentMeter [baseline] (11.345 ms) : 0, 11345
AgentMeter [candidate] (11.325 ms) : 0, 11325
GlobalTracer [baseline] (247.82 ms) : 0, 247820
GlobalTracer [candidate] (247.07 ms) : 0, 247070
IAST [baseline] (25.18 ms) : 0, 25180
IAST [candidate] (25.151 ms) : 0, 25151
AppSec [baseline] (26.341 ms) : 0, 26341
AppSec [candidate] (26.362 ms) : 0, 26362
Debugger [baseline] (62.836 ms) : 0, 62836
Debugger [candidate] (62.683 ms) : 0, 62683
Remote Config [baseline] (518.035 µs) : 0, 518
Remote Config [candidate] (514.38 µs) : 0, 514
Telemetry [baseline] (14.859 ms) : 0, 14859
Telemetry [candidate] (14.77 ms) : 0, 14770
Flare Poller [baseline] (4.906 ms) : 0, 4906
Flare Poller [candidate] (4.963 ms) : 0, 4963
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 16 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~b8c6f5627d, baseline=1.61.0-SNAPSHOT~6f142855b8
dateFormat X
axisFormat %s
section baseline
no_agent (1.186 ms) : 1174, 1198
. : milestone, 1186,
iast (3.236 ms) : 3192, 3279
. : milestone, 3236,
iast_FULL (5.769 ms) : 5711, 5827
. : milestone, 5769,
iast_GLOBAL (3.623 ms) : 3561, 3686
. : milestone, 3623,
profiling (2.357 ms) : 2336, 2379
. : milestone, 2357,
tracing (1.812 ms) : 1796, 1827
. : milestone, 1812,
section candidate
no_agent (1.197 ms) : 1185, 1208
. : milestone, 1197,
iast (3.268 ms) : 3224, 3312
. : milestone, 3268,
iast_FULL (5.762 ms) : 5704, 5819
. : milestone, 5762,
iast_GLOBAL (3.628 ms) : 3566, 3690
. : milestone, 3628,
profiling (2.002 ms) : 1985, 2020
. : milestone, 2002,
tracing (1.781 ms) : 1766, 1797
. : milestone, 1781,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~b8c6f5627d, baseline=1.61.0-SNAPSHOT~6f142855b8
dateFormat X
axisFormat %s
section baseline
no_agent (18.888 ms) : 18697, 19078
. : milestone, 18888,
appsec (18.73 ms) : 18542, 18918
. : milestone, 18730,
code_origins (18.015 ms) : 17835, 18195
. : milestone, 18015,
iast (17.782 ms) : 17604, 17960
. : milestone, 17782,
profiling (18.801 ms) : 18612, 18989
. : milestone, 18801,
tracing (17.804 ms) : 17629, 17980
. : milestone, 17804,
section candidate
no_agent (19.07 ms) : 18869, 19270
. : milestone, 19070,
appsec (18.673 ms) : 18485, 18862
. : milestone, 18673,
code_origins (18.767 ms) : 18575, 18960
. : milestone, 18767,
iast (18.602 ms) : 18414, 18790
. : milestone, 18602,
profiling (18.305 ms) : 18122, 18489
. : milestone, 18305,
tracing (18.564 ms) : 18380, 18748
. : milestone, 18564,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~b8c6f5627d, baseline=1.61.0-SNAPSHOT~6f142855b8
dateFormat X
axisFormat %s
section baseline
no_agent (14.893 s) : 14893000, 14893000
. : milestone, 14893000,
appsec (14.956 s) : 14956000, 14956000
. : milestone, 14956000,
iast (17.806 s) : 17806000, 17806000
. : milestone, 17806000,
iast_GLOBAL (17.769 s) : 17769000, 17769000
. : milestone, 17769000,
profiling (15.291 s) : 15291000, 15291000
. : milestone, 15291000,
tracing (14.933 s) : 14933000, 14933000
. : milestone, 14933000,
section candidate
no_agent (15.539 s) : 15539000, 15539000
. : milestone, 15539000,
appsec (14.413 s) : 14413000, 14413000
. : milestone, 14413000,
iast (18.142 s) : 18142000, 18142000
. : milestone, 18142000,
iast_GLOBAL (17.753 s) : 17753000, 17753000
. : milestone, 17753000,
profiling (14.703 s) : 14703000, 14703000
. : milestone, 14703000,
tracing (14.608 s) : 14608000, 14608000
. : milestone, 14608000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~b8c6f5627d, baseline=1.61.0-SNAPSHOT~6f142855b8
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (2.525 ms) : 2469, 2580
. : milestone, 2525,
iast (2.27 ms) : 2199, 2340
. : milestone, 2270,
iast_GLOBAL (2.298 ms) : 2228, 2368
. : milestone, 2298,
profiling (2.094 ms) : 2039, 2150
. : milestone, 2094,
tracing (2.079 ms) : 2024, 2134
. : milestone, 2079,
section candidate
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (3.741 ms) : 3525, 3957
. : milestone, 3741,
iast (2.264 ms) : 2194, 2334
. : milestone, 2264,
iast_GLOBAL (2.304 ms) : 2234, 2374
. : milestone, 2304,
profiling (2.087 ms) : 2032, 2142
. : milestone, 2087,
tracing (2.058 ms) : 2005, 2112
. : milestone, 2058,
|
5 tasks
Contributor
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This PR is opened in favor of #10788, which was closed due to Git tag issues which ran system-tests that were supposed to be disabled for specific tracer versions.
What Does This Do
One major pain-point for developers is that they need to manually enable intake to accept new configurations added to the tracers in order to receive telemetry for these newly added configs. The configuration team would like to automate this process for developers, automatically opening PRs in dd-go to add telemetry normalization in intake when new configurations are added to any of the dd-trace* libraries.
Since each tracer sends telemetry keys in a different format, we need to first standardize what is being sent. The common format among all tracers is environment variables. Thus, this PR updates the normalization of telemetry keys being sent from the current status (lowercase and
_) to using the environment variable version of the configurations.Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.