Prevent retransforming record with type annotation#10824
Open
Prevent retransforming record with type annotation#10824
Conversation
To avoid JVM bug, we detect and prevent retransformation of record with type annotation on record component. see https://bugs.openjdk.org/browse/JDK-8376185
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (308.284 µs) : 285, 331
. : milestone, 308,
basic (277.639 µs) : 269, 287
. : milestone, 278,
loop (8.958 ms) : 8954, 8962
. : milestone, 8958,
section candidate
noprobe (319.746 µs) : 286, 354
. : milestone, 320,
basic (277.499 µs) : 271, 284
. : milestone, 277,
loop (8.958 ms) : 8953, 8963
. : milestone, 8958,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 62 metrics, 5 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~dbe2e3ec68, baseline=1.61.0-SNAPSHOT~1d0b64dbdb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1059112
Total [baseline] (8.794 s) : 0, 8793655
Agent [candidate] (1.06 s) : 0, 1060055
Total [candidate] (8.835 s) : 0, 8834859
section iast
Agent [baseline] (1.225 s) : 0, 1225403
Total [baseline] (9.552 s) : 0, 9551580
Agent [candidate] (1.226 s) : 0, 1226334
Total [candidate] (9.534 s) : 0, 9533707
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~dbe2e3ec68, baseline=1.61.0-SNAPSHOT~1d0b64dbdb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.19 ms) : 0, 1190
crashtracking [candidate] (1.216 ms) : 0, 1216
BytebuddyAgent [baseline] (629.028 ms) : 0, 629028
BytebuddyAgent [candidate] (629.018 ms) : 0, 629018
AgentMeter [baseline] (29.134 ms) : 0, 29134
AgentMeter [candidate] (29.008 ms) : 0, 29008
GlobalTracer [baseline] (256.914 ms) : 0, 256914
GlobalTracer [candidate] (257.292 ms) : 0, 257292
AppSec [baseline] (31.589 ms) : 0, 31589
AppSec [candidate] (31.768 ms) : 0, 31768
Debugger [baseline] (58.79 ms) : 0, 58790
Debugger [candidate] (59.871 ms) : 0, 59871
Remote Config [baseline] (620.58 µs) : 0, 621
Remote Config [candidate] (590.868 µs) : 0, 591
Telemetry [baseline] (8.752 ms) : 0, 8752
Telemetry [candidate] (8.763 ms) : 0, 8763
Flare Poller [baseline] (7.136 ms) : 0, 7136
Flare Poller [candidate] (6.383 ms) : 0, 6383
section iast
crashtracking [baseline] (1.201 ms) : 0, 1201
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (796.296 ms) : 0, 796296
BytebuddyAgent [candidate] (796.033 ms) : 0, 796033
AgentMeter [baseline] (11.314 ms) : 0, 11314
AgentMeter [candidate] (11.306 ms) : 0, 11306
GlobalTracer [baseline] (246.381 ms) : 0, 246381
GlobalTracer [candidate] (247.419 ms) : 0, 247419
IAST [baseline] (25.081 ms) : 0, 25081
IAST [candidate] (25.066 ms) : 0, 25066
AppSec [baseline] (26.323 ms) : 0, 26323
AppSec [candidate] (26.226 ms) : 0, 26226
Debugger [baseline] (62.681 ms) : 0, 62681
Debugger [candidate] (62.916 ms) : 0, 62916
Remote Config [baseline] (507.765 µs) : 0, 508
Remote Config [candidate] (520.344 µs) : 0, 520
Telemetry [baseline] (14.671 ms) : 0, 14671
Telemetry [candidate] (15.837 ms) : 0, 15837
Flare Poller [baseline] (4.871 ms) : 0, 4871
Flare Poller [candidate] (3.832 ms) : 0, 3832
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~dbe2e3ec68, baseline=1.61.0-SNAPSHOT~1d0b64dbdb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.063 s) : 0, 1063309
Total [baseline] (11.101 s) : 0, 11101234
Agent [candidate] (1.073 s) : 0, 1072932
Total [candidate] (11.061 s) : 0, 11061132
section appsec
Agent [baseline] (1.246 s) : 0, 1245593
Total [baseline] (11.113 s) : 0, 11113082
Agent [candidate] (1.248 s) : 0, 1248400
Total [candidate] (11.121 s) : 0, 11121316
section iast
Agent [baseline] (1.226 s) : 0, 1226040
Total [baseline] (11.302 s) : 0, 11301741
Agent [candidate] (1.235 s) : 0, 1234502
Total [candidate] (11.271 s) : 0, 11271116
section profiling
Agent [baseline] (1.179 s) : 0, 1178989
Total [baseline] (10.997 s) : 0, 10996833
Agent [candidate] (1.182 s) : 0, 1181718
Total [candidate] (10.989 s) : 0, 10989036
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~dbe2e3ec68, baseline=1.61.0-SNAPSHOT~1d0b64dbdb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.207 ms) : 0, 1207
BytebuddyAgent [baseline] (630.68 ms) : 0, 630680
BytebuddyAgent [candidate] (636.94 ms) : 0, 636940
AgentMeter [baseline] (29.341 ms) : 0, 29341
AgentMeter [candidate] (29.575 ms) : 0, 29575
GlobalTracer [baseline] (257.65 ms) : 0, 257650
GlobalTracer [candidate] (259.801 ms) : 0, 259801
AppSec [baseline] (31.72 ms) : 0, 31720
AppSec [candidate] (32.175 ms) : 0, 32175
Debugger [baseline] (59.531 ms) : 0, 59531
Debugger [candidate] (61.007 ms) : 0, 61007
Remote Config [baseline] (618.993 µs) : 0, 619
Remote Config [candidate] (590.707 µs) : 0, 591
Telemetry [baseline] (8.629 ms) : 0, 8629
Telemetry [candidate] (8.758 ms) : 0, 8758
Flare Poller [baseline] (7.907 ms) : 0, 7907
Flare Poller [candidate] (6.627 ms) : 0, 6627
section appsec
crashtracking [baseline] (1.203 ms) : 0, 1203
crashtracking [candidate] (1.187 ms) : 0, 1187
BytebuddyAgent [baseline] (657.868 ms) : 0, 657868
BytebuddyAgent [candidate] (658.243 ms) : 0, 658243
AgentMeter [baseline] (12.083 ms) : 0, 12083
AgentMeter [candidate] (12.143 ms) : 0, 12143
GlobalTracer [baseline] (258.171 ms) : 0, 258171
GlobalTracer [candidate] (259.254 ms) : 0, 259254
IAST [baseline] (23.974 ms) : 0, 23974
IAST [candidate] (24.052 ms) : 0, 24052
AppSec [baseline] (177.081 ms) : 0, 177081
AppSec [candidate] (177.671 ms) : 0, 177671
Debugger [baseline] (65.72 ms) : 0, 65720
Debugger [candidate] (66.399 ms) : 0, 66399
Remote Config [baseline] (567.364 µs) : 0, 567
Remote Config [candidate] (569.187 µs) : 0, 569
Telemetry [baseline] (9.029 ms) : 0, 9029
Telemetry [candidate] (9.039 ms) : 0, 9039
Flare Poller [baseline] (3.632 ms) : 0, 3632
Flare Poller [candidate] (3.559 ms) : 0, 3559
section iast
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.207 ms) : 0, 1207
BytebuddyAgent [baseline] (794.662 ms) : 0, 794662
BytebuddyAgent [candidate] (800.984 ms) : 0, 800984
AgentMeter [baseline] (11.321 ms) : 0, 11321
AgentMeter [candidate] (11.609 ms) : 0, 11609
GlobalTracer [baseline] (247.133 ms) : 0, 247133
GlobalTracer [candidate] (248.14 ms) : 0, 248140
IAST [baseline] (25.133 ms) : 0, 25133
IAST [candidate] (25.299 ms) : 0, 25299
AppSec [baseline] (26.417 ms) : 0, 26417
AppSec [candidate] (26.641 ms) : 0, 26641
Debugger [baseline] (63.827 ms) : 0, 63827
Debugger [candidate] (70.197 ms) : 0, 70197
Remote Config [baseline] (511.265 µs) : 0, 511
Remote Config [candidate] (541.589 µs) : 0, 542
Telemetry [baseline] (14.826 ms) : 0, 14826
Telemetry [candidate] (10.34 ms) : 0, 10340
Flare Poller [baseline] (4.882 ms) : 0, 4882
Flare Poller [candidate] (3.426 ms) : 0, 3426
section profiling
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.165 ms) : 0, 1165
BytebuddyAgent [baseline] (681.119 ms) : 0, 681119
BytebuddyAgent [candidate] (681.726 ms) : 0, 681726
AgentMeter [baseline] (8.63 ms) : 0, 8630
AgentMeter [candidate] (8.635 ms) : 0, 8635
GlobalTracer [baseline] (214.986 ms) : 0, 214986
GlobalTracer [candidate] (215.608 ms) : 0, 215608
AppSec [baseline] (31.813 ms) : 0, 31813
AppSec [candidate] (31.94 ms) : 0, 31940
Debugger [baseline] (62.706 ms) : 0, 62706
Debugger [candidate] (65.213 ms) : 0, 65213
Remote Config [baseline] (590.379 µs) : 0, 590
Remote Config [candidate] (575.631 µs) : 0, 576
Telemetry [baseline] (10.459 ms) : 0, 10459
Telemetry [candidate] (9.035 ms) : 0, 9035
Flare Poller [baseline] (3.462 ms) : 0, 3462
Flare Poller [candidate] (3.444 ms) : 0, 3444
ProfilingAgent [baseline] (93.433 ms) : 0, 93433
ProfilingAgent [candidate] (93.795 ms) : 0, 93795
Profiling [baseline] (94.0 ms) : 0, 94000
Profiling [candidate] (94.347 ms) : 0, 94347
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 1 performance regressions! Performance is the same for 16 metrics, 15 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~dbe2e3ec68, baseline=1.61.0-SNAPSHOT~1d0b64dbdb
dateFormat X
axisFormat %s
section baseline
no_agent (19.154 ms) : 18956, 19352
. : milestone, 19154,
appsec (18.649 ms) : 18462, 18837
. : milestone, 18649,
code_origins (17.839 ms) : 17663, 18015
. : milestone, 17839,
iast (18.689 ms) : 18501, 18878
. : milestone, 18689,
profiling (18.781 ms) : 18593, 18968
. : milestone, 18781,
tracing (18.51 ms) : 18326, 18694
. : milestone, 18510,
section candidate
no_agent (17.939 ms) : 17752, 18125
. : milestone, 17939,
appsec (18.438 ms) : 18251, 18625
. : milestone, 18438,
code_origins (18.214 ms) : 18030, 18399
. : milestone, 18214,
iast (17.854 ms) : 17677, 18031
. : milestone, 17854,
profiling (18.748 ms) : 18563, 18934
. : milestone, 18748,
tracing (17.669 ms) : 17496, 17843
. : milestone, 17669,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~dbe2e3ec68, baseline=1.61.0-SNAPSHOT~1d0b64dbdb
dateFormat X
axisFormat %s
section baseline
no_agent (1.258 ms) : 1245, 1271
. : milestone, 1258,
iast (3.295 ms) : 3252, 3338
. : milestone, 3295,
iast_FULL (5.872 ms) : 5814, 5931
. : milestone, 5872,
iast_GLOBAL (3.533 ms) : 3479, 3587
. : milestone, 3533,
profiling (2.029 ms) : 2011, 2047
. : milestone, 2029,
tracing (1.855 ms) : 1838, 1872
. : milestone, 1855,
section candidate
no_agent (1.174 ms) : 1163, 1186
. : milestone, 1174,
iast (3.179 ms) : 3137, 3220
. : milestone, 3179,
iast_FULL (5.84 ms) : 5782, 5898
. : milestone, 5840,
iast_GLOBAL (3.589 ms) : 3533, 3645
. : milestone, 3589,
profiling (2.055 ms) : 2037, 2074
. : milestone, 2055,
tracing (1.816 ms) : 1801, 1831
. : milestone, 1816,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~dbe2e3ec68, baseline=1.61.0-SNAPSHOT~1d0b64dbdb
dateFormat X
axisFormat %s
section baseline
no_agent (15.656 s) : 15656000, 15656000
. : milestone, 15656000,
appsec (14.955 s) : 14955000, 14955000
. : milestone, 14955000,
iast (17.709 s) : 17709000, 17709000
. : milestone, 17709000,
iast_GLOBAL (17.695 s) : 17695000, 17695000
. : milestone, 17695000,
profiling (14.841 s) : 14841000, 14841000
. : milestone, 14841000,
tracing (15.169 s) : 15169000, 15169000
. : milestone, 15169000,
section candidate
no_agent (15.345 s) : 15345000, 15345000
. : milestone, 15345000,
appsec (14.818 s) : 14818000, 14818000
. : milestone, 14818000,
iast (18.061 s) : 18061000, 18061000
. : milestone, 18061000,
iast_GLOBAL (17.626 s) : 17626000, 17626000
. : milestone, 17626000,
profiling (14.914 s) : 14914000, 14914000
. : milestone, 14914000,
tracing (15.174 s) : 15174000, 15174000
. : milestone, 15174000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~dbe2e3ec68, baseline=1.61.0-SNAPSHOT~1d0b64dbdb
dateFormat X
axisFormat %s
section baseline
no_agent (1.47 ms) : 1458, 1482
. : milestone, 1470,
appsec (3.728 ms) : 3509, 3947
. : milestone, 3728,
iast (2.246 ms) : 2177, 2315
. : milestone, 2246,
iast_GLOBAL (2.285 ms) : 2215, 2354
. : milestone, 2285,
profiling (2.099 ms) : 2043, 2156
. : milestone, 2099,
tracing (2.066 ms) : 2013, 2120
. : milestone, 2066,
section candidate
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (3.784 ms) : 3564, 4004
. : milestone, 3784,
iast (2.249 ms) : 2180, 2317
. : milestone, 2249,
iast_GLOBAL (2.285 ms) : 2215, 2354
. : milestone, 2285,
profiling (2.088 ms) : 2031, 2144
. : milestone, 2088,
tracing (2.064 ms) : 2010, 2117
. : milestone, 2064,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
To avoid JVM bug, we detect and prevent retransformation of record with type annotation on record component.
see https://bugs.openjdk.org/browse/JDK-8376185
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [DEBUG-5279]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.