Expose RatelimitedLogger from bootstrap classpath during instrumentation tests#10847
Open
Expose RatelimitedLogger from bootstrap classpath during instrumentation tests#10847
RatelimitedLogger from bootstrap classpath during instrumentation tests#10847Conversation
…asspath during instrumentation tests
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 63 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~283d217e26, baseline=1.61.0-SNAPSHOT~7cff99444b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1060372
Total [baseline] (8.794 s) : 0, 8794384
Agent [candidate] (1.06 s) : 0, 1060446
Total [candidate] (8.811 s) : 0, 8810678
section iast
Agent [baseline] (1.223 s) : 0, 1222536
Total [baseline] (9.557 s) : 0, 9556590
Agent [candidate] (1.235 s) : 0, 1235084
Total [candidate] (9.549 s) : 0, 9549295
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~283d217e26, baseline=1.61.0-SNAPSHOT~7cff99444b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.201 ms) : 0, 1201
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (630.427 ms) : 0, 630427
BytebuddyAgent [candidate] (629.078 ms) : 0, 629078
AgentMeter [baseline] (29.1 ms) : 0, 29100
AgentMeter [candidate] (29.04 ms) : 0, 29040
GlobalTracer [baseline] (257.26 ms) : 0, 257260
GlobalTracer [candidate] (257.077 ms) : 0, 257077
AppSec [baseline] (31.638 ms) : 0, 31638
AppSec [candidate] (31.495 ms) : 0, 31495
Debugger [baseline] (58.906 ms) : 0, 58906
Debugger [candidate] (58.596 ms) : 0, 58596
Remote Config [baseline] (615.62 µs) : 0, 616
Remote Config [candidate] (607.04 µs) : 0, 607
Telemetry [baseline] (8.735 ms) : 0, 8735
Telemetry [candidate] (8.722 ms) : 0, 8722
Flare Poller [baseline] (6.471 ms) : 0, 6471
Flare Poller [candidate] (8.57 ms) : 0, 8570
section iast
crashtracking [baseline] (1.188 ms) : 0, 1188
crashtracking [candidate] (1.202 ms) : 0, 1202
BytebuddyAgent [baseline] (792.575 ms) : 0, 792575
BytebuddyAgent [candidate] (802.512 ms) : 0, 802512
AgentMeter [baseline] (11.29 ms) : 0, 11290
AgentMeter [candidate] (11.613 ms) : 0, 11613
GlobalTracer [baseline] (246.545 ms) : 0, 246545
GlobalTracer [candidate] (248.635 ms) : 0, 248635
AppSec [baseline] (26.356 ms) : 0, 26356
AppSec [candidate] (26.648 ms) : 0, 26648
Debugger [baseline] (63.234 ms) : 0, 63234
Debugger [candidate] (62.718 ms) : 0, 62718
Remote Config [baseline] (530.389 µs) : 0, 530
Remote Config [candidate] (506.932 µs) : 0, 507
Telemetry [baseline] (14.795 ms) : 0, 14795
Telemetry [candidate] (14.792 ms) : 0, 14792
Flare Poller [baseline] (4.932 ms) : 0, 4932
Flare Poller [candidate] (4.86 ms) : 0, 4860
IAST [baseline] (25.161 ms) : 0, 25161
IAST [candidate] (25.405 ms) : 0, 25405
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~283d217e26, baseline=1.61.0-SNAPSHOT~7cff99444b
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1058884
Total [baseline] (11.044 s) : 0, 11043791
Agent [candidate] (1.058 s) : 0, 1057840
Total [candidate] (11.024 s) : 0, 11024400
section appsec
Agent [baseline] (1.245 s) : 0, 1245167
Total [baseline] (11.159 s) : 0, 11159157
Agent [candidate] (1.242 s) : 0, 1242457
Total [candidate] (11.215 s) : 0, 11214804
section iast
Agent [baseline] (1.227 s) : 0, 1226538
Total [baseline] (11.283 s) : 0, 11282759
Agent [candidate] (1.228 s) : 0, 1227630
Total [candidate] (11.292 s) : 0, 11291911
section profiling
Agent [baseline] (1.179 s) : 0, 1179169
Total [baseline] (10.994 s) : 0, 10994008
Agent [candidate] (1.179 s) : 0, 1179427
Total [candidate] (10.922 s) : 0, 10921605
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~283d217e26, baseline=1.61.0-SNAPSHOT~7cff99444b
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (627.264 ms) : 0, 627264
BytebuddyAgent [candidate] (627.245 ms) : 0, 627245
AgentMeter [baseline] (29.064 ms) : 0, 29064
AgentMeter [candidate] (28.984 ms) : 0, 28984
GlobalTracer [baseline] (256.717 ms) : 0, 256717
GlobalTracer [candidate] (256.512 ms) : 0, 256512
AppSec [baseline] (31.468 ms) : 0, 31468
AppSec [candidate] (31.466 ms) : 0, 31466
Debugger [baseline] (59.306 ms) : 0, 59306
Debugger [candidate] (59.237 ms) : 0, 59237
Remote Config [baseline] (618.249 µs) : 0, 618
Remote Config [candidate] (616.873 µs) : 0, 617
Telemetry [baseline] (8.592 ms) : 0, 8592
Telemetry [candidate] (8.635 ms) : 0, 8635
Flare Poller [baseline] (8.714 ms) : 0, 8714
Flare Poller [candidate] (7.959 ms) : 0, 7959
section appsec
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (657.573 ms) : 0, 657573
BytebuddyAgent [candidate] (655.573 ms) : 0, 655573
AgentMeter [baseline] (12.107 ms) : 0, 12107
AgentMeter [candidate] (12.052 ms) : 0, 12052
GlobalTracer [baseline] (257.916 ms) : 0, 257916
GlobalTracer [candidate] (257.358 ms) : 0, 257358
IAST [baseline] (23.953 ms) : 0, 23953
IAST [candidate] (23.96 ms) : 0, 23960
AppSec [baseline] (177.125 ms) : 0, 177125
AppSec [candidate] (177.334 ms) : 0, 177334
Debugger [baseline] (65.928 ms) : 0, 65928
Debugger [candidate] (65.619 ms) : 0, 65619
Remote Config [baseline] (568.85 µs) : 0, 569
Remote Config [candidate] (579.364 µs) : 0, 579
Telemetry [baseline] (8.942 ms) : 0, 8942
Telemetry [candidate] (8.998 ms) : 0, 8998
Flare Poller [baseline] (3.648 ms) : 0, 3648
Flare Poller [candidate] (3.668 ms) : 0, 3668
section iast
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.194 ms) : 0, 1194
BytebuddyAgent [baseline] (795.925 ms) : 0, 795925
BytebuddyAgent [candidate] (796.914 ms) : 0, 796914
AgentMeter [baseline] (11.346 ms) : 0, 11346
AgentMeter [candidate] (11.324 ms) : 0, 11324
GlobalTracer [baseline] (247.395 ms) : 0, 247395
GlobalTracer [candidate] (247.486 ms) : 0, 247486
IAST [baseline] (25.083 ms) : 0, 25083
IAST [candidate] (25.161 ms) : 0, 25161
AppSec [baseline] (27.188 ms) : 0, 27188
AppSec [candidate] (26.358 ms) : 0, 26358
Debugger [baseline] (64.944 ms) : 0, 64944
Debugger [candidate] (63.672 ms) : 0, 63672
Remote Config [baseline] (519.76 µs) : 0, 520
Remote Config [candidate] (510.952 µs) : 0, 511
Telemetry [baseline] (12.737 ms) : 0, 12737
Telemetry [candidate] (14.284 ms) : 0, 14284
Flare Poller [baseline] (4.257 ms) : 0, 4257
Flare Poller [candidate] (4.683 ms) : 0, 4683
section profiling
crashtracking [baseline] (1.171 ms) : 0, 1171
crashtracking [candidate] (1.165 ms) : 0, 1165
BytebuddyAgent [baseline] (680.793 ms) : 0, 680793
BytebuddyAgent [candidate] (681.04 ms) : 0, 681040
AgentMeter [baseline] (8.589 ms) : 0, 8589
AgentMeter [candidate] (8.613 ms) : 0, 8613
GlobalTracer [baseline] (214.993 ms) : 0, 214993
GlobalTracer [candidate] (215.083 ms) : 0, 215083
AppSec [baseline] (31.882 ms) : 0, 31882
AppSec [candidate] (31.892 ms) : 0, 31892
Debugger [baseline] (64.495 ms) : 0, 64495
Debugger [candidate] (64.465 ms) : 0, 64465
Remote Config [baseline] (583.929 µs) : 0, 584
Remote Config [candidate] (586.207 µs) : 0, 586
Telemetry [baseline] (8.15 ms) : 0, 8150
Telemetry [candidate] (8.949 ms) : 0, 8949
Flare Poller [baseline] (4.279 ms) : 0, 4279
Flare Poller [candidate] (3.493 ms) : 0, 3493
ProfilingAgent [baseline] (93.636 ms) : 0, 93636
ProfilingAgent [candidate] (93.593 ms) : 0, 93593
Profiling [baseline] (94.191 ms) : 0, 94191
Profiling [candidate] (94.155 ms) : 0, 94155
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 2 performance regressions! Performance is the same for 15 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~283d217e26, baseline=1.61.0-SNAPSHOT~7cff99444b
dateFormat X
axisFormat %s
section baseline
no_agent (18.184 ms) : 17996, 18372
. : milestone, 18184,
appsec (18.372 ms) : 18185, 18560
. : milestone, 18372,
code_origins (18.171 ms) : 17990, 18352
. : milestone, 18171,
iast (17.741 ms) : 17565, 17917
. : milestone, 17741,
profiling (20.539 ms) : 20329, 20748
. : milestone, 20539,
tracing (17.787 ms) : 17613, 17961
. : milestone, 17787,
section candidate
no_agent (17.065 ms) : 16899, 17230
. : milestone, 17065,
appsec (18.366 ms) : 18182, 18550
. : milestone, 18366,
code_origins (17.685 ms) : 17507, 17863
. : milestone, 17685,
iast (17.751 ms) : 17577, 17925
. : milestone, 17751,
profiling (19.565 ms) : 19365, 19764
. : milestone, 19565,
tracing (18.529 ms) : 18344, 18714
. : milestone, 18529,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~283d217e26, baseline=1.61.0-SNAPSHOT~7cff99444b
dateFormat X
axisFormat %s
section baseline
no_agent (1.193 ms) : 1181, 1205
. : milestone, 1193,
iast (3.16 ms) : 3118, 3201
. : milestone, 3160,
iast_FULL (6.036 ms) : 5973, 6099
. : milestone, 6036,
iast_GLOBAL (3.42 ms) : 3369, 3471
. : milestone, 3420,
profiling (2.109 ms) : 2088, 2130
. : milestone, 2109,
tracing (1.764 ms) : 1750, 1779
. : milestone, 1764,
section candidate
no_agent (1.195 ms) : 1183, 1206
. : milestone, 1195,
iast (3.228 ms) : 3178, 3277
. : milestone, 3228,
iast_FULL (6.062 ms) : 6001, 6122
. : milestone, 6062,
iast_GLOBAL (3.722 ms) : 3657, 3787
. : milestone, 3722,
profiling (2.074 ms) : 2055, 2093
. : milestone, 2074,
tracing (1.797 ms) : 1782, 1812
. : milestone, 1797,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~283d217e26, baseline=1.61.0-SNAPSHOT~7cff99444b
dateFormat X
axisFormat %s
section baseline
no_agent (15.582 s) : 15582000, 15582000
. : milestone, 15582000,
appsec (15.063 s) : 15063000, 15063000
. : milestone, 15063000,
iast (17.89 s) : 17890000, 17890000
. : milestone, 17890000,
iast_GLOBAL (17.905 s) : 17905000, 17905000
. : milestone, 17905000,
profiling (15.02 s) : 15020000, 15020000
. : milestone, 15020000,
tracing (15.461 s) : 15461000, 15461000
. : milestone, 15461000,
section candidate
no_agent (15.509 s) : 15509000, 15509000
. : milestone, 15509000,
appsec (15.097 s) : 15097000, 15097000
. : milestone, 15097000,
iast (18.245 s) : 18245000, 18245000
. : milestone, 18245000,
iast_GLOBAL (17.768 s) : 17768000, 17768000
. : milestone, 17768000,
profiling (15.558 s) : 15558000, 15558000
. : milestone, 15558000,
tracing (15.092 s) : 15092000, 15092000
. : milestone, 15092000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~283d217e26, baseline=1.61.0-SNAPSHOT~7cff99444b
dateFormat X
axisFormat %s
section baseline
no_agent (1.469 ms) : 1458, 1481
. : milestone, 1469,
appsec (3.795 ms) : 3573, 4016
. : milestone, 3795,
iast (2.248 ms) : 2179, 2317
. : milestone, 2248,
iast_GLOBAL (2.296 ms) : 2227, 2366
. : milestone, 2296,
profiling (2.098 ms) : 2042, 2154
. : milestone, 2098,
tracing (2.075 ms) : 2021, 2129
. : milestone, 2075,
section candidate
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (3.776 ms) : 3555, 3997
. : milestone, 3776,
iast (2.252 ms) : 2183, 2321
. : milestone, 2252,
iast_GLOBAL (2.287 ms) : 2218, 2356
. : milestone, 2287,
profiling (2.493 ms) : 2321, 2664
. : milestone, 2493,
tracing (2.056 ms) : 2003, 2110
. : milestone, 2056,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Expose
datadog.trace.relocate.api.RatelimitedLoggerfrom bootstrap classpath during instrumentation testsMotivation
Needed to test instrumentation helper classes on the boostrap classpath that use
RatelimitedLogger.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.