Move SimpleUtf8Cache and GenerationalUtf8Cache to the communication module#10925
Open
Move SimpleUtf8Cache and GenerationalUtf8Cache to the communication module#10925
SimpleUtf8Cache and GenerationalUtf8Cache to the communication module#10925Conversation
…for OTLP encoding
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~29877c4bc5, baseline=1.61.0-SNAPSHOT~c00f676bb9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.07 s) : 0, 1069851
Total [baseline] (11.111 s) : 0, 11111046
Agent [candidate] (1.054 s) : 0, 1053920
Total [candidate] (11.074 s) : 0, 11074358
section appsec
Agent [baseline] (1.243 s) : 0, 1243221
Total [baseline] (11.136 s) : 0, 11135706
Agent [candidate] (1.249 s) : 0, 1248563
Total [candidate] (11.258 s) : 0, 11258460
section iast
Agent [baseline] (1.226 s) : 0, 1225874
Total [baseline] (11.298 s) : 0, 11297645
Agent [candidate] (1.225 s) : 0, 1225269
Total [candidate] (11.336 s) : 0, 11335853
section profiling
Agent [baseline] (1.182 s) : 0, 1181560
Total [baseline] (10.959 s) : 0, 10958593
Agent [candidate] (1.183 s) : 0, 1182697
Total [candidate] (11.138 s) : 0, 11137966
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~29877c4bc5, baseline=1.61.0-SNAPSHOT~c00f676bb9
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.227 ms) : 0, 1227
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (636.535 ms) : 0, 636535
BytebuddyAgent [candidate] (627.807 ms) : 0, 627807
AgentMeter [baseline] (29.784 ms) : 0, 29784
AgentMeter [candidate] (29.242 ms) : 0, 29242
GlobalTracer [baseline] (259.641 ms) : 0, 259641
GlobalTracer [candidate] (256.05 ms) : 0, 256050
AppSec [baseline] (32.19 ms) : 0, 32190
AppSec [candidate] (31.541 ms) : 0, 31541
Debugger [baseline] (61.12 ms) : 0, 61120
Debugger [candidate] (60.135 ms) : 0, 60135
Remote Config [baseline] (597.097 µs) : 0, 597
Remote Config [candidate] (583.216 µs) : 0, 583
Telemetry [baseline] (8.131 ms) : 0, 8131
Telemetry [candidate] (7.952 ms) : 0, 7952
Flare Poller [baseline] (4.339 ms) : 0, 4339
Flare Poller [candidate] (3.538 ms) : 0, 3538
section appsec
crashtracking [baseline] (1.197 ms) : 0, 1197
crashtracking [candidate] (1.204 ms) : 0, 1204
BytebuddyAgent [baseline] (655.964 ms) : 0, 655964
BytebuddyAgent [candidate] (660.235 ms) : 0, 660235
AgentMeter [baseline] (12.086 ms) : 0, 12086
AgentMeter [candidate] (12.072 ms) : 0, 12072
GlobalTracer [baseline] (257.638 ms) : 0, 257638
GlobalTracer [candidate] (258.23 ms) : 0, 258230
IAST [baseline] (24.076 ms) : 0, 24076
IAST [candidate] (24.174 ms) : 0, 24174
AppSec [baseline] (177.441 ms) : 0, 177441
AppSec [candidate] (177.533 ms) : 0, 177533
Debugger [baseline] (65.991 ms) : 0, 65991
Debugger [candidate] (66.153 ms) : 0, 66153
Remote Config [baseline] (642.113 µs) : 0, 642
Remote Config [candidate] (628.022 µs) : 0, 628
Telemetry [baseline] (8.382 ms) : 0, 8382
Telemetry [candidate] (8.314 ms) : 0, 8314
Flare Poller [baseline] (3.626 ms) : 0, 3626
Flare Poller [candidate] (3.629 ms) : 0, 3629
section iast
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (794.943 ms) : 0, 794943
BytebuddyAgent [candidate] (794.871 ms) : 0, 794871
AgentMeter [baseline] (11.381 ms) : 0, 11381
AgentMeter [candidate] (11.362 ms) : 0, 11362
GlobalTracer [baseline] (247.02 ms) : 0, 247020
GlobalTracer [candidate] (246.887 ms) : 0, 246887
IAST [baseline] (25.277 ms) : 0, 25277
IAST [candidate] (25.256 ms) : 0, 25256
AppSec [baseline] (26.412 ms) : 0, 26412
AppSec [candidate] (26.41 ms) : 0, 26410
Debugger [baseline] (70.6 ms) : 0, 70600
Debugger [candidate] (69.598 ms) : 0, 69598
Remote Config [baseline] (527.873 µs) : 0, 528
Remote Config [candidate] (522.364 µs) : 0, 522
Telemetry [baseline] (9.147 ms) : 0, 9147
Telemetry [candidate] (9.604 ms) : 0, 9604
Flare Poller [baseline] (3.305 ms) : 0, 3305
Flare Poller [candidate] (3.55 ms) : 0, 3550
section profiling
crashtracking [baseline] (1.167 ms) : 0, 1167
crashtracking [candidate] (1.176 ms) : 0, 1176
BytebuddyAgent [baseline] (681.662 ms) : 0, 681662
BytebuddyAgent [candidate] (681.413 ms) : 0, 681413
AgentMeter [baseline] (9.003 ms) : 0, 9003
AgentMeter [candidate] (8.982 ms) : 0, 8982
GlobalTracer [baseline] (215.134 ms) : 0, 215134
GlobalTracer [candidate] (215.753 ms) : 0, 215753
AppSec [baseline] (31.973 ms) : 0, 31973
AppSec [candidate] (32.155 ms) : 0, 32155
Debugger [baseline] (66.012 ms) : 0, 66012
Debugger [candidate] (65.285 ms) : 0, 65285
Remote Config [baseline] (556.008 µs) : 0, 556
Remote Config [candidate] (565.015 µs) : 0, 565
Telemetry [baseline] (7.63 ms) : 0, 7630
Telemetry [candidate] (8.543 ms) : 0, 8543
Flare Poller [baseline] (3.409 ms) : 0, 3409
Flare Poller [candidate] (3.494 ms) : 0, 3494
ProfilingAgent [baseline] (94.158 ms) : 0, 94158
ProfilingAgent [candidate] (94.489 ms) : 0, 94489
Profiling [baseline] (94.724 ms) : 0, 94724
Profiling [candidate] (95.058 ms) : 0, 95058
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~29877c4bc5, baseline=1.61.0-SNAPSHOT~c00f676bb9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1054748
Total [baseline] (8.872 s) : 0, 8872126
Agent [candidate] (1.055 s) : 0, 1054998
Total [candidate] (8.873 s) : 0, 8872936
section iast
Agent [baseline] (1.232 s) : 0, 1231950
Total [baseline] (9.58 s) : 0, 9579596
Agent [candidate] (1.227 s) : 0, 1227365
Total [candidate] (9.552 s) : 0, 9551597
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~29877c4bc5, baseline=1.61.0-SNAPSHOT~c00f676bb9
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (627.741 ms) : 0, 627741
BytebuddyAgent [candidate] (627.018 ms) : 0, 627018
AgentMeter [baseline] (29.352 ms) : 0, 29352
AgentMeter [candidate] (29.363 ms) : 0, 29363
GlobalTracer [baseline] (256.323 ms) : 0, 256323
GlobalTracer [candidate] (256.519 ms) : 0, 256519
AppSec [baseline] (31.723 ms) : 0, 31723
AppSec [candidate] (31.661 ms) : 0, 31661
Debugger [baseline] (59.614 ms) : 0, 59614
Debugger [candidate] (59.614 ms) : 0, 59614
Remote Config [baseline] (587.757 µs) : 0, 588
Remote Config [candidate] (586.899 µs) : 0, 587
Telemetry [baseline] (7.983 ms) : 0, 7983
Telemetry [candidate] (8.789 ms) : 0, 8789
Flare Poller [baseline] (4.215 ms) : 0, 4215
Flare Poller [candidate] (4.284 ms) : 0, 4284
section iast
crashtracking [baseline] (1.205 ms) : 0, 1205
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (800.019 ms) : 0, 800019
BytebuddyAgent [candidate] (796.191 ms) : 0, 796191
AgentMeter [baseline] (11.589 ms) : 0, 11589
AgentMeter [candidate] (11.412 ms) : 0, 11412
GlobalTracer [baseline] (247.777 ms) : 0, 247777
GlobalTracer [candidate] (247.573 ms) : 0, 247573
AppSec [baseline] (27.329 ms) : 0, 27329
AppSec [candidate] (26.448 ms) : 0, 26448
Debugger [baseline] (67.139 ms) : 0, 67139
Debugger [candidate] (66.04 ms) : 0, 66040
Remote Config [baseline] (532.321 µs) : 0, 532
Remote Config [candidate] (521.442 µs) : 0, 521
Telemetry [baseline] (10.867 ms) : 0, 10867
Telemetry [candidate] (12.241 ms) : 0, 12241
Flare Poller [baseline] (3.793 ms) : 0, 3793
Flare Poller [candidate] (4.259 ms) : 0, 4259
IAST [baseline] (25.539 ms) : 0, 25539
IAST [candidate] (25.335 ms) : 0, 25335
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 1 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~29877c4bc5, baseline=1.61.0-SNAPSHOT~c00f676bb9
dateFormat X
axisFormat %s
section baseline
no_agent (19.086 ms) : 18892, 19280
. : milestone, 19086,
appsec (19.58 ms) : 19381, 19780
. : milestone, 19580,
code_origins (18.002 ms) : 17824, 18179
. : milestone, 18002,
iast (18.582 ms) : 18398, 18765
. : milestone, 18582,
profiling (18.416 ms) : 18229, 18603
. : milestone, 18416,
tracing (17.886 ms) : 17709, 18062
. : milestone, 17886,
section candidate
no_agent (19.132 ms) : 18933, 19332
. : milestone, 19132,
appsec (18.686 ms) : 18498, 18873
. : milestone, 18686,
code_origins (18.787 ms) : 18600, 18974
. : milestone, 18787,
iast (18.585 ms) : 18399, 18771
. : milestone, 18585,
profiling (18.717 ms) : 18525, 18908
. : milestone, 18717,
tracing (17.735 ms) : 17563, 17908
. : milestone, 17735,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~29877c4bc5, baseline=1.61.0-SNAPSHOT~c00f676bb9
dateFormat X
axisFormat %s
section baseline
no_agent (1.216 ms) : 1203, 1228
. : milestone, 1216,
iast (3.353 ms) : 3309, 3397
. : milestone, 3353,
iast_FULL (5.966 ms) : 5905, 6026
. : milestone, 5966,
iast_GLOBAL (3.732 ms) : 3668, 3797
. : milestone, 3732,
profiling (2.312 ms) : 2291, 2333
. : milestone, 2312,
tracing (1.761 ms) : 1747, 1775
. : milestone, 1761,
section candidate
no_agent (1.177 ms) : 1166, 1188
. : milestone, 1177,
iast (3.289 ms) : 3245, 3334
. : milestone, 3289,
iast_FULL (5.986 ms) : 5925, 6046
. : milestone, 5986,
iast_GLOBAL (3.566 ms) : 3512, 3620
. : milestone, 3566,
profiling (2.036 ms) : 2018, 2054
. : milestone, 2036,
tracing (1.772 ms) : 1757, 1787
. : milestone, 1772,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~29877c4bc5, baseline=1.61.0-SNAPSHOT~c00f676bb9
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (3.819 ms) : 3600, 4039
. : milestone, 3819,
iast (2.266 ms) : 2196, 2336
. : milestone, 2266,
iast_GLOBAL (2.302 ms) : 2232, 2373
. : milestone, 2302,
profiling (2.096 ms) : 2039, 2153
. : milestone, 2096,
tracing (2.073 ms) : 2019, 2127
. : milestone, 2073,
section candidate
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (3.8 ms) : 3579, 4021
. : milestone, 3800,
iast (2.258 ms) : 2188, 2327
. : milestone, 2258,
iast_GLOBAL (2.303 ms) : 2233, 2372
. : milestone, 2303,
profiling (2.105 ms) : 2048, 2162
. : milestone, 2105,
tracing (2.082 ms) : 2027, 2137
. : milestone, 2082,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~29877c4bc5, baseline=1.61.0-SNAPSHOT~c00f676bb9
dateFormat X
axisFormat %s
section baseline
no_agent (14.977 s) : 14977000, 14977000
. : milestone, 14977000,
appsec (14.789 s) : 14789000, 14789000
. : milestone, 14789000,
iast (18.456 s) : 18456000, 18456000
. : milestone, 18456000,
iast_GLOBAL (17.686 s) : 17686000, 17686000
. : milestone, 17686000,
profiling (15.413 s) : 15413000, 15413000
. : milestone, 15413000,
tracing (14.659 s) : 14659000, 14659000
. : milestone, 14659000,
section candidate
no_agent (15.505 s) : 15505000, 15505000
. : milestone, 15505000,
appsec (14.629 s) : 14629000, 14629000
. : milestone, 14629000,
iast (18.318 s) : 18318000, 18318000
. : milestone, 18318000,
iast_GLOBAL (17.883 s) : 17883000, 17883000
. : milestone, 17883000,
profiling (14.665 s) : 14665000, 14665000
. : milestone, 14665000,
tracing (14.994 s) : 14994000, 14994000
. : milestone, 14994000,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Move
SimpleUtf8CacheandGenerationalUtf8Cacheto thecommunicationmodule so they can be reused for OTLP encoding.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.