Skip to content

chore(ci): add final_status property on junit XML [APMSP-2610]#3693

Merged
cbeauchesne merged 6 commits intomasterfrom
cbeauchesne/final_status
Mar 13, 2026
Merged

chore(ci): add final_status property on junit XML [APMSP-2610]#3693
cbeauchesne merged 6 commits intomasterfrom
cbeauchesne/final_status

Conversation

@cbeauchesne
Copy link
Collaborator

@cbeauchesne cbeauchesne commented Mar 6, 2026

What does this PR do?

Add a <property name="dd_tags[test.final_status]" value="pass" /> on every test case reported through junit

Motivation

Some repositories intentionally use mechanisms that ignore test failures (there are valid reasons to still execute those tests behind the scenes).

In these cases, the reported test status cannot be relied upon by Test Optimization to monitor repository health or trigger team notifications.

To ensure a consistent and unified approach, we will instead use final_status — the property specifically designed and used by the Test Optimization integration for this purpose.

Important note

I'm using the not-that-ideal XSLT here as this change, because it must be done over 17+ repos, and it's a workaround until this gets integrated into a better place, such as datadog-ci or the backend.

We're trying to work with the team on this, please have a look on this RFC for more context.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.40%. Comparing base (b33ea57) to head (de3f3b3).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3693      +/-   ##
==========================================
- Coverage   62.44%   62.40%   -0.04%     
==========================================
  Files         142      142              
  Lines       13586    13586              
  Branches     1775     1775              
==========================================
- Hits         8484     8479       -5     
- Misses       4296     4301       +5     
  Partials      806      806              

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b33ea57...de3f3b3. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1-2
Copy link

datadog-datadog-prod-us1-2 bot commented Mar 9, 2026

⚠️ Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 1028 Tests failed

testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integration\PHPInstallerTest::testSearchPhpBinaries
Test code or tested code printed unexpected output: Searching for available php binaries, this operation might take a while.

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106
testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 69b2f93400000000c9dbe73f900d9e55
tid: 69b2f93400000000
hexProcessTraceId: c9dbe73f900d9e55
hexProcessSpanId: c131fbf2cd17742f
processTraceId: 14545473681708916309
processSpanId: 13921184943420437551

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106
testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 69b2f94d000000008481bedf5dd16de5
tid: 69b2f94d00000000
hexProcessTraceId: 8481bedf5dd16de5
hexProcessSpanId: 97a8c7304c841ad4
processTraceId: 9548122551563152869
processSpanId: 10928203506070592212
View all

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: de3f3b3 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@cbeauchesne cbeauchesne marked this pull request as ready for review March 12, 2026 17:16
@cbeauchesne cbeauchesne requested a review from a team as a code owner March 12, 2026 17:16
@cbeauchesne cbeauchesne force-pushed the cbeauchesne/final_status branch from 0ccec9a to de3f3b3 Compare March 12, 2026 17:17
@cbeauchesne cbeauchesne merged commit 147f3c2 into master Mar 13, 2026
2063 checks passed
@cbeauchesne cbeauchesne deleted the cbeauchesne/final_status branch March 13, 2026 09:22
@github-actions github-actions bot added this to the 1.17.0 milestone Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants