Leiyks/set ddtrace retry interval#3977
Conversation
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b25f3440b0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
|
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Benchmarks [ tracer ]Benchmark execution time: 2026-06-12 13:45:57 Comparing candidate commit 1de4e30 in PR branch Found 2 performance improvements and 0 performance regressions! Performance is the same for 192 metrics, 0 unstable metrics.
|
Run the .phpt suite with a 1ms sidecar trace-send retry interval so doomed sends to unreachable agent endpoints (the bulk of the suite defaults to localhost:8126 with no listener) clear their retries near-instantly instead of clogging the shared sidecar flusher under -j4, which caused the flaky client_side_stats Kind(TimedOut) / wait-for-replay-timeout failures.
4d140ff to
912125b
Compare
Setting DD_TRACE_RETRY_INTERVAL=1 in RUN_TESTS_CMD makes it a non-default env-var config, so it now appears (origin=env_var) in config.phpt's reported configuration list. Add the entry and renumber the subsequent indices.
912125b to
1de4e30
Compare
Signed-off-by: Alexandre Rulleau alexandre.rulleau@datadoghq.com### Description
Reviewer checklist