Skip to content

Leiyks/set ddtrace retry interval#3977

Open
Leiyks wants to merge 9 commits into
masterfrom
leiyks/set-ddtrace-retry-interval
Open

Leiyks/set ddtrace retry interval#3977
Leiyks wants to merge 9 commits into
masterfrom
leiyks/set-ddtrace-retry-interval

Conversation

@Leiyks

@Leiyks Leiyks commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Signed-off-by: Alexandre Rulleau alexandre.rulleau@datadoghq.com### Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

Leiyks added 3 commits June 11, 2026 17:08
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
@Leiyks Leiyks requested review from a team as code owners June 11, 2026 16:04
@Leiyks Leiyks requested review from dd-oleksii and greghuels and removed request for a team June 11, 2026 16:04

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b25f3440b0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread components-rs/sidecar.h
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Jun 11, 2026

Copy link
Copy Markdown

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 20 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-php | test_integrations_swoole_5: [8.4]   View in Datadog   GitLab

DataDog/apm-reliability/dd-trace-php | test_extension_ci: [7.0]   View in Datadog   GitLab

DataDog/apm-reliability/dd-trace-php | test_extension_ci: [7.1]   View in Datadog   GitLab

View all 20 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 54.09% (+0.01%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1de4e30 | Docs | Datadog PR Page | Give us feedback!

Leiyks and others added 2 commits June 11, 2026 18:20
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
…set-ddtrace-retry-interval

* 'master' of github.com:DataDog/dd-trace-php:
  libdatadog update to 6760faae (#3944)
  feat(profiling): add heap-live profiling for memory leak detection (#3623)
  chore: add kube pod annotation to debug request-replayer (#3978)
@gh-worker-ownership-write-b05516 gh-worker-ownership-write-b05516 Bot removed the request for review from a team June 12, 2026 09:40
@pr-commenter

pr-commenter Bot commented Jun 12, 2026

Copy link
Copy Markdown

Benchmarks [ tracer ]

Benchmark execution time: 2026-06-12 13:45:57

Comparing candidate commit 1de4e30 in PR branch leiyks/set-ddtrace-retry-interval with baseline commit 46641ee in branch master.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 192 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:MessagePackSerializationBench/benchMessagePackSerialization

  • 🟩 execution_time [-6.407µs; -5.493µs] or [-5.770%; -4.947%]

scenario:MessagePackSerializationBench/benchMessagePackSerialization-opcache

  • 🟩 execution_time [-6.509µs; -4.951µs] or [-5.789%; -4.403%]

Run the .phpt suite with a 1ms sidecar trace-send retry interval so doomed sends to
unreachable agent endpoints (the bulk of the suite defaults to localhost:8126 with no
listener) clear their retries near-instantly instead of clogging the shared sidecar
flusher under -j4, which caused the flaky client_side_stats Kind(TimedOut) /
wait-for-replay-timeout failures.
@Leiyks Leiyks force-pushed the leiyks/set-ddtrace-retry-interval branch 2 times, most recently from 4d140ff to 912125b Compare June 12, 2026 12:26
Setting DD_TRACE_RETRY_INTERVAL=1 in RUN_TESTS_CMD makes it a non-default env-var
config, so it now appears (origin=env_var) in config.phpt's reported configuration
list. Add the entry and renumber the subsequent indices.
@Leiyks Leiyks force-pushed the leiyks/set-ddtrace-retry-interval branch from 912125b to 1de4e30 Compare June 12, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants