build(deps): bump tests/FeatureFlags/ffe-system-test-data from 4446371 to 57e98f5#3979
Conversation
Bumps [tests/FeatureFlags/ffe-system-test-data](https://github.com/DataDog/ffe-system-test-data) from `4446371` to `57e98f5`. - [Commits](DataDog/ffe-system-test-data@4446371...57e98f5) --- updated-dependencies: - dependency-name: tests/FeatureFlags/ffe-system-test-data dependency-version: 57e98f5db60b4370699c2618ed74b272e496a227 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
dependabot
Bot
requested review from
dd-oleksii and
leoromanovsky
and removed request for
a team
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 47f6cc46d2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -1 +1 @@ | |||
| Subproject commit 4446371bc1ca52bd526356927ef42d380145b118 | |||
| Subproject commit 57e98f5db60b4370699c2618ed74b272e496a227 | |||
There was a problem hiding this comment.
This submodule version changes the missing-flag fixtures to expect result.reason = ERROR and errorCode = FLAG_NOT_FOUND, but tests/ext/ffe/system_test_data_evaluate.phpt only validates result.value and never compares reason or errorCode. In an implementation that still reports DEFAULT for missing flags, these newly imported canonical cases pass as long as the fallback value is returned, so the bump does not enforce the upstream regression it brings in. Please extend the fixture runner to compare reason/errorCode when those fields are present.
Useful? React with 👍 / 👎.
|
Bumps tests/FeatureFlags/ffe-system-test-data from
4446371to57e98f5.Commits
57e98f5Merge pull request #14 from DataDog/leo.romanovsky/add-regex-evaluation-cases6db17e8Add regex evaluation edge cases1db25ecMerge pull request #11 from DataDog/leo.romanovsky/ffe-malformed-config-cases5c5578dDocument FFE config tolerance fixtures106db8aAdd FFE config tolerance fixture casesb42c4a1Merge pull request #10 from DataDog/leo.romanovsky/missing-flag-error-fixturea8e8984fix: report missing flags as flag not foundDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)