-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Enhance documentation for advanced experiment runs #35320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
dafdfb8
Enhance documentation for advanced experiment runs
CFLJacquet 8f5f4d5
Update content/en/llm_observability/experiments/advanced_runs.md
CFLJacquet d837ce5
Update content/en/llm_observability/experiments/advanced_runs.md
CFLJacquet 632ba7d
Apply suggestion from @iadjivon
CFLJacquet 355a8ac
Update experiment instructions in advanced_runs.md
CFLJacquet 5af0326
Apply suggestions from code review
iadjivon 5c73651
Merge branch 'master' into CFLJacquet/dataset_subset
CFLJacquet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new subset example passes
tags=[...]toLLMObs.pull_dataset, but the Experiments docs currently define dataset records in terms ofmetadataand documentpull_datasetwithdataset_nameplus optionalproject_name/versiononly (seecontent/en/llm_observability/experiments/datasets.md). In that context, users following this snippet can hit an unexpected-keyword error and fail to run the workflow; please either switch to the supported filter path or add/version-gate the new parameter where the API contract is documented.Useful? React with 👍 / 👎.