[DOCS-13462] Add generic amazon s3 doc#35354
[DOCS-13462] Add generic amazon s3 doc#35354maycmlee wants to merge 6 commits intomay/amazon-s3-dd-archives-genericfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3460634159
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| | None | 100,000,000 | 900 | | ||
|
|
||
| [1]: /logs/log_configuration/rehydrating/ | ||
| [2]: /observability_pipelines/sources/datadog_archives/ |
There was a problem hiding this comment.
The new Amazon S3 destination page defines reference [2] as /observability_pipelines/sources/datadog_archives/, but there is no corresponding source page or alias in the repo, so the “Datadog Archives” link in the Overview resolves to a dead URL. The Datadog Archives docs live under the destinations route (for example, /observability_pipelines/destinations/datadog_archives/), so this should be updated to avoid sending readers to a 404.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2acccb0885
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| ## Set up an Amazon S3 bucket | ||
|
|
||
| {{% observability_pipelines/configure_log_archive/amazon_s3/instructions %}} |
There was a problem hiding this comment.
This page pulls in observability_pipelines/configure_log_archive/amazon_s3/instructions, which is the Log Archives setup and includes rehydration-oriented IAM policy content (including s3:GetObject). On the same page, the destination permission requirements are documented as only s3:ListBucket and s3:PutObject, so readers following the current setup flow can grant broader S3 access than this destination needs. For the new generic Amazon S3 destination, this should use a dedicated setup block (or updated shortcode) that matches the documented required permissions.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
👎 don't need GetObject because you can't rehydrate these logs.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 62f2de4917
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Preview links (active after the
|
1 participant
What does this PR do? What is the motivation?
Merge instructions
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
AI assistance
Additional notes