Skip to content

Add max_timeout to PhaseOrchestrator's arguments#24010

Open
luisorofino wants to merge 1 commit into
loa/task-contextfrom
loa/max-timeout
Open

Add max_timeout to PhaseOrchestrator's arguments#24010
luisorofino wants to merge 1 commit into
loa/task-contextfrom
loa/max-timeout

Conversation

@luisorofino

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds max_timeout to PhaseOrchestrator's arguments, so that long execution flows don't fail. When trying this in a real demo, the previous default (300 seconds) wasn't enough. Now, the default is 600 seconds and it can be set by the orchestrator's callers.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@luisorofino luisorofino added the qa/skip-qa Automatically skip this PR for the next QA label Jun 11, 2026
@luisorofino luisorofino requested a review from a team as a code owner June 11, 2026 08:00
@dd-octo-sts

dd-octo-sts Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Pipelines  Tests  Code Coverage

Fix all issues with BitsAI

⚠️ Warnings

🚦 7 Pipeline jobs failed

PR All | test / j3a8e004 (py3.13-linux-FreeTDS-2019-single) / SQL Server on Linux-py3.13-linux-FreeTDS-2019-single   View in Datadog   GitHub Actions

PR All | test / j47000ee / RethinkDB   View in Datadog   GitHub Actions

PR All | test / j7c68dcb / Control-M   View in Datadog   GitHub Actions

View all 7 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 88.06% (-0.06%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 742f1cb | Docs | Datadog PR Page | Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ddev qa/skip-qa Automatically skip this PR for the next QA team/agent-integrations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants