Skip to content

fixup typo in metric name from kubelet#24018

Open
lavigne958 wants to merge 1 commit into
masterfrom
crayon/fixup_typos_in_metric_name
Open

fixup typo in metric name from kubelet#24018
lavigne958 wants to merge 1 commit into
masterfrom
crayon/fixup_typos_in_metric_name

Conversation

@lavigne958

Copy link
Copy Markdown
Contributor

What does this PR do?

The new metric added in the agent is named limits with an s.

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@datadog-prod-us1-5

This comment has been minimized.

@lavigne958 lavigne958 added the qa/skip-qa Automatically skip this PR for the next QA label Jun 11, 2026
The new metric added in the agent is named `limits` with an s.
same goes for requests.

Signed-off-by: Alexandre Lavigne <alexandre.lavigne@datadoghq.com>
@lavigne958 lavigne958 force-pushed the crayon/fixup_typos_in_metric_name branch from bb764ed to 4111146 Compare June 11, 2026 14:57
@dd-octo-sts

dd-octo-sts Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants