Skip to content

build(native): compile x86_64 Linux lib with -mtls-dialect=gnu2#596

Draft
nsavoire wants to merge 1 commit into
mainfrom
nsavoire/x86_64-tls-dialect-gnu2
Draft

build(native): compile x86_64 Linux lib with -mtls-dialect=gnu2#596
nsavoire wants to merge 1 commit into
mainfrom
nsavoire/x86_64-tls-dialect-gnu2

Conversation

@nsavoire

@nsavoire nsavoire commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

What

Compile the profiler shared library with -mtls-dialect=gnu2 on x86_64 Linux.

Why

TLS descriptors (GNU2 dialect) is required for thread context sharing.

How

  • Factored the shared flags into commonCompilerArgs().
  • Added a new commonLinuxCompilerArgs() helper that appends -mtls-dialect=gnu2 gated on the x86_64 architecture.
  • The ELF-only flag is therefore excluded from macOS (Mach-O, clang would reject it) and ARM64 builds.

Testing

  • ./gradlew -p build-logic :conventions:compileKotlin — build-logic plugin compiles.
  • Full ./gradlew build on macOS/ARM64 succeeds; verified the flag is absent from the local native compile command (correct, since it's x86_64-Linux-only). The x86_64 Linux path is exercised in CI.

🤖 Generated with Claude Code

Use TLS descriptors as required by thread context.
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Pipelines

Fix all issues with BitsAI

⚠️ Warnings

🚦 18 Pipeline jobs failed

CI Run | test-matrix / test-linux-glibc-amd64 (11, debug)   View in Datadog   GitHub Actions

CI Run | test-matrix / test-linux-glibc-amd64 (11-j9, debug)   View in Datadog   GitHub Actions

CI Run | test-matrix / test-linux-glibc-amd64 (17, debug)   View in Datadog   GitHub Actions

View all 18 failed jobs.

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 42151c1 | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

CI Test Results

Run: #27419281211 | Commit: beb8b71 | Duration: 13m 10s (longest job)

13 of 32 test jobs failed

Status Overview

JDK glibc-aarch64/debug glibc-amd64/debug musl-aarch64/debug musl-amd64/debug
8 - - -
8-ibm - - -
8-j9 - -
8-librca - -
8-orcl - - -
11 - - -
11-j9 - -
11-librca - -
17 - -
17-graal - -
17-j9 - -
17-librca - -
21 - -
21-graal - -
21-librca - -
25 - -
25-graal - -
25-librca - -

Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled

Failed Tests

glibc-amd64/debug / 8-orcl

Job: View logs

No detailed failure information available. Check the job logs.

glibc-amd64/debug / 25

Job: View logs

No detailed failure information available. Check the job logs.

glibc-amd64/debug / 8-j9

Job: View logs

No detailed failure information available. Check the job logs.

glibc-amd64/debug / 11-j9

Job: View logs

No detailed failure information available. Check the job logs.

glibc-amd64/debug / 17-graal

Job: View logs

No detailed failure information available. Check the job logs.

glibc-amd64/debug / 25-graal

Job: View logs

No detailed failure information available. Check the job logs.

glibc-amd64/debug / 17-j9

Job: View logs

No detailed failure information available. Check the job logs.

glibc-amd64/debug / 17

Job: View logs

No detailed failure information available. Check the job logs.

glibc-amd64/debug / 8

Job: View logs

No detailed failure information available. Check the job logs.

glibc-amd64/debug / 8-ibm

Job: View logs

No detailed failure information available. Check the job logs.

glibc-amd64/debug / 21-graal

Job: View logs

No detailed failure information available. Check the job logs.

glibc-amd64/debug / 11

Job: View logs

No detailed failure information available. Check the job logs.

glibc-amd64/debug / 21

Job: View logs

No detailed failure information available. Check the job logs.

Summary: Total: 32 | Passed: 19 | Failed: 13


Updated: 2026-06-12 13:55:34 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant