Skip to content

Add dotnet supported cases _dd.svc_src span tag#6496

Merged
NachoEchevarria merged 3 commits intomainfrom
nacho/setServiceSourceTagsExcludeManual
Mar 17, 2026
Merged

Add dotnet supported cases _dd.svc_src span tag#6496
NachoEchevarria merged 3 commits intomainfrom
nacho/setServiceSourceTagsExcludeManual

Conversation

@NachoEchevarria
Copy link
Contributor

@NachoEchevarria NachoEchevarria commented Mar 13, 2026

Motivation

Changes

This PR enables the .NET tracer system tests for the _dd.svc_src span tag, which indicates the source of a service name override (e.g., "m" for manually set values, or integration-defined values for database spans).

These tests were defined here: #6438

Manual scenario is not yet supported.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@NachoEchevarria NachoEchevarria requested review from a team as code owners March 13, 2026 15:42
@NachoEchevarria NachoEchevarria marked this pull request as draft March 13, 2026 15:42
@NachoEchevarria NachoEchevarria changed the title Add dotnet supported cases [DRAFT] Add dotnet supported cases Mar 13, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2026

CODEOWNERS have been resolved as:

manifests/dotnet.yml                                                    @DataDog/apm-dotnet @DataDog/asm-dotnet
utils/build/docker/dotnet/weblog/Dependencies/Sql.cs                    @DataDog/apm-dotnet @DataDog/asm-dotnet @DataDog/system-tests-core

@datadog-official
Copy link

datadog-official bot commented Mar 13, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 3a51628 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@NachoEchevarria NachoEchevarria marked this pull request as ready for review March 13, 2026 16:44
@NachoEchevarria NachoEchevarria requested a review from a team as a code owner March 13, 2026 16:44
@NachoEchevarria NachoEchevarria changed the title [DRAFT] Add dotnet supported cases Add dotnet supported cases Mar 13, 2026
@NachoEchevarria NachoEchevarria changed the title Add dotnet supported cases Add dotnet supported cases _dd.svc_src span tag Mar 13, 2026
Copy link
Contributor

@amarziali amarziali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@NachoEchevarria NachoEchevarria merged commit 114e865 into main Mar 17, 2026
106 checks passed
@NachoEchevarria NachoEchevarria deleted the nacho/setServiceSourceTagsExcludeManual branch March 17, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants