Skip to content

Handle protocol-v1 chunk priority and boolean tags in automated login event tests#6500

Merged
AlexeyKuznetsov-DD merged 8 commits intomainfrom
alexeyk/fix-v1-sampling-priority
Mar 16, 2026
Merged

Handle protocol-v1 chunk priority and boolean tags in automated login event tests#6500
AlexeyKuznetsov-DD merged 8 commits intomainfrom
alexeyk/fix-v1-sampling-priority

Conversation

@AlexeyKuznetsov-DD
Copy link
Contributor

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD commented Mar 13, 2026

Notes for reviewers

Motivation

Java protocol-v1 payloads encode sampling priority and boolean tags differently from older payload assumptions.

Changes

  • Makes assert_priority protocol-v1 aware by checking chunk-level priority.
  • Updates login-event assertions to use normalized boolean checks where needed.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added, removed or renamed?

@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2026

CODEOWNERS have been resolved as:

tests/appsec/test_automated_login_events.py                             @DataDog/asm-libraries @DataDog/system-tests-core

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e341d4cffc

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@datadog-official
Copy link

datadog-official bot commented Mar 13, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: dda46d8 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD merged commit 02ba4be into main Mar 16, 2026
435 checks passed
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD deleted the alexeyk/fix-v1-sampling-priority branch March 16, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants