Handle duplicate data for WQP TDS data #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chasetmartin
approved these changes
May 20, 2025
chasetmartin
left a comment
chasetmartin
left a comment
There was a problem hiding this comment.
Nice work, looks good to me. Only one comment that does not relate to the code logic.
backend/connectors/wqp/source.py
Outdated
| if record["ActivityStartDate"] == date | ||
| } | ||
| if len(date_records.items()) > 1: | ||
| if "70301" in date_records.keys(): |
There was a problem hiding this comment.
Nice! My only suggestion is to consider making your preferred USGSPCodes 70301 and 70303 a variable for reusability and ease of adding new ones, but that's not necessary for functionality.
Contributor
Author
There was a problem hiding this comment.
Good call - that's a good practice. I've made the p codes variables in constants.py so that they can be used throughout (may need them in nwis eventually)
chasetmartin
left a comment
chasetmartin
left a comment
There was a problem hiding this comment.
Looks good to me, like we discussed, just considering adding record date to the log for removing duplicates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.