Skip to content

permission_model#139

Closed
ksmuczynski wants to merge 41 commits into
productionfrom
permission_model
Closed

permission_model#139
ksmuczynski wants to merge 41 commits into
productionfrom
permission_model

Conversation

@ksmuczynski
Copy link
Copy Markdown
Contributor

Why

This PR addresses the following problem / context:

  • Need a polymorphic table to manage and historicize access and usage agreements.

How

Implementation summary - the following was changed / added / removed:

  • Created new Permimssion model with new fields.
  • Added new PermissionMixin to db/base/py file to automatically create a polymorphic One-to-Many relationship to the
    Permission table.

Notes

Any special considerations, workarounds, or follow-up work to note?

  • This PR address the creation of the Permission table only.
  • Related validation schema files and test files still need to be created.
  • Core tables that will inherit from the Permission table still need to be updated (Thing, Location)

jacob-a-brown and others added 30 commits September 10, 2025 13:00
Comment thread services/util.py Dismissed
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 19, 2025

Codecov Report

❌ Patch coverage is 78.81356% with 25 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
services/util.py 56.86% 22 Missing ⚠️
db/base.py 77.77% 2 Missing ⚠️
tests/test_collabnet.py 66.66% 1 Missing ⚠️
Files with missing lines Coverage Δ
api/geospatial.py 97.50% <100.00%> (ø)
api/location.py 93.18% <100.00%> (ø)
constants.py 100.00% <100.00%> (ø)
db/group.py 100.00% <100.00%> (ø)
db/location.py 94.87% <100.00%> (ø)
schemas/location.py 92.72% <100.00%> (ø)
services/geospatial_helper.py 72.09% <100.00%> (ø)
services/location_helper.py 100.00% <100.00%> (ø)
tests/conftest.py 100.00% <ø> (ø)
tests/test_geospatial.py 87.87% <100.00%> (ø)
... and 4 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants