Skip to content

NO TICKET: fix thing_id query parameter for /sensor#145

Merged
jirhiker merged 4 commits into
stagingfrom
jab-sensor-thing-id-fix
Sep 24, 2025
Merged

NO TICKET: fix thing_id query parameter for /sensor#145
jirhiker merged 4 commits into
stagingfrom
jab-sensor-thing-id-fix

Conversation

@jacob-a-brown
Copy link
Copy Markdown
Contributor

Why

This PR addresses the following problem / context:

  • the query parameter ?thing_id broke for /sensor because a sensor was no longer easily connected to a thing via a sample

How

Implementation summary - the following was changed / added / removed:

  • The deployment table is now used as the intermediary

Notes

Any special considerations, workarounds, or follow-up work to note?

  • This gets all sensors related to a thing, regardless of its installation status (installation_date/removal_date). Is this the behavior we want, or should it only retrieve sensors that are currently installed at a thing?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 24, 2025

Codecov Report

❌ Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
api/sensor.py 85.71% 1 Missing ⚠️
Files with missing lines Coverage Δ
tests/conftest.py 98.81% <100.00%> (ø)
tests/test_sensor.py 100.00% <100.00%> (ø)
api/sensor.py 96.42% <85.71%> (ø)

@jirhiker jirhiker merged commit e69f784 into staging Sep 24, 2025
3 checks passed
@TylerAdamMartinez TylerAdamMartinez deleted the jab-sensor-thing-id-fix branch February 5, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants