Skip to content

consolidate-backfill-transfers #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jirhiker merged 2 commits into from
Jan 13, 2026
Merged

consolidate-backfill-transfers #370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
158def4
feat: update thing_id foreign key in NMA_Chemistry_SampleInfo to allo…
jirhiker Jan 13, 2026
3edb1b5
Update db/nma_legacy.py
jirhiker Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions alembic/versions/95d8b982cd5d_add_nma_chemistry_lineage_relations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@ def upgrade() -> None:
inspector = inspect(bind)
columns = {col["name"] for col in inspector.get_columns("NMA_Chemistry_SampleInfo")}
if "thing_id" not in columns:
# Add thing_id FK to NMA_Chemistry_SampleInfo (NOT NULL - no orphans)
# Add thing_id FK to NMA_Chemistry_SampleInfo (nullable to allow legacy orphans)
op.add_column(
"NMA_Chemistry_SampleInfo",
sa.Column("thing_id", sa.Integer(), nullable=False),
sa.Column("thing_id", sa.Integer(), nullable=True),
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The migration creates thing_id as nullable, but the model in db/nma_legacy.py defines it as nullable=False. This inconsistency means existing NULL values from the migration will violate the model constraint. Either update the model to allow NULL values or add a data migration step to populate NULL values before enforcing the NOT NULL constraint.

Copilot uses AI. Check for mistakes.
)

existing_fks = {
Expand Down
2 changes: 1 addition & 1 deletion db/nma_legacy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ class ChemistrySampleInfo(Base):
"SamplePointID", String(10), nullable=False
)

# FK to Thing - required (no orphans)
# FK to Thing - required for all ChemistrySampleInfo records
thing_id: Mapped[int] = mapped_column(
Integer, ForeignKey("thing.id", ondelete="CASCADE"), nullable=False
)
Expand Down
Loading