BDMS-453-Migrate-Hydraulics-1-1 #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # admin/config.py # admin/views/__init__.py # db/nma_legacy.py # transfers/backfill/staging.py
…d update related logic
… search_vector triggers for searchable tables
# Conflicts: # admin/config.py # transfers/backfill/backfill.py
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for migrating legacy hydraulics data from the NMA_HydraulicsData table, including database schema creation via Alembic migrations and a new transfer process integrated into the existing data pipeline.
Changes:
- Introduced
NMAHydraulicsDatamodel and corresponding Alembic migration for the legacy table - Added
HydraulicsDataTransfererto handle data migration with Thing ID caching and batch processing - Integrated hydraulics data transfer into parallel and sequential transfer workflows with configurable
TRANSFER_HYDRAULICS_DATAflag - Added comprehensive unit tests and admin view for the new hydraulics data model
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| transfers/transfer.py | Added hydraulics data transfer integration, new DROP_AND_REBUILD_DB option, and Alembic-based database rebuild functionality |
| transfers/metrics.py | Added metrics tracking for hydraulics data transfers |
| transfers/hydraulicsdata.py | New transferer implementation with Thing ID caching, batch processing, and upsert logic |
| tests/test_hydraulics_data_legacy.py | Comprehensive test suite covering CRUD operations and model validation |
| db/nma_legacy.py | Added NMAHydraulicsData model with legacy column mappings |
| alembic/versions/d1a2b3c4e5f6_create_nma_hydraulicsdata.py | Migration script to create the NMA_HydraulicsData table |
| admin/views/hydraulicsdata.py | Admin interface configuration for viewing hydraulics data |
| admin/views/init.py | Exported new HydraulicsDataAdmin view |
| admin/config.py | Registered hydraulics data admin view |
| README.md | Documentation for DROP_AND_REBUILD_DB environment variable |
…aceChemistry instances
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem / context:
How
Implementation summary - the following was changed / added / removed:
Notes
Any special considerations, workarounds, or follow-up work to note?