Enforce MANAGE permission on RBAC and group admin APIs#2230
Draft
philipfweiss wants to merge 1 commit into
Draft
Enforce MANAGE permission on RBAC and group admin APIs#2230philipfweiss wants to merge 1 commit into
philipfweiss wants to merge 1 commit into
Conversation
Require a matching MANAGE grant to create, modify, hand out, or revoke roles and to administer groups, so principals can only delegate access they already control. Without this, any authenticated user could self-grant arbitrary roles, making restrictive access policies unenforceable. Co-authored-by: Cursor <cursoragent@cursor.com>
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
This was referenced Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking: #2234 (step 1 of the RBAC enablement sequence).
The RBAC engine already exists, but every role/group admin endpoint was auth-only, so any logged-in user could self-grant any role. That makes restrictive access policies unenforceable.
This PR enforces the
MANAGEaction on those endpoints:api/rbac.py): create/update/delete, add/remove scope, assign/revoke now requireMANAGEon the resources the scope targets. You can only grant access you already manage (prevents privilege escalation).api/groups.py): register and membership changes require a globalMANAGEgrant.AccessChecker.add_scope()helper.No-op under the default
permissivepolicy, so nothing breaks today.