Add admin break-glass bypass to RBAC authorization#2232
Draft
philipfweiss wants to merge 1 commit into
Draft
Conversation
Thread is_admin into AuthContext and short-circuit RBAC authorization for admins, approving all requests. The bypass is a single explicit check and is logged for audit, so it is easy to find and to later scope down if admins should still respect some constraints. Co-authored-by: Cursor <cursoragent@cursor.com>
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
This was referenced Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking: #2234 (step 2 of the RBAC enablement sequence).
The RBAC proposal's first resolution step is "if the user is an admin, allow immediately." That short-circuit didn't exist:
is_adminwas on the user model but never consulted in the authorization path, so there was no break-glass and a deny-by-default flip would lock out admins too.This adds it:
is_adminintoAuthContext(fromuser.is_admin).RBACAuthorizationService.authorizeshort-circuits for admins, approving all requests withreason="admin".Kept deliberately in one place so it's easy to later scope down to "admin bypasses grants but still respects X" if needed. No-op for non-admins; default seeded users are non-admin.