Simplify color API: use #DDF4FF default and eliminate bootstrap color classes#26
Open
Simplify color API: use #DDF4FF default and eliminate bootstrap color classes#26
Conversation
Co-authored-by: DataStrategist <8094091+DataStrategist@users.noreply.github.com>
Co-authored-by: DataStrategist <8094091+DataStrategist@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix color API
Fix color API: add custom color support, change defaults, and eliminate Bootstrap terminology
Aug 14, 2025
Owner
|
Too compicated. Simplify your implementation a lot... for example, the default color for buttons should be: |
Co-authored-by: DataStrategist <8094091+DataStrategist@users.noreply.github.com>
…FF, update tests Co-authored-by: DataStrategist <8094091+DataStrategist@users.noreply.github.com>
…tstrap classes Co-authored-by: DataStrategist <8094091+DataStrategist@users.noreply.github.com>
Contributor
Author
I've simplified the implementation significantly as requested. The changes include:
The API is now much cleaner: all color parameters accept actual color values (hex, named, rgb) and the default is the pleasant Commit: cfd0f01 |
Copilot
AI
changed the title
Fix color API: add custom color support, change defaults, and eliminate Bootstrap terminology
Simplify color API: use #DDF4FF default and eliminate bootstrap color classes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR dramatically simplifies the TileMaker color API by removing complex bootstrap color detection logic and standardizing on actual color values.
Key Changes
1. New Default Color
All box functions now use
#DDF4FFas the default color instead of bootstrap class names:2. Eliminated Bootstrap Color Classes
Removed all references to bootstrap color terminology ("primary", "success", "warning", etc.). The API now only accepts actual color values:
3. Simplified Implementation
is_bootstrap_color()helper functionpanel panel-defaultwithbackground-colorCSS4. Preserved Gradient Functionality
solo_gradient_boxretains its pleasant pastel color system:#C8E6C9(pastel green)#FFF9C4(pastel yellow)#FFCDD2(pastel red)5. Text Color Control
The
text_colorparameter continues to work for independent text styling:Technical Benefits
#DDF4FFinstead of generic bootstrap blueBackward Compatibility
This is a breaking change for code using bootstrap color class names. Migration is straightforward:
Fixes #25.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.