feat(CircularGallery): add keyboard navigation support#982
Open
Sarthak-Bhagat2006 wants to merge 1 commit into
Open
feat(CircularGallery): add keyboard navigation support#982Sarthak-Bhagat2006 wants to merge 1 commit into
Sarthak-Bhagat2006 wants to merge 1 commit into
Conversation
6b77d09 to
ff91d0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #981. The CircularGallery component could only be navigated using mouse drag, touch gestures, and mouse wheel scrolling. Keyboard-only users could not interact with the gallery because it was not focusable and did not respond to keyboard input.
This adds keyboard navigation support and accessibility semantics:
ArrowLeftandArrowRightkeyboard navigation.tabIndex={0}so the gallery can receive keyboard focus.role="region"and a descriptivearia-labelfor assistive technologies.Mouse, touch, drag, and wheel behaviour are unchanged.
Updated across all 4 variants (JS/TS × CSS/Tailwind), per the contributing guidelines.
How it was tested
Ran the demo locally and verified in a real browser:
TabArrowLeftnavigates to previous itemArrowRightnavigates to next itemAccessibility
aria-label.