feat(Dock): add keyboard activation and accessible labels#986
Open
Sarthak-Bhagat2006 wants to merge 1 commit into
Open
feat(Dock): add keyboard activation and accessible labels#986Sarthak-Bhagat2006 wants to merge 1 commit into
Sarthak-Bhagat2006 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #985 . The Dock component had
role="button"andtabIndex={0}on items, making them focusable, but pressing Enter or Space did not trigger theonClickhandler — unlike native<button>elements. Items also had no accessible label.This adds keyboard activation and accessibility semantics:
onKeyDownhandler forEnterandSpaceto triggeronClick, withpreventDefault()on Space to avoid page scroll.aria-labelto eachDockItem, derived fromitem.labelwhen it's a plain string.Mouse hover, magnification, and existing click behaviour are unchanged.
Updated across all 4 variants (JS/TS × CSS/Tailwind), per the contributing guidelines.
Note on aria-label
When
labelis a plain string, it's used as thearia-label. Whenlabelis JSX, the item falls back to existing behaviour (noaria-label) — a full fix for JSX labels would need a separate string prop, which felt out of scope here. Happy to add that if preferred.How it was tested
Accessibility
aria-labelbuttonrole