fix small mistakes in header of DDS file that would prevent loading i…#1
Open
thomatoes50 wants to merge 1 commit intoDeanoC:masterfrom
Open
fix small mistakes in header of DDS file that would prevent loading i…#1thomatoes50 wants to merge 1 commit intoDeanoC:masterfrom
thomatoes50 wants to merge 1 commit intoDeanoC:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n DX
My test was just being able to display the texture made from your library in Visual studio (it use DirectX i think)
I also tried XnView on some texture, that the only software that recalculate (don't trust the header)
PitchOrLinearSizefrom the fileThe highlighted variables are the one fixed. They ALL need to have valid values or else DX reject the file
I was not able to test mipmaps with your library, there is a stack corruption happening.
When i have time i will create and upload a small project on github.
Here are the samples
https://nextcloud.beamng.com/s/QGqZZYmK78qMBrD