filter unapproved groups/projects and update 'Country' to 'Country/Region' in Location in "Find Projects

[hyihua]

No description provided.

[PeterBreen]

Maybe I missed this in a team meeting, but why make this change?

[hyihua]

Maybe I missed this in a team meeting, but why make this change?

I was working on the #1039 to verify if the issue was still happening or not. And during the process, I found that some options in the list are not countries but regions, so then I made this change to update the description from "Country" to "Country/Region".

[PeterBreen]

Label changes are managed by a ux design team member; I'll run this by the design lead. If nothing else we have to (try to) keep our design files and deployed site in sync. Shouldn't take long.

[PeterBreen]

When looking into this, I see some evidence #1039 is still a bug, despite the code you found which should have fixed it. For example, on democracylab.org the country dropdown has Åland Islands - we have no projects there when I filter by location so it shouldn't be in the list. Same for Afghanistan and Albania. Andorra is close enough to Spain that a 200mi search picks up a project in Pamplona, but again, no Andorra projects.

all this to say - I don't know if that filter code is working as intended. Do you also see this?

[hyihua]

You're right. It seems that the code snippet I found doesn't work for this issue and the list still contains some countries that don't have projects. I will continue working on this. Thank you for pointing that out.

[PeterBreen]

Our design lead got back to me and is fine with country/region so that change is good to go. I'd request a space between it and (Required), just in case we need to have a line break on a narrow device. Something like Country/Region (Required)

Thanks for spotting this.

[hyihua]

Created an account and a project for replicating this issue. It turns out that the code snippet listed above cannot fix this issue.

[hyihua]

I figured out the reason that why the code snippet I found didn't work for this issue. The reason is that the we only use the is_searchable attribute to filter projects but didn't make filtering for the country list, and that's why we can still see countries with no projects in the country selector.

CC: @PeterBreen @marlonkeating

[hyihua]

@PeterBreen I think this bug is fixed and ready for review now. I created a project for testing and it was pending for approval. And it was not shown in the country list.