fix: critical bug fixes from codebase audit#352
Open
code-by-mahereddy wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Fixes from Codebase Audit
Critical
store.c): Double-percent format string produced wrong SQL LIKE pattern, makingfind_edges_by_url_pathalways failstore.c):like_pool_addcould free pointer, but subsequent code still used itcypher.c):expr_freesilently dropped subtrees when 128-entry stack overflowedHigh
store.c,mcp.c,http_server.c): Project names were not validated before interpolation into file pathsmcp.c): Response missing bothresultanderrorkeys when both were NULLmcp.c):collect_db_project_namesoffset could exceed buffer size on truncationhttp_server.c): Directory names injected raw into JSON without escapingstore.c): Missing NULL guards oncbm_store_checkpoint,cbm_store_node_degree,cbm_store_restore_fromNew utility
cbm_validate_project_name()instr_util.c/h— validates project names are safe for file path constructionAll fixes verified with successful build (
make -f Makefile.cbm cbmwith -Werror).