Skip to content

🎨 Palette: Make clickable cards keyboard accessible #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dev22603 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🎨 Palette: Make clickable cards keyboard accessible #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 2024-05-19 - Missing ARIA Labels on Modal Close Buttons
**Learning:** Icon-only close buttons (like the 'X' in ProjectModal and ExperienceModal) were missing ARIA labels, making them inaccessible to screen readers.
**Action:** Always verify that icon-only buttons include descriptive `aria-label` attributes to ensure keyboard and screen reader accessibility.

## 2024-05-24 - Missing Keyboard Accessibility on Clickable Cards
**Learning:** Interactive `motion.div` elements (like `ProjectCard` and `ExperienceCard`) were missing keyboard accessibility, meaning users navigating with a keyboard couldn't trigger their click actions.
**Action:** When making non-interactive elements like `div` or `motion.div` clickable, always add `role="button"`, `tabIndex={0}`, an `onKeyDown` handler to simulate clicks on Enter/Space, and visible focus styles (`focus-visible`).
13 changes: 12 additions & 1 deletion frontend/src/components/ExperienceCard.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,13 @@ import TechTag from "./TechTag";
import { cn } from "@/lib/utils";

export default function ExperienceCard({ experience, onClick }) {
const handleKeyDown = (e) => {
if (e.key === "Enter" || e.key === " ") {
e.preventDefault();
onClick?.();
}
};

return (
<motion.div
whileHover={{ x: 4 }}
Expand All @@ -17,9 +24,13 @@ export default function ExperienceCard({ experience, onClick }) {
"rounded-xl overflow-hidden",
"transition-all duration-300",
"hover:border-[var(--color-border-secondary)]",
"hover:shadow-[0_10px_40px_-15px_var(--color-primary-dim)]"
"hover:shadow-[0_10px_40px_-15px_var(--color-primary-dim)]",
"focus:outline-none focus-visible:ring-2 focus-visible:ring-[var(--color-primary)] focus-visible:ring-offset-2 focus-visible:ring-offset-[var(--color-background-primary)]"
)}
onClick={onClick}
onKeyDown={handleKeyDown}
role="button"
tabIndex={0}
>
{/* Current status indicator bar */}
{experience.status === "Current" && (
Expand Down
11 changes: 11 additions & 0 deletions frontend/src/components/ProjectCard.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,13 @@ export default function ProjectCard({ project, useModal = false, onModalClick, f
}
};

const handleKeyDown = (e) => {
if (e.key === "Enter" || e.key === " ") {
e.preventDefault();
handleCardClick();
}
};

const statusColors = {
Paused: { bg: "bg-yellow-500/10", text: "text-yellow-400", border: "border-yellow-500/30" },
Completed: { bg: "bg-[var(--color-primary-dim)]", text: "text-[var(--color-primary)]", border: "border-[var(--color-primary)]/30" },
Expand All @@ -33,6 +40,9 @@ export default function ProjectCard({ project, useModal = false, onModalClick, f
whileTap={{ scale: 0.99 }}
transition={{ duration: 0.3 }}
onClick={handleCardClick}
onKeyDown={handleKeyDown}
role="button"
tabIndex={0}
className={cn(
"group relative cursor-pointer h-full",
"bg-[var(--color-background-card)]",
Expand All @@ -41,6 +51,7 @@ export default function ProjectCard({ project, useModal = false, onModalClick, f
"transition-all duration-400",
"hover:border-[var(--color-border-secondary)]",
"hover:shadow-[0_20px_50px_-20px_var(--color-primary-dim)]",
"focus:outline-none focus-visible:ring-2 focus-visible:ring-[var(--color-primary)] focus-visible:ring-offset-2 focus-visible:ring-offset-[var(--color-background-primary)]",
featured && "md:flex md:items-stretch"
)}
>
Expand Down