Skip to content

🎨 Palette: Enhance card keyboard accessibility #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dev22603 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🎨 Palette: Enhance card keyboard accessibility #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 2024-05-19 - Missing ARIA Labels on Modal Close Buttons
**Learning:** Icon-only close buttons (like the 'X' in ProjectModal and ExperienceModal) were missing ARIA labels, making them inaccessible to screen readers.
**Action:** Always verify that icon-only buttons include descriptive `aria-label` attributes to ensure keyboard and screen reader accessibility.

## 2024-05-25 - Interactive Div Keyboard Accessibility
**Learning:** Framer Motion's `<motion.div>` elements used as interactive cards (like Project and Experience cards) aren't keyboard accessible by default, even if they have an `onClick` handler. This prevents keyboard and screen reader users from navigating or interacting with them.
**Action:** Always add `role="button"`, `tabIndex={0}`, an `onKeyDown` handler (for "Enter" and " " keys), and visual focus styles (e.g., `focus-visible:outline-none focus-visible:ring-2`) to interactive `div` or `motion.div` components to ensure they behave like semantic buttons.
2 changes: 1 addition & 1 deletion frontend/eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export default defineConfig([
},
},
rules: {
'no-unused-vars': ['error', { varsIgnorePattern: '^[A-Z_]' }],
'no-unused-vars': ['error', { varsIgnorePattern: '^[A-Z_]', ignoreRestSiblings: true, caughtErrors: 'none' }],
},
},
])
Loading