Skip to content

🎨 Palette: Add keyboard accessibility to interactive cards #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dev22603 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🎨 Palette: Add keyboard accessibility to interactive cards #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 2024-05-19 - Missing ARIA Labels on Modal Close Buttons
**Learning:** Icon-only close buttons (like the 'X' in ProjectModal and ExperienceModal) were missing ARIA labels, making them inaccessible to screen readers.
**Action:** Always verify that icon-only buttons include descriptive `aria-label` attributes to ensure keyboard and screen reader accessibility.

## 2024-05-29 - Missing Keyboard Accessibility on Interactive Divs
**Learning:** The app uses framer-motion's `motion.div` for interactive, clickable cards (e.g., `ExperienceCard`, `ProjectCard`), but these lack native keyboard support (tab indexing, focus states, and Enter/Space key triggers). This makes them inaccessible to keyboard-only users.
**Action:** When using non-interactive elements like `div` or `motion.div` as clickable interactive components, always add `role="button"`, `tabIndex={0}`, an `onKeyDown` handler to simulate clicks on Enter/Space, and `focus-visible` styles to ensure full keyboard accessibility.
2 changes: 1 addition & 1 deletion frontend/eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export default defineConfig([
},
},
rules: {
'no-unused-vars': ['error', { varsIgnorePattern: '^[A-Z_]' }],
'no-unused-vars': ['error', { varsIgnorePattern: '^[A-Z_]|motion' }],
},
},
])
Loading