Material & Fluent themes: ensure compliance with color-contrast requirements according to a11y standards by EugeniyKiyashko · Pull Request #32162 · DevExpress/DevExtreme

EugeniyKiyashko · 2026-01-12T12:24:51Z

No description provided.

…tabs, contextmenu, editors known issues

…disabled state, gantt

…hko/DevExtreme into 26_1_color_contrast

Copilot

Pull request overview

Copilot reviewed 217 out of 451 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (3)

apps/demos/Demos/Gantt/TaskTemplate/ReactJs/styles.css:1

Extra space before semicolon. Remove the trailing space for consistency with other CSS rules in the file.
apps/demos/Demos/Gantt/TaskTemplate/React/styles.css:1
Extra space before semicolon. Remove the trailing space for consistency with other CSS rules in the file.
apps/demos/Demos/Gantt/TaskTemplate/Angular/app/app.component.css:1
Extra space before semicolon. Remove the trailing space for consistency with other CSS rules in the file.

e2e/testcafe-devextreme/helpers/accessibility/test.ts

apps/demos/testing/common.test.ts

apps/demos/Demos/Gantt/TaskTemplate/jQuery/styles.css

apps/demos/Demos/Gantt/TaskTemplate/Vue/App.vue

Copilot

Pull request overview

Copilot reviewed 217 out of 449 changed files in this pull request and generated 5 comments.

Copilot · 2026-02-04T09:33:44Z

e2e/testcafe-devextreme/tests/accessibility/filterBuilder.ts

+      const a11yCheckConfig = {};
+
+      await a11yCheck(t, a11yCheckConfig, '#parentContainer');


The a11yCheckConfig is now an empty object and is declared inside the test iteration. This could be moved outside the forEach loop as a constant to avoid unnecessary object creation on each iteration.

e2e/testcafe-devextreme/tests/accessibility/dataGrid/common.ts

apps/demos/utils/visual-tests/matrix-test-helper.ts

apps/demos/testing/common.test.ts

.github/workflows/testcafe_tests.yml

Copilot

Pull request overview

Copilot reviewed 150 out of 948 changed files in this pull request and generated 2 comments.

apps/demos/testing/common.test.ts

apps/demos/Demos/Scheduler/CellTemplates/jQuery/styles.css

Copilot

Pull request overview

Copilot reviewed 150 out of 946 changed files in this pull request and generated 3 comments.

apps/demos/testing/common.test.ts

.github/workflows/testcafe_tests.yml

apps/demos/Demos/Charts/SignalRService/test-code.js

apps/demos/Demos/DataGrid/BatchEditing/Angular/app/app.component.css

apps/demos/Demos/DataGrid/StatePersistence/Angular/app/app.component.css

apps/demos/Demos/TreeList/FilterModes/Angular/app/app.component.css

apps/demos/Demos/TreeList/StatePersistence/Angular/app/app.component.css

EugeniyKiyashko self-assigned this Jan 12, 2026

EugeniyKiyashko added the 26_1 label Jan 12, 2026

EugeniyKiyashko force-pushed the 26_1_color_contrast branch from 1882cb6 to 0bccf15 Compare January 12, 2026 12:40

Demos: test color-contrast rule

06012bc

EugeniyKiyashko force-pushed the 26_1_color_contrast branch from 0bccf15 to 06012bc Compare January 12, 2026 13:23

EugeniyKiyashko changed the title ~~Demos: test color-contrast rule~~ Components & Demos: test color-contrast rule Jan 22, 2026

EugeniyKiyashko force-pushed the 26_1_color_contrast branch from 1543e79 to 37e97a0 Compare January 22, 2026 15:12

Step1: update base colors

f9dd903

EugeniyKiyashko force-pushed the 26_1_color_contrast branch from 37e97a0 to f9dd903 Compare January 22, 2026 16:22

Step 2: update base colors again. Fix button.disabled, slider, menu, …

6fd1ff8

…tabs, contextmenu, editors known issues

EugeniyKiyashko force-pushed the 26_1_color_contrast branch 2 times, most recently from 28e771e to 7d0b889 Compare January 26, 2026 14:36

skip disabled check for TagBox

9099a51

EugeniyKiyashko force-pushed the 26_1_color_contrast branch from 7d0b889 to 9099a51 Compare January 26, 2026 15:46

EugeniyKiyashko added 2 commits January 26, 2026 21:01

Step 1.2: update base variables in Dark mode

fd7a8ad

Step 2.2: fix scheduler and datagrid error row cases

6aabbcc

EugeniyKiyashko added the skip-cache label Jan 29, 2026

Step 2.3: fix color-contrast issues in PivotGrid, TimeView, checkbox …

9849e10

…disabled state, gantt

EugeniyKiyashko force-pushed the 26_1_color_contrast branch from 4908b43 to 9849e10 Compare January 29, 2026 16:11

EugeniyKiyashko added 5 commits January 29, 2026 20:47

skip demos with false positive issues

e9b8ae6

skip demos with false positive issues

11d0c64

Merge branch '26_1_color_contrast' of https://github.com/EugeniyKiyas…

d9eb13e

…hko/DevExtreme into 26_1_color_contrast

Merge branch '26_1' into 26_1_color_contrast

ed2ac3e

ignore specific rules

f9431e1

EugeniyKiyashko force-pushed the 26_1_color_contrast branch 2 times, most recently from 44991d3 to cd154d9 Compare January 30, 2026 07:36

EugeniyKiyashko removed the skip-cache label Jan 30, 2026

EugeniyKiyashko closed this Jan 30, 2026

EugeniyKiyashko reopened this Jan 30, 2026

EugeniyKiyashko added the skip-cache label Jan 30, 2026

EugeniyKiyashko added 2 commits February 4, 2026 12:45

update etalons

e770f9f

Merge branch '26_1_color_contrast' of https://github.com/EugeniyKiyas…

0631fc8

…hko/DevExtreme into 26_1_color_contrast

EugeniyKiyashko removed the skip-cache label Feb 4, 2026

Merge branch '26_1' into 26_1_color_contrast

e5db3e1

Copilot AI review requested due to automatic review settings February 4, 2026 08:51

Copilot AI reviewed Feb 4, 2026

View reviewed changes

EugeniyKiyashko added skip-cache force all tests labels Feb 4, 2026

Copilot AI review requested due to automatic review settings February 4, 2026 09:32

EugeniyKiyashko force-pushed the 26_1_color_contrast branch from 4560c9a to e37a226 Compare February 4, 2026 09:32

Copilot AI reviewed Feb 4, 2026

View reviewed changes

fix typos

3ab2d39

EugeniyKiyashko force-pushed the 26_1_color_contrast branch from e37a226 to 3ab2d39 Compare February 4, 2026 09:53

Copilot AI review requested due to automatic review settings February 4, 2026 10:08

Copilot AI reviewed Feb 4, 2026

View reviewed changes

apps/demos/testing/common.test.ts Show resolved Hide resolved

apps/demos/Demos/Scheduler/CellTemplates/jQuery/styles.css Show resolved Hide resolved

remove demo etalons

7c1d370

EugeniyKiyashko force-pushed the 26_1_color_contrast branch from 2c1b195 to 7c1d370 Compare February 4, 2026 10:19

EugeniyKiyashko removed the force all tests label Feb 4, 2026

update material etalons

85b23dd

Copilot AI review requested due to automatic review settings February 4, 2026 11:06

Merge branch '26_1' into 26_1_color_contrast

19e81b2

Copilot AI reviewed Feb 4, 2026

View reviewed changes

apps/demos/testing/common.test.ts Show resolved Hide resolved

.github/workflows/testcafe_tests.yml Show resolved Hide resolved

apps/demos/Demos/Charts/SignalRService/test-code.js Show resolved Hide resolved

Zedwag approved these changes Feb 4, 2026

View reviewed changes

marker-dao approved these changes Feb 4, 2026

View reviewed changes

alexslavr approved these changes Feb 4, 2026

View reviewed changes

dmlvr approved these changes Feb 4, 2026

View reviewed changes

Raushen approved these changes Feb 4, 2026

View reviewed changes

aleksei-semikozov approved these changes Feb 4, 2026

View reviewed changes

EugeniyKiyashko merged commit f153a58 into DevExpress:26_1 Feb 4, 2026
101 checks passed

dmirgaev reviewed Feb 4, 2026

View reviewed changes

		const a11yCheckConfig = {};

		await a11yCheck(t, a11yCheckConfig, '#parentContainer');

Conversation

EugeniyKiyashko commented Jan 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants